Go to:
Gentoo Home
Documentation
Forums
Lists
Bugs
Planet
Store
Wiki
Get Gentoo!
Gentoo's Bugzilla – Attachment 603222 Details for
Bug 700904
devmanual: use rsvg-convert to build png images
Home
|
New
–
[Ex]
|
Browse
|
Search
|
Privacy Policy
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0002-Makefile-use-rsvg-convert-to-generate-PNGs-from-SVGs.patch
0002-Makefile-use-rsvg-convert-to-generate-PNGs-from-SVGs.patch (text/plain), 2.09 KB, created by
Michael Orlitzky
on 2020-01-14 00:06:14 UTC
(
hide
)
Description:
0002-Makefile-use-rsvg-convert-to-generate-PNGs-from-SVGs.patch
Filename:
MIME Type:
Creator:
Michael Orlitzky
Created:
2020-01-14 00:06:14 UTC
Size:
2.09 KB
patch
obsolete
>From dba38a1ecb77fcf789051dd91e920a803ff7122b Mon Sep 17 00:00:00 2001 >From: Michael Orlitzky <mjo@gentoo.org> >Date: Mon, 9 Dec 2019 22:10:18 -0500 >Subject: [PATCH 2/2] Makefile: use rsvg-convert to generate PNGs from SVGs. > >Our Makefile currently uses inkscape (via imagemagick's "convert" >wrapper) to turn SVGs into PNGs. This has a few downsides: > > * media-gfx/inkscape is a huge dependency, > * inkscape is slow to perform the conversion, > * installing imagemagick[svg] doesn't ensure that "convert" can > convert an SVG to a PNG if inkscape is missing (bug 684686). > >The good news is that there is another SVG -> PNG conversion tool >called rsvg-convert that is installed by gnome-base/librsvg. Compared >to inkscape, librsvg is a light dependency and rsvg-convert is >lightning-fast. Moreover, installing gnome-base/librsvg guarantees >that the latter will exist and can actually perform the conversion. > >Inkscape is supposedly more powerful, but so far in the devmanual >we're only using SVG to put words in boxes. The simpler tool is >sufficient for that, and therefore preferable. > >This commit updates the Makefile to use rsvg-convert. > >Bug: https://bugs.gentoo.org/684686 >Closes: https://bugs.gentoo.org/700904 >--- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Makefile b/Makefile >index a6df3be..96a91dd 100644 >--- a/Makefile >+++ b/Makefile >@@ -10,8 +10,8 @@ IMAGES := $(patsubst %.svg,%.png,$(SVGS)) > all: prereq validate $(HTMLS) $(IMAGES) documents.js > > prereq: >- @type convert >/dev/null 2>&1 || \ >- { echo "media-gfx/imagemagick[corefonts,svg,truetype] required" >&2;\ >+ @type rsvg-convert >/dev/null 2>&1 || \ >+ { echo "gnome-base/librsvg required" >&2;\ > exit 1; } > @type xsltproc >/dev/null 2>&1 || \ > { echo "dev-libs/libxslt is with python required" >&2;\ >@@ -29,7 +29,7 @@ documents.js: bin/build_search_documents.py $(XMLS) > mv _documents.js documents.js > > %.png : %.svg >- convert $< $@ >+ rsvg-convert --output=$@ $< > > # Secondary expansion allows us to use the automatic variable $@ in > # the prerequisites. When it is used (and we have no idea when that >-- >2.24.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 700904
:
603220
|
603222
|
603224
|
603226
|
603228
|
603230
|
603232
|
603234
|
603236
|
603238
|
603240
|
603242
|
603588
|
603590
|
603592
|
603594
|
603596
|
603598
|
603600
|
603602
|
604354
|
604422
|
604424
|
604426
|
604610
|
604614
|
604616
|
604618