Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 99753 - linux-atm-2.4.1-r1 fails with gcc-4.x (corrective patches attached)
Summary: linux-atm-2.4.1-r1 fails with gcc-4.x (corrective patches attached)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2005-07-20 22:30 UTC by kfm
Modified: 2005-07-21 12:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
linux-atm-2.4.1-r1.ebuild -> linux-atm-2.4.1-r2.ebuild (patch) (linux-atm-2.4.1-r2.ebuild.diff.txt,1.64 KB, patch)
2005-07-20 22:31 UTC, kfm
Details | Diff
files/2.4.1-gcc4.patch (2.4.1-gcc4.patch,3.31 KB, patch)
2005-07-20 22:33 UTC, kfm
Details | Diff
files/2.4.1-stdlib.patch (2.4.1-stdlib.patch,1.19 KB, patch)
2005-07-20 22:34 UTC, kfm
Details | Diff
linux-atm-2.4.1-r1.ebuild -> linux-atm-2.4.1-r2.ebuild (patch) (linux-atm-2.4.1-r2.ebuild.diff.txt,1.65 KB, patch)
2005-07-21 03:37 UTC, kfm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kfm 2005-07-20 22:30:22 UTC
net-dialup/linux-atm-2.4.1-r1.ebuild fails to build with gcc-4.x (specifically,
I've tested it with gcc-4.0.1). I'm going to attach 3 things here:

1) Proposed linux-atm-2.4.1-r1.ebuild -> linux-atm-2.4.1-r2.ebuild diff
2) 2.4.1-gcc4.patch
3) 2.4.1-stdlib.patch

The patches are lifted from Fedora Core 4. The result is as follows:

* Slightly more explanatory ebuild
* gcc-4.x compilation errors are fully corrected
* Missing includes for <stdlib.h> added for the strtol prototype which is used
in sigd/cfg_y.y (in the linux-atm source code)

The ebuild features keywords for all the arches mentioned in the previous ebuild
revision. However, they have all been ~arch keyworded. Please commit!
Comment 1 kfm 2005-07-20 22:31:44 UTC
Created attachment 63944 [details, diff]
linux-atm-2.4.1-r1.ebuild -> linux-atm-2.4.1-r2.ebuild (patch)
Comment 2 kfm 2005-07-20 22:33:19 UTC
Created attachment 63946 [details, diff]
files/2.4.1-gcc4.patch

Identical to "linux-atm-2.5.0-gcc4.patch" In the Fedora Core 4 package.
Comment 3 kfm 2005-07-20 22:34:04 UTC
Created attachment 63947 [details, diff]
files/2.4.1-stdlib.patch

Identical to "linux-atm-2.5.0-stdlib.patch" in the Fedora Core 4 package.
Comment 4 kfm 2005-07-20 22:36:15 UTC
Note also that, although the original patches were against a 2.5 snapshot, they
work fine here. The only reason Fedora updated to a CVS snapshot was to acquire
bridging RFC2684 functionality. Looks like it will be a while before 2.5 goes
gold so I think this should be committed in the meantime.
Comment 5 kfm 2005-07-21 03:37:53 UTC
Created attachment 63962 [details, diff]
linux-atm-2.4.1-r1.ebuild -> linux-atm-2.4.1-r2.ebuild (patch)

Missing epatch statement in the previous attachment (doh).
Comment 6 Alin Năstac (RETIRED) gentoo-dev 2005-07-21 12:55:09 UTC
fixed without revision bumping. no need to bump since this doesn't do anything
else except fixing compilation problems on gcc-4.

thanks.