Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 9909 - fluxbox-0.1.12-r2 fails if -nls is present in use variables
Summary: fluxbox-0.1.12-r2 fails if -nls is present in use variables
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: Normal minor (vote)
Assignee: Matt Keadle
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-29 12:26 UTC by Jeff Rollins
Modified: 2003-02-04 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Revised ebuild (fluxbox-0.1.12-r10.ebuild,1.23 KB, text/plain)
2002-10-29 12:44 UTC, Jeff Rollins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Rollins 2002-10-29 12:26:39 UTC
The remember patch provided on the fluxbox.org page states it will fail if nls
is disabled - check for this in the use variables?
Comment 1 Jeff Rollins 2002-10-29 12:44:12 UTC
Created attachment 5181 [details]
Revised ebuild

I think this oughta fix it - worked for me.  Someone else want to test?
Comment 2 Matt Keadle 2002-10-30 01:08:45 UTC
See, here's the thing. The only difference between -r2 and -r1 is the remember
patch. So removing the remeber patch leaves no reason to go to an -r2.
Implementing the `use nls &&` works fine, but if that step is skipped you're
left with no reason to run -r2. *This* is why it is ~ keyworded, and not put
forward as  a stable build. I'm aware of the issues with the patch and nls, and
honestly I'm still trying to work out the best way to deal with it.

I've thought of adding something like:

if [ -n "`use nls`" ]
then
    ewarn "You currently have -nls in your USE. This build of Fluxbox will not"
    ewarn "build if nls is disabled."
    exit 1
fi
Comment 3 Matt Keadle 2002-10-30 01:10:50 UTC
Also.. *PLEASE* when including a text attatchment remember to set the type as
'text/plain'.
Comment 4 Jeff Rollins 2002-10-30 10:43:14 UTC
Sorry about that, I'm kinda new at this.  I understand completely about the
whole r2 thing - I had forgotten that i had put ~x86 in my make.conf.  Thanks
for checking into it - I'm sure whatever solution you come up with will work
fine.  Sorry for the confusion.
Comment 5 Kurt Hindenburg 2002-11-01 00:15:53 UTC
Yea, I would go with the the test below; that way people have an idea what's up.

if [ -n "`use nls`" ]
then
    ewarn "You currently have -nls in your USE. This build of Fluxbox will not"
    ewarn "build if nls is disabled."
    exit 1
fi

Kinda odd that the remember patch requires nls.  I wonder if this a
bug/misfeature in the remember patch.

USE="nls" emerge fluxbox
works fine with 0.1.12-r2
Comment 6 Matt Keadle 2002-11-04 16:44:51 UTC
I've added the `if [ ! "`use nls`" ]` test to the existing -r2 ebuild. It
directs the user to run `USE="nls" emerge fluxbox` if the test fails. This build
is still ~ keyworded and not released to general population.
Comment 7 Matt Keadle 2002-11-07 15:28:01 UTC
I think this package is best left as "unstable", IE ~keyworded permanantly. I'm
hearing rumors that Fluxbox 0.1.13 will have AA text and generally be overall
neat. This remember patch is nice, but the nls thing coupled with rare crashes
just won't make it into stable. I'm setting this to FIXED. I've you've got any
issues with the 0.1.12-r2 release, consider running Fluxbox without the remember
patch, waiting for 0.1.13, or dealing with the remember patch through other means.

Cheers, and thanks for the help guys!