Bugzilla Bug 98654

There is a conflicting definition in gifcodec.c / gifcodec.h. I attached a
patch
to fix this.

Reproducible: Always
Steps to Reproduce:
1. emerge libgdiplus-1.1.8 with all the USE flags on
2.
3.

Created an attachment (id=63126) [edit]
Compilation fix

Created an attachment (id=63127) [edit]
ebuild using the patch

Seems to be fixed with giflib 1.4.3-r1 - compiles successfully without ebuild
patch

There is a similar patch in the 1.1.8 ebuild right now, which currently causes
no problems here. Can you please report if you are still having problems, and
the exact error, when trying to build libgdiplus-1.1.8? Thanks.

A fresh emerge sync && emerge libgdiplus (1.1.8 ~x86) still leads to the same
error as before:

[...]
 i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../libpixman/src
-I../libpixman/src -I../cairo/src -I../cairo/src -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -Wall -Werror -Wno-unused
-Wno-format -O2 -march=pentium3 -fomit-frame-pointer -pipe -pthread -MT
gifcodec.lo -MD -MP -MF .deps/gifcodec.Tpo -c gifcodec.c  -fPIC -DPIC -o
.libs/gifcodec.o
gifcodec.c:611: error: conflicting types for `gdip_save_gif_image_to_file'
gifcodec.h:24: error: previous declaration of `gdip_save_gif_image_to_file'
make[2]: *** [gifcodec.lo] Fehler 1
make[2]: Leaving directory
`/var/tmp/portage/libgdiplus-1.1.8/work/libgdiplus-1.1.8/src'
make[1]: *** [all-recursive] Fehler 1
make[1]: Leaving directory `/var/tmp/portage/libgdiplus-1.1.8/work/libgdiplus-1.1.8'
make: *** [all] Fehler 2

!!! ERROR: dev-dotnet/libgdiplus-1.1.8 failed.
!!! Function src_compile, Line 52, Exitcode 2
!!! (no error message)
!!! If you need support, post the topmost build error, NOT this status message.

Somehow, a giflib update from 4.1.0-r3 to 4.1.3 made libgdiplus-1.1.8 emerge
fine. To me, it still looks like a simple bug in the implementation, but it
seems to work with an up-to-date x86 system.

(In reply to comment #6)
> Somehow, a giflib update from 4.1.0-r3 to 4.1.3 made libgdiplus-1.1.8 emerge
> fine. To me, it still looks like a simple bug in the implementation, but it
> seems to work with an up-to-date x86 system.

Said update also causes it to compile on amd64

I've bumped the required giflib version in both 1.1.8 and the new 1.1.9. I
double checked 1.1.9, and the code in question was also fixed. Marking this bug
FIXED.