Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 98524 - www-apps/drupal calls wget in src_unpack/pkg_config
Summary: www-apps/drupal calls wget in src_unpack/pkg_config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Lim Swee Tat (RETIRED)
URL:
Whiteboard:
Keywords: PMASKED
: 96908 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-07-09 18:29 UTC by Sven Wegener
Modified: 2006-11-28 07:09 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Wegener gentoo-dev 2005-07-09 18:29:29 UTC
Please remove the wget code from src_unpack and move the files to SRC_URI so
that they can be pre-downloaded with emerge -f and portage can verify the
authenticity of downloaded files.

drupal-4.5.2
[...]
                wget http://www.drupal.org/files/projects/bbcode-${MOD_PV}.tar.gz
                tar xfz bbcode-${MOD_PV}.tar.gz
                einfo "Unpacking blogroll"
                wget http://www.drupal.org/files/projects/blogroll-${MOD_PV}.tar.gz
                tar xfz blogroll-${MOD_PV}.tar.gz
                einfo "Unpacking bookreview"
                wget http://www.drupal.org/files/projects/bookreview-${MOD_PV}.tar.gz
                tar xfz bookreview-${MOD_PV}.tar.gz
                einfo "Unpacking bookmarks"
[...]

drupal-4.6.2
[...]
                        for item in `cat ${FILESDIR}/${MY_PV}/$i`; do
                                einfo "Unpacking $item"
                                wget -q http://www.drupal.org/files/projects/$item-${MY_PV}.tar.gz
                                tar xfz $item-${MY_PV}.tar.gz
                        done
[...]
Comment 1 Lim Swee Tat (RETIRED) gentoo-dev 2005-07-27 09:20:51 UTC
Reference bug #89125

You will notice that the modules simply cannot be put into portage because
upstream uploads and updates packages without changing version numbers.

Regards
Lim Swee Tat
Comment 2 SpanKY gentoo-dev 2005-07-27 13:51:28 UTC
then you have to do one of the following:
keep the digests up-to-date yourself and put in RESTRICT=mirror
complain to upstream about their poor packaging habits
rename the tarballs with custom stamps and put those into SRC_URI / gentoo mirrors
Comment 3 Lim Swee Tat (RETIRED) gentoo-dev 2005-08-04 01:57:55 UTC
Moved the calls to pkg_config.  Does this solve everyone's issue?  I prefer not
to move this to another package since the effort involved is really not worth
it.  Email me if you still have a problem.

Regards
Lim Swee Tat
Comment 4 Sven Wegener gentoo-dev 2005-08-04 03:43:49 UTC
Yuck, this makes it even worse. It's a webapp and slotted to ${PVR} meaning the
user has to run the config every time a new version is installed. And the files
are not recorded in the package database resulting in stale files being left
around after unmerging.

Just create yourself a small script that downloads the files and tars them up into
a datestamped tarball. The tarball is uploaded to our mirrors and you can put it
into SRC_URI for downloading.
Comment 5 Lim Swee Tat (RETIRED) gentoo-dev 2005-11-05 21:12:55 UTC
I'll prefer to not use that approach since I prefer that users get the latest,
bestest mods.  It's a reasonable approach though.
  Actually, if you look at the situation now, the ideal is that even with 4.6.3
installed, there are updates to the modules, and themes that warrant just
running an update of the modules and themes only.
Comment 6 Sven Wegener gentoo-dev 2005-11-06 23:19:41 UTC
If you download files directly (actually, you should never do this) you shouldn't
mark the ebuilds stable, as you'll never know in what shape the mods will be in
the future.
Comment 7 Brian Harring (RETIRED) gentoo-dev 2005-11-07 18:35:56 UTC
Split the additional modules off into seperate packages (snapshotting the
release on our mirrors) if you're after not forcing a full update to the
framework for each module release.

Meanwhile, wget'ing within config is a no go; great way to orphan files.
Comment 8 Mark Loeser (RETIRED) gentoo-dev 2006-02-12 17:14:55 UTC
st_lim: can we please get this fixed?

Also, your description in the ebuild is incredibly long.  Make it short and sweet and put the long description in metadata.xml.
Comment 9 Lars Strojny 2006-03-07 02:00:03 UTC
What's the current state of this bug?
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2006-09-09 11:53:09 UTC
*** Bug 96908 has been marked as a duplicate of this bug. ***
Comment 11 Christel Dahlskjaer (RETIRED) gentoo-dev 2006-09-09 12:20:49 UTC
Since noone seems interested in fixing this, it's been package.masked and will be removed soon unless someone steps up to resolve the outstanding issues.
Comment 12 Gilles Dartiguelongue (RETIRED) gentoo-dev 2006-09-15 12:52:59 UTC
hi, I'm stepping up :)

What about not downloading mods, just draft up a script that does the wget magic to get the latest mods and tell the user at postinst that he needs to use that script to get mods so that he can actually use its drupal install. And obviously there should be a warning about the mods not being supported by gentoo if they fail since they are not properly packaged in a way that eases bugtracking for us.
Comment 13 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-09-15 14:36:46 UTC
(In reply to comment #12)
> hi, I'm stepping up :)
> 
> What about not downloading mods, just draft up a script that does the wget
> magic to get the latest mods and tell the user at postinst that he needs to use
> that script to get mods so that he can actually use its drupal install. And
> obviously there should be a warning about the mods not being supported by
> gentoo if they fail since they are not properly packaged in a way that eases
> bugtracking for us.
> 

eselect drupal module maybe? :)
Comment 14 Danny van Dyk (RETIRED) gentoo-dev 2006-09-16 02:25:19 UTC
> > What about not downloading mods, just draft up a script that does the wget
> > magic to get the latest mods and tell the user at postinst that he needs to use
> > that script to get mods so that he can actually use its drupal install. And
> > obviously there should be a warning about the mods not being supported by
> > gentoo if they fail since they are not properly packaged in a way that eases
> > bugtracking for us.
 
> eselect drupal module maybe? :)
 
Only under 2 prerequistes:
a) The module doesn't need to download anything.
b) The module doesn't need to copy whole directories/bunches of files,
   but rather symlinks or changes configuration variables.

In short: eselect is no package manager and never will be.
Comment 15 Thomas R. (TRauMa) 2006-11-05 08:36:15 UTC
As far as I can see, right now the wget part only potentially get's called for drupal 4.6.0:

Quote:
   for item in `cat ${PORTDIR}/www-apps/${PN}/files/${MY_PV}/$i`; do
       einfo "Unpacking $item"
       wget -q http://www.drupal.org/files/projects/$item-${MY_PV}.tar.gz
/Quote

 #find /usr/portage/www-apps/drupal/files/ -type d
 /usr/portage/www-apps/drupal/files/
 /usr/portage/www-apps/drupal/files/4.6.0

And in there is not just a "selection of modules", but any drupal module I ever heard of and then some. So why not just drop pkg_postinst() and pkg_config() and be done with it?
Comment 16 Jesse Adelman 2006-11-05 15:21:57 UTC
Re Comment #11:

Yikes. Please don't drop Drupal from Portage. Has anyone bothered to ask upstream to get their act together and make real managed releases of the modules?
Comment 17 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-11-05 15:28:57 UTC
(In reply to comment #16)
> Re Comment #11:
> 
> Yikes. Please don't drop Drupal from Portage. Has anyone bothered to ask
> upstream to get their act together and make real managed releases of the
> modules?
> 

Yes and they have, chill.  No noe is removing it quite yet.
Comment 18 Roy Marples (RETIRED) gentoo-dev 2006-11-28 07:09:16 UTC
drupal-4.7.4 doesn't install any 3rd party modules.

If users want them they can install them by hand, like all other web apps with plugins.