98237 – app-portage/eix-0.2.6 applies patches in src_compile instead of src_unpack

Bug 98237 - app-portage/eix-0.2.6 applies patches in src_compile instead of src_unpack

Summary: app-portage/eix-0.2.6 applies patches in src_compile instead of src_unpack

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High minor (vote)
Assignee:	Benedikt Böhm (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-07-07 09:30 UTC by Karl-Johan Karlsson
Modified:	2005-07-07 12:48 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Karl-Johan Karlsson 2005-07-07 09:30:27 UTC

app-portage/eix-0.2.6 applies a patch (epatch ${FILESDIR}/0.2.6-package.cc.
patch) in src_compile. This makes it hard to make incremental changes to the 
source tree, and is not allowed according to the Ebuild HOWTO. Patches should be 
applied in src_unpack.

Reproducible: Always
Steps to Reproduce:
1. Try to install eix-0.2.6. Have it die with a compilation failure due to bug 
#98218.
2. Apply the patch from bug #98218 to the half-built source tree.
3. Try to compile it again with "ebuild".
Actual Results:  
Compilation fails with this message:

>>> WORKDIR is up-to-date, keeping...
 * Applying 0.2.6-package.cc.patch ...

 * Failed Patch: 0.2.6-package.cc.patch !
 *  ( /usr/portage/app-portage/eix/files/0.2.6-package.cc.patch )

Comment 1 Benedikt Böhm (RETIRED) gentoo-dev

2005-07-07 12:48:47 UTC

fixed