The script tools/backup/hot-backup.py gets installed as /usr/bin/svn-hot-backup. It contains a configurable parameter num_backups, defining how many copies of your backed up repositories you'd like to keep. Upstrems default value is 64. This tends to fill up backup partitions (at least in my case) rather quickly. It's ease to change the parameter, but after an upgrade of subversion, the original value of 64 is restored. I suggest to put this configuration as an environment variable into /etc/env.d/80subversion instead. Thus any configuration changes survive an upgrade. Reproducible: Always Steps to Reproduce: 1. adjust line 37 in /usr/bin/svn-hot-backup 2. emerge subversion 3. check the changes from step 1 Actual Results: configuration changes disappear Expected Results: configuration changes survive the upgrade I have added a patch against the hotbackup-script (expected to be in the files directory) & a patch against subversion-1.2.0.ebuild to get subversion-1.2.1.ebuild. Watch out, the latter patch also addresses the following bugs: - Bug 98071: Update to subversion-1.2.1 - Bug 94791: Install svn-book correctly, typo.
Created attachment 62739 [details, diff] Adjust ebuild, based on subversion-1.2.0.ebuild, targetted at subversion-1.2.1 Cp subversion-1.2.0.ebuild to subversion-1.2.1.ebuild. Apply patch.
Created attachment 62740 [details, diff] patch used by the ebuild to patch hot-backup.py to be placed in the filesdir
Comment on attachment 62740 [details, diff] patch used by the ebuild to patch hot-backup.py ><HTML><BODY TEXT="#000000"><PRE>--- tools/backup/hot-backup.py.in.orig 2003-12-16 17:41:14.000000000 +0100 >+++ tools/backup/hot-backup.py.in 2005-07-06 10:44:55.000000000 +0200 >@@ -34,7 +34,14 @@ > svnadmin = "@SVN_BINDIR@/svnadmin" > > # Number of backups to keep around (0 for "keep them all") >-num_backups = 64 >+# Configurable in /etc/env.d/80hotbackup >+envvar_hb_num='SVN_HOTBACKUP_NUM_BACKUPS' >+if os.environ.has_key(envvar_hb_num): >+ num_backups = int(os.environ[envvar_hb_num]) >+else: >+ num_backups = 64 >+print 'Keeping up to', num_backups, 'around.' >+ > > ###################################################################### > # Command line arguments
Created attachment 62857 [details, diff] patch used by the ebuild to patch hot-backup.py (update) Sorry about that, I have initially attached a buggy version of the script. This time it should work
I'll look at this soon. I'm currently in the progress of moving. While internet should continue to function for me, I have my arms full of paint, with only the end of the evening to check on things like gentoo. In the meanwhile I'll submit a 1.2.1 ebuild that is just a copy of the old one.
Created attachment 67175 [details] Adjusted ebuild derived from subversion-1.2.3-r1 updated ebuild, this time not automatically writing /etc/env.d/80subversion but referring to it in the postinstall text
*** Bug 94791 has been marked as a duplicate of this bug. ***
Created attachment 70829 [details, diff] Patch against the official ebuild This patch introduces the changes discussed above against the current ebuild subversion-1.2.3-r2.ebuild.
I've just committed -r3 that implements the patches. Thanks for the patience.
