Bugzilla Bug 95104

amule 2.0.2 has just been released. I'll append a new ebuild.

Reproducible: Always
Steps to Reproduce:

Created an attachment (id=60629) [edit]
new ebuild for amule-2.0.2

After taking a closer look at the ebuild I saw some possibilities for
optimization.

Changes:
- amulecmdgui and amulewebgui are no longer built as they are meant for a
non-commandline-OS like Win32 (amulecmd & amuleweb are still built if "remote"
is set)
- If the USE flag "X" is not set the monolithic amule app is not built (useful
for headless machines running amuled)
- Introduced a new USE flag "amuleremotegui" for the amule remote gui. The old
way of building the remote gui when the daemon was built was not the best
solution in my opinion. Also note: The remote gui is still experimental and not
completed! You can watch your downloads, but you can't set preferences or see
the stats.
- The ebuild checks if "-X" and "amuleremotegui" is set and dies with an error
message if that is the case.

There was support for /etc/init.d/amuled & /etc/conf.d/amuled &
/etc/init.d/amuleweb & /etc/conf.d/amuleweb added in the 2.0.0 and 2.0.1 ebuild
but the actual files got lost and never reached portage. I will repost them
here...

Created an attachment (id=60641) [edit]
New ebuild for amule-2.0.2

New ebuild, for changes see above.

Created an attachment (id=60642) [edit]
/etc/conf.d for amuled

Created an attachment (id=60643) [edit]
/etc/init.d/amuled

Created an attachment (id=60644) [edit]
/etc/conf.d/amuleweb

Created an attachment (id=60645) [edit]
/etc/init.d/amuleweb

Created an attachment (id=60650) [edit]
amule 2.0.2 unicode support

Michael, i have had some troubles with the latest ebuilds.
wxGTK 2.6.0 uses a different flag from the 2.4 release: gtk2-unicode instead of
unicode, that's why the bug of "recompile wxGTK with unicode support" shows up.
The workaround is not pretty, but at least it does not give error messages.

This is the modified ebuild with your changes. 

(From update of attachment 60650 [edit])
# Copyright 1999-2005 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/net-p2p/amule/amule-2.0.1.ebuild,v 1.3
2005/06/02 18:30:30 sekretarz Exp $

inherit eutils flag-o-matic wxwidgets

MY_P=${P/m/M}
S=${WORKDIR}/${MY_P}

DESCRIPTION="aMule, the all-platform eMule p2p client"
HOMEPAGE="http://www.amule.org/"
SRC_URI="http://download.berlios.de/${PN}/${MY_P}.tar.bz2"

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~x86 ~amd64 ~ppc ~ppc64 ~sparc ~alpha"
IUSE="amuled amuleremotegui debug gtk2 nls remote stats unicode X"


DEPEND=">=x11-libs/wxGTK-2.6.0
	>=sys-libs/zlib-1.2.2
	nls? ( sys-devel/gettext )
	remote? ( >=media-libs/libpng-1.2.8 )
	stats? ( >=media-libs/gd-2.0.32 )
	!net-p2p/xmule"

pkg_setup() {
	export WX_GTK_VER="2.6"
	if ! use gtk2; then
		need-wxwidgets gtk
	elif use unicode; then
		need-wxwidgets gtk2-unicode
	else
		need-wxwidgets gtk2
	fi

	if ! use X && use amuleremotegui; then
		die "You cannot set amuleremotegui while X is not set in your
USE flags."
	fi
}

src_compile() {
	if ! use X; then
		EXTRA_ECONF="--disable-monolithic"
	fi

	econf \
		--disable-optimize \
		--with-wx-config=${WX_CONFIG} \
		--with-wxbase-config=${WX_CONFIG} \
		`use_enable amuled amule-daemon` \
		`use_enable amuleremotegui amule-gui` \
		`use_enable debug` \
		`use_enable nls` \
		`use_enable remote amulecmd` \
		`use_enable remote webserver` \
		`use_enable stats cas` \
		`use_enable stats wxcas` \
		`use_enable stats alc` \
		`use_enable stats alcc` \
		|| die
	# we filter ssp until bug #74457 is closed to build on hardened
	if has_hardened; then
	filter-flags -fstack-protector -fstack-protector-all
	fi
	emake -j1 || die
}

src_install() {
	make DESTDIR=${D} install || die

	if use amuled || use remote; then
		if ! id p2p >/dev/null; then
			enewgroup p2p
			enewuser p2p -1 /bin/false /home/p2p p2p
		fi
	fi

	if use amuled; then
		insinto /etc/conf.d; newins ${FILESDIR}/amuled.confd amuled
		exeinto /etc/init.d; newexe ${FILESDIR}/amuled.initd amuled
	fi

	if use remote; then
		insinto /etc/conf.d; newins ${FILESDIR}/amuleweb.confd amuleweb
		exeinto /etc/init.d; newexe ${FILESDIR}/amuleweb.initd amuleweb
	fi
}

Created an attachment (id=60652) [edit]
amule 2.0.2 unicode

Request - Please add another dependency:

media-libs/gd

should be added to the dependencies if
- webserver support is is built ('remote' use flag)
and
- unicode is enabled ('unicode' use flag).

Otherwise the Webserver will have missing/corrupted progress bar pictures as
described here: http://forum.amule.org/thread.php?threadid=6217

Thanks!

Btw, can anyone tell me why the aMule ebuild requires >=wxGTK-2.6.0? 

Well, perhaps because the amule developers seriously recommend using that, and
because you will get only the answer "Upgrade to wxGTK 2.6" in their support
forums if you use wxGTK 2.4 ?

Well, that can't be true (OK, Kry might claim otherwise :P), we still 
officially support wxGTK-2.4.2 (I for one use it) and will be doing so until 
the 2.6 branch has become stable in quite a lot more distros than is currently 
the case. ;) 
 
The only case where we only support wxGTK-2.6 over wxGTK-2.4 is in the case of 
GTK2 support and when used on Windows or MacOSX.  

Oh, yeah, and if people are running wxGTK-2.5.3 or want to use amuled. ;) 

The ebuild proposed by Miguel Latorre Garc

The ebuild proposed by Miguel Latorre García (id=60652) is bugged because
there is no use flag  
gtk2-unicode in wxGTK-2.6.0 (just gtk2 and unicode).  

Furthermore if I try to compile amule with only USE="amuled remote" the ebuild
dies, here is the full  
output:  

router amule # USE="amuled remote" ACCEPT_KEYWORDS="~x86" emerge amule  

These are the packages that I would merge, in order:  

Calculating dependencies ...done!  
[ebuild  N    ] net-p2p/amule-2.0.2  -X +amuled -amuleremotegui -debug -gtk2
-nls +remote -stats  
-unicode 0 kB [1]  

Total size of downloads: 0 kB  
Portage overlays:  
 [1] /usr/local/portage  

Do you want me to merge these packages?[Yes/No] y  
 >>> emerge (1 of 1) net-p2p/amule-2.0.2 to /  
>>> md5 files   ;-) amule-2.0.2.ebuild  
>>> md5 files   ;-) files/amuleweb.initd  
>>> md5 files   ;-) files/amuled.confd  
>>> md5 files   ;-) files/amuled.initd  
>>> md5 files   ;-) files/digest-amule-2.0.2  
>>> md5 src_uri ;-) aMule-2.0.2.tar.bz2  
!!! set-wxconfig: Error:  Can't find normal or debug version:  
!!! set-wxconfig:         /usr/lib/wx/config/gtk-ansi-release-2.6 not found  
!!! set-wxconfig:         /usr/lib/wx/config/gtk-ansi-debug-2.6 not found  
!!! You need to emerge wxGTK with wxgtk1 in your USE  

It's trying to search for wxGTK compiled with gtk, but since I have no X, I
compiled wxGTK-2.6 with  
-gtk1 and -gtk2 so to build only wxbase.   
In the following HowTo http://www.amule.org/wiki/index.php/HowTo_Compile_aMuled
it's explained  
that I need only wxbase (or am I wrong?), so why does wxconfig search for gtk? 

aMule 2.0.3 is already out.

Created an attachment (id=61372) [edit]
amule 2.02 amuled unicode

This ebuild adds the patches for:

- gtk2-unicode was unicode
- amule standalone installation (use -wxgtk1 and -gtk2 to compile base wxgtk,
recommended in the new wxgtk-2.6.0-r1)
- progress bars bug

*** Bug 96348 has been marked as a duplicate of this bug. ***

Created an attachment (id=61767) [edit]
amule-2.0.3 with unicode support plus extra flags

amule-2.0.3 with unicode support plus additional and necessary(for me) flags.

This is their latest stable release!

Thanks for the ebuild. This latest amule 2.0.3 seems to work fine for me so  
far, but I didn't tested amuleweb or amuled.  
  
BTW, you should run repoman over the ebuild, there are several issues in the  
ebuild it complains about. If you want/hope that some gentoo dev adopts your 
ebuild it's surely a good advertisement if you can say "it's repoman 
clean". ;-) 
 

Created an attachment (id=61793) [edit]
amule 2.0.2

amule 2.0.2 repoman clean.
- Changes from 2.0.1 release:
* Added remotegui, wxgtk1 IUSE flags
* Fixed progressbars bug with the webserver
* amuled standalone installation with -wxgtk1 && -gtk2 (wxGTK-2.6.0-r1)

Created an attachment (id=61794) [edit]
amule 2.0.3

amule 2.0.3 repoman clean
Changes from amule 2.0.2:
* Added optimize nosistray IUSE flags

(In reply to comment #21)
> Thanks for the ebuild. This latest amule 2.0.3 seems to work fine for me so  
> far, but I didn't tested amuleweb or amuled.  
>   
> BTW, you should run repoman over the ebuild, there are several issues in the  
> ebuild it complains about. If you want/hope that some gentoo dev adopts your 
> ebuild it's surely a good advertisement if you can say "it's repoman 
> clean". ;-) 
>  

Hum... Sorry but how do I use repoman for that...
And yes I've the man page.

(In reply to comment #24)
> (In reply to comment #21)
> > Thanks for the ebuild. This latest amule 2.0.3 seems to work fine for me so  
> > far, but I didn't tested amuleweb or amuled.  
> >   
> > BTW, you should run repoman over the ebuild, there are several issues in the  
> > ebuild it complains about. If you want/hope that some gentoo dev adopts your 
> > ebuild it's surely a good advertisement if you can say "it's repoman 
> > clean". ;-) 
> >  
> 
> Hum... Sorry but how do I use repoman for that...
> And yes I've the man page.
> 

And yes I've seen the man page.

*** Bug 97759 has been marked as a duplicate of this bug. ***

I just renamed the ebuild to version 2.0.3 a few days ago and created digest
and
the new version is runing fine ever since. Is there some problem why it is not
updated in the portage for all the people.

I tried 61767 and 61794 ebuilds with -* +amuled +remote. 
Emerge fails:
amule-gui.cpp:281: error: parse error before `(' token
amule-gui.cpp:277: warning: unused parameter `wxString strText'
/usr/lib/gcc-lib/i586-pc-linux-gnu/3.3.5-20050130/include/g++-v3/bits/stl_multimap.h:
At top level:
StatisticsDlg.h:64: warning: `COLORREF getColors(int)' declared `static' but
never defined
{standard input}: Assembler messages:
{standard input}:210: Error: symbol `sm_eventHashTable' is already defined
{standard input}:236: Error: symbol `sm_eventHashTable' is already defined
{standard input}:244: Error: symbol `sm_eventHashTable' is already defined
{standard input}:270: Error: symbol `sm_eventHashTable' is already defined
{standard input}:306: Error: symbol `sm_eventHashTable' is already defined
{standard input}:354: Error: symbol `sm_eventHashTable' is already defined
{standard input}:356: Error: symbol `sm_eventHashTable' is already defined
make[3]: *** [amulegui-amule-gui.o] Error 1
make[3]: Leaving directory `/var/tmp/portage/amule-2.0.3/work/aMule-2.0.3/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/amule-2.0.3/work/aMule-2.0.3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/amule-2.0.3/work/aMule-2.0.3'
make: *** [all] Error 2

2.0.3 now in portage. Michael, I have added the missing initscripts, thanks for
that. I have not changed the ebuild, for the following reasons:
- old style if-statement magic is used, while use_enable is used in these ebuilds
- die-statements are used to die on USE-flag combinations <--- *BAD*
- the fact that some combinations are invalid suggest that these new USE-flags
need more thought

I would have rewritten the if-magic if not for the die-statements & the
combination issue. Please rethink your strategy, and open a new bug to get a
revised ebuild checked into the portage tree.