Bugzilla Bug 94731

As I explained in the kde bug above, pbbuttonsd changed its function for
starting the ipc.  With versions of pbbuttonsd >= 0.6.8, kdeutils fails when
compiling powerbook2.  The attached patch fixes the problem, but makes kdeutils
dependent on pbbuttonsd >= 0.6.8.

If you need more details, please let me know.

Created an attachment (id=60357) [edit]
This patch applies cleanly to 3.4.0 and 3.4.1

Moreover I wonder why kdeutils is marked ppc, but the dependency is missing at
all. The kde herd is small and x86/amd64 only, we rely on you spotting such
minor missing dependencies.

When will pbbuttonsd 0.6.8 go stable?

s/marked ppc/keyworded ppc

It's not a hard dependency.  If pbbuttonsd isn't present, it doesn't build the
powerbook libraries.  At least that's what it looks like from the config files
and this would explain the lack of bug reports on it.  So, it's perfectly
understandable that ppc missed it as a dependency as well.  Only portable Apple
laptops use this package, and kdeutils builds fine without pbbuttonsd, just
without powerbook support.  Non-laptop ppc machines should not depend on
pbbuttonsd, so we probably need a use flag for it.

I don't think that pbbuttonsd-0.6.8 will go stable soon, as we're working on a
crash bug with versions 0.6.8 - 0.6.10 and I'm not sure when this will be
resolved.  I created this bug as an FYI, this is a problem, here is the fix.

> It's not a hard dependency.

So it needs to become one, optionalised by a use flag. Untracked depedencies are
the worst next to boken autodetection code in build scripts, overriding
configure flags. Joe, we really need to track _all_ dependencies of _all_
ebuilds in a determinist way, otherwise we'll never see a Portage version with
proper reverse dependency tracking.

Look, I'm not arguing with you, no need to get all worked up.  I don't use KDE.
 A user pointed out the problem and we're fixing it.  I suggested that we use a
USE flag in my previous post, I'm *agreeing* with you.

O.k., o.k. ;) Is a "powerbook" use flag fine then? Or does it work with iBooks,
too and e.g. "apple-laptop" would be more appropriate?


for reference: https://bugs.kde.org/show_bug.cgi?id=104517

Well, I'd probably use "pbbuttonsd" as there is still support for pmu (Apple's
version of apm) without pbbuttonsd.  pbbuttonsd support allows the use of the
special buttons, such as volume and sound.  The powerbook2 module provides
visual feedback to the user when these buttons are pressed in KDE.

pbbuttonsd should be good, as ibooks users usually use that, too. 

*** Bug 97802 has been marked as a duplicate of this bug. ***

FYI the upstream patch has support for all versions of pbbuttonsd.  If we
include this patch instead and add the pbbuttonsd useflag we can close this bug now.

Created an attachment (id=62553) [edit]
Updated patch

We can. But I don't like to name the use flag "pbbuttonsd". Imho use flags
should be as abstract as possible, so they can be reused. We have already too
much crappy named and even redundant use flags, making Portage far more complex
than necessary. 

Fear the bloated Gentoo! It won't be the most speedy penguin anymore. :)

Well, what do you suggest then?  I don't want to make it conditional on ppc
since non laptop users don't need pbbuttonsd at all.  We can't use
powerbook/ibook because both use pbbuttonsd.  If there was an existing laptop
use flag, I would suggest use ppc && use laptop but since there isn't, it would
be just as wasteful to add one.

Carsten, would you like me to just apply the patch myself?

At this point we can just wait a couple of days for kde 3.4.2, which includes 
the patch for pb_monitor.cpp and will be also patched to have a 
--with-powerbook/--without-powerbook switch. Then you can add there the 
optional dependency on pbbuttonsd with a USE flag to be decided. 
 

kde 3.4.2 is in portage now, feel free to add an USE flag and a dependency on   
pbbuttonsd to kde-base/kdeutils and kde-base/kmilo. 

Fixed in CVS, thanks!