Bugzilla Bug 94293

Graveman updated 0.3.12 package fixes some bugs like a segfault when trying to
burn cd/dvd's.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Created an attachment (id=60016) [edit]
Ebuild for newest version.

0.3.12_p3 committet. Thanks Frank!

Thank you :)

Graveman 0.3.12.4 is out
************************

30-05-2005 - 0.3.12.4

    * Fixed bug #13018, "burn DVD-RW"
    * Fixed bug #13220, "burn DVD-RW 2" patch from Stephan S. <white>
    * Minor interface improvement


PS: Graveman developers rocks :) "they" are too fast, update very often ;)
PPS: Scuse me if I posted it here, I thinked it's better (that's a minor minor
revision), or not?

0.3.12_p4 committet ...

Created an attachment (id=72509) [edit]
app-cdr/graveman-0.3.12_p4-r2

Removed the sox USE flag and made the sox package depend on the presence of
either the mp3 or oggvorbis USE glags.

Please avoid having interdependent USE flags (requierment of having a USE flag
be present when another is specified).	It's ugly, and it interrupts emerges
(ie: emerge world).

The following DEPEND construct has the exact same effect:

DEPEND=">=x11-libs/gtk+-2.4
    >=dev-libs/glib-2.4
    >=gnome-base/libglade-2.4
    >=dev-util/intltool-0.22
    flac? ( >=media-libs/flac-1.1.0 )
    nls? ( sys-devel/gettext )
    mp3? ( >=media-libs/libid3tag-0.15
	>=media-libs/libmad-0.15
	>=media-sound/sox-12.17.0 )
    oggvorbis? ( >=media-libs/libogg-1.0
	>=media-libs/libvorbis-1.0
	>=media-sound/sox-12.17.0 )"
RDEPEND="${DEPEND}
    >=app-cdr/cdrtools-2.0
    >=app-cdr/cdrdao-1.1.9
    media-libs/libmng
    dvdr? ( >=app-cdr/dvd+rw-tools-5.20 )"

On my box:

[code]

# USE="-* -mp3 -oggvorbis" emerge -pv graveman

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] app-cdr/graveman-0.3.12_p4-r2  -debug -dvdr -flac -mp3 -nls
-oggvorbis 0 kB

Total size of downloads: 0 kB

# USE="-* mp3 oggvorbis" emerge -pv graveman

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] media-sound/sox-12.17.7-r1  -alsa -encode -mad -ogg 455 kB
[ebuild  N    ] app-cdr/graveman-0.3.12_p4-r2  -debug -dvdr -flac +mp3 -nls
+oggvorbis 0 kB

Total size of downloads: 455 kB

[/code]

Finally, I'm not a guru of audio/video in Linux yet, but I find the oggvorbis
and vorbis USE flags confusing.  I think this should be cleared up at a higher
level, but shouldn't oggvorbi be ogg+vorbis?  We don't see mp3divx or ac52dvd,
do we?	 ;)

I know they are a pair, but if you take a look at many other ebuilds that use
them, they often will treat them distinctly.  My point is that the ogg USE flag
does not transcend to the sox ebuild when the dependency is specified because
gravman uses oggvorbis... that's all.

(In reply to comment #6)
> Finally, I'm not a guru of audio/video in Linux yet, but I find the oggvorbis
> and vorbis USE flags confusing.  I think this should be cleared up at a higher
> level, but shouldn't oggvorbi be ogg+vorbis?  We don't see mp3divx or ac52dvd,
> do we?	 ;)
> 
> I know they are a pair, but if you take a look at many other ebuilds that use
> them, they often will treat them distinctly.  My point is that the ogg USE flag
> does not transcend to the sox ebuild when the dependency is specified because
> gravman uses oggvorbis... that's all.

Stumbled on this :p #94254

I finally moved the oggvorbis USE to vorbis. I also removed the sox USE flag
and
put sox into RDEPEND if the mp3 or vorbis USE flags are activated.

Bel: sox is a runtime dependency, so it should be added to RDEPEND instead of
DEPEND. From my point of view a revision bump isn't necessary, as this changes
have no impact on users currently runnin graveman.

On a side note: I would much prefer new bug reports instead of reviving old and
resolved bug reports. Thanks Bel!

(In reply to comment #8)
> I finally moved the oggvorbis USE to vorbis. I also removed the sox USE flag and
> put sox into RDEPEND if the mp3 or vorbis USE flags are activated.

And where are these changes reflected?  

(In reply to comment #8)
> Bel: sox is a runtime dependency, so it should be added to RDEPEND instead of
> DEPEND. From my point of view a revision bump isn't necessary, as this changes
> have no impact on users currently runnin graveman.

The change will have an impact on those who don't have graveman though.

For the DEPEND/RDEPEND, I guess I should have added the USE flags in the RDEPEND
then. ;)