First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 93658
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Steev Klimaszewski <steev@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Patrik Karlsson <patrik@cqure.net>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
thinkpad-5.8-cpu_ptr.patch thinkpad-5.8-cpu_ptr.patch patch Tobias Sager 2006-01-23 09:25 0000 723 bytes Details | Diff
thinkpad-5.8-pm_legacy.patch thinkpad-5.8-pm_legacy.patch patch Tobias Sager 2006-01-23 09:25 0000 389 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 93658 depends on: Show dependency tree
Show dependency graph
Bug 93658 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-05-23 03:06 0000 
The thinkpad-5.8 application does not compile with kernels
linux-2.6.11-gentoo-r*.
The following patch solves the problem;
https://www.redhat.com/archives/fedora-extras-commits/2005-April/msg00060.html

--- 2.6/drivers/thinkpadpm.c~   2004-09-19 12:32:57.000000000 +0300
+++ 2.6/drivers/thinkpadpm.c    2005-01-08 01:18:48.000000000 +0200
@@ -169,11 +169,11 @@

 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,9)
 #define get_gdt_table()        (cpu_gdt_table[get_cpu()])
-#define put_gdt_table()        put_cpu()
 #else
-#define get_gdt_table()        (get_cpu_ptr(cpu_gdt_table))
-#define put_gdt_table()        put_cpu_ptr(cpu_gdt_table)
+#include <linux/percpu.h>
+#define get_gdt_table()        (per_cpu(cpu_gdt_table, get_cpu()))
 #endif
+#define put_gdt_table()        put_cpu()

 /**
  *     apm_bios_call   -       Make an APM BIOS 32bit call




Reproducible: Always
Steps to Reproduce:
1. echo "app-laptop/thinkpad ~x86" >> /etc/portage/package.keywords
2. emerge thinkpad


Actual Results:  
compilation failure

------- Comment #1 From Henrik Brix Andersen 2005-06-25 07:25:00 0000 ------- 
*** Bug 96806 has been marked as a duplicate of this bug. ***

------- Comment #2 From Jonathan Smith 2005-07-13 12:34:59 0000 ------- 
works for me on vanilla-sources-2.6.13_rc3 and gentoo-sources-2.6.12-r5.
perhaps
you should try one of those?

------- Comment #3 From emory stuart taylor 2005-11-21 01:37:39 0000 ------- 
thinkpad doesn't work for me and doesn't work for anyone else i've talked to
gentoo-sources-2.6.14~.  i can't confirm yet if this patch alone makes it work,
but hopefully this will be looked at more closely please. i'll try to get back
with more info

------- Comment #4 From Tobias Sager 2006-01-23 09:25:08 0000 ------- 
Created an attachment (id=77917) [edit]
thinkpad-5.8-cpu_ptr.patch

Patch with the changes from comment 0.

------- Comment #5 From Tobias Sager 2006-01-23 09:25:35 0000 ------- 
Created an attachment (id=77918) [edit]
thinkpad-5.8-pm_legacy.patch

This patch was needed due to changes since 2.6.15.

------- Comment #6 From Chris Bainbridge (RETIRED) 2006-02-01 07:37:41 0000 ------- 
I can confirm that thinkpad fails to build on 2.6.15. Assigning to maintainer.

------- Comment #7 From Steev Klimaszewski 2006-02-18 05:17:46 0000 ------- 
Upstream has released a new version, 5.9 which I have put into the tree, works
here, please reopen if you continue to have any issues.  If I don't hear of any
issues, will push for this to be stable next week.  It is currently marked
~x86.
First Last Prev Next    No search results available      Search page      Enter new bug