First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 92586
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo/BSD Team <bsd@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Diego Pettenò <flameeyes@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
grep-2.5.1-r7.patch Ebuild patch patch Diego Pettenò 2005-05-14 06:02 0000 1.86 KB Details | Diff
grep-2.5.1-restrict_arr.patch grep-2.5.1-restrict_arr.patch patch Diego Pettenò 2005-05-14 06:03 0000 1.04 KB Details | Diff
grep-2.5.1-libintl.patch grep-2.5.1-libintl.patch patch Diego Pettenò 2005-05-14 06:03 0000 1.11 KB Details | Diff
f grep-2.5.1-libintl.patch patch SpanKY 2005-06-12 15:22 0000 2.49 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 92586 depends on: Show dependency tree
Show dependency graph
Bug 92586 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-05-14 06:02 0000 
Attached you can find an updated restrict_arr patch which instead of just
whitelisting sun, it adds a configure check for features.h file. See bug #80287
to see why that whitelisting was added.

There's also a patch which adds a check for libintl which is needed to complete
the linking on systems where libintl is not included in libc.

Finally, the patch for the ebuild adds the two patches, adds an autogen script,
and as I was there, I've removed uclibc useflag and used elibc_uclibc to
achieve the same thing.

Thanks, Diego

------- Comment #1 From Diego Pettenò 2005-05-14 06:02:46 0000 ------- 
Created an attachment (id=58864) [edit]
Ebuild patch

------- Comment #2 From Diego Pettenò 2005-05-14 06:03:29 0000 ------- 
Created an attachment (id=58865) [edit]
grep-2.5.1-restrict_arr.patch

------- Comment #3 From Diego Pettenò 2005-05-14 06:03:46 0000 ------- 
Created an attachment (id=58866) [edit]
grep-2.5.1-libintl.patch

------- Comment #4 From SpanKY 2005-05-14 10:47:37 0000 ------- 
are you going to send these fixes upstream ?

------- Comment #5 From Diego Pettenò 2005-05-14 18:50:44 0000 ------- 
Not sure about restrict_arr because I don't started with it, I just fixed it to
work on G/fbsd...

About libintl, I think I'll try in the next days.

------- Comment #6 From SpanKY 2005-05-15 12:54:24 0000 ------- 
i meant the features.h part of the restrict_arr patch ... the other part with
the uclibc define we'll just keep in Gentoo

------- Comment #7 From Diego Pettenò 2005-05-16 04:08:21 0000 ------- 
The features.h part is not in plain grep, it was on a gentoo patch...

------- Comment #8 From SpanKY 2005-06-12 15:22:10 0000 ------- 
Created an attachment (id=61125) [edit]
grep-2.5.1-libintl.patch

please try this patch

------- Comment #9 From SpanKY 2005-06-12 15:23:38 0000 ------- 
(From update of attachment 58865 [edit])
i updated the patch to simply undefine __restrict_arr and then define it again
as null ... don't need to include features.h in this case

------- Comment #10 From Diego Pettenò 2005-06-13 03:03:10 0000 ------- 
It re-creates configure after the patch but seems to work fine anyway.

------- Comment #11 From SpanKY 2005-06-13 04:55:21 0000 ------- 
so drop the configure.in hunk of the patch and try again

------- Comment #12 From Diego Pettenò 2005-06-13 05:03:02 0000 ------- 
Works, but that's not good anyway because it will have problems if in the 
future configure is regenerated for other patches.

------- Comment #13 From SpanKY 2005-06-13 16:17:05 0000 ------- 
added to 2.5.1-r8
First Last Prev Next    No search results available      Search page      Enter new bug