First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 91977
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo's Team for Core System packages <base-system@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Nathaniel McCallum (RETIRED) <npmccallum@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
eject-2.0.13-closefd.patch make sure fd's are closed correctly patch Nathaniel McCallum (RETIRED) 2005-05-08 23:37 0000 1.45 KB Details | Diff
eject-2.0.13-defaultdevice-fix.patch make sure DEFAULTDEVICE starts with "/dev/" patch Nathaniel McCallum (RETIRED) 2005-05-08 23:38 0000 824 bytes Details | Diff
eject-2.0.13-finddev2.patch new version of finddev (includes documentation) patch Nathaniel McCallum (RETIRED) 2005-05-08 23:38 0000 2.14 KB Details | Diff
eject-2.0.13-fstabreadfix.patch make sure we can read fstab patch Nathaniel McCallum (RETIRED) 2005-05-08 23:38 0000 1.00 KB Details | Diff
eject-2.0.13-mallocfix.patch check the return value of malloc for NULL patch Nathaniel McCallum (RETIRED) 2005-05-08 23:39 0000 466 bytes Details | Diff
eject-2.0.13-no_unmount.patch adds a don't unmount option patch Nathaniel McCallum (RETIRED) 2005-05-08 23:39 0000 2.65 KB Details | Diff
eject-2.0.13-pumount.patch adds pumount support (project utopia) patch Nathaniel McCallum (RETIRED) 2005-05-08 23:40 0000 940 bytes Details | Diff
eject-2.0.13-regexfix.patch make sure we have a proper regex patch Nathaniel McCallum (RETIRED) 2005-05-08 23:40 0000 437 bytes Details | Diff
eject-2.0.13-r2.ebuild new ebuild text/plain Nathaniel McCallum (RETIRED) 2005-05-08 23:41 0000 1.34 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 91977 depends on: Show dependency tree
Show dependency graph
Bug 91977 blocks: 91928
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-05-08 23:35 0000 
New version of eject including a bunch of patches from ubuntu, including:
   - a new version of the finddev patch (adds documentation)
   - pumount support (for Utopia; blocks #91928) 
   - several fixes for remote situations
   - check malloc return value for NULL

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Nathaniel McCallum (RETIRED) 2005-05-08 23:37:28 0000 ------- 
Created an attachment (id=58442) [edit]
make sure fd's are closed correctly

------- Comment #2 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:04 0000 ------- 
Created an attachment (id=58443) [edit]
make sure DEFAULTDEVICE starts with "/dev/"

------- Comment #3 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:34 0000 ------- 
Created an attachment (id=58444) [edit]
new version of finddev (includes documentation)

------- Comment #4 From Nathaniel McCallum (RETIRED) 2005-05-08 23:38:57 0000 ------- 
Created an attachment (id=58445) [edit]
make sure we can read fstab

------- Comment #5 From Nathaniel McCallum (RETIRED) 2005-05-08 23:39:29 0000 ------- 
Created an attachment (id=58446) [edit]
check the return value of malloc for NULL

------- Comment #6 From Nathaniel McCallum (RETIRED) 2005-05-08 23:39:58 0000 ------- 
Created an attachment (id=58447) [edit]
adds a don't unmount option

------- Comment #7 From Nathaniel McCallum (RETIRED) 2005-05-08 23:40:27 0000 ------- 
Created an attachment (id=58448) [edit]
adds pumount support (project utopia)

------- Comment #8 From Nathaniel McCallum (RETIRED) 2005-05-08 23:40:57 0000 ------- 
Created an attachment (id=58449) [edit]
make sure we have a proper regex

------- Comment #9 From Nathaniel McCallum (RETIRED) 2005-05-08 23:41:42 0000 ------- 
Created an attachment (id=58450) [edit]
new ebuild

------- Comment #10 From Jakub Moc 2005-05-08 23:55:25 0000 ------- 
Would you like to have a look at Bug 62612 as well? :-)

------- Comment #11 From Nathaniel McCallum (RETIRED) 2005-05-09 00:08:18 0000 ------- 
sure, you can assign it to me if you like, but I'd like to put it in a revision
on its own to get more testing.  All the patches I've put here are fairly well
tested.

------- Comment #12 From SpanKY 2005-05-09 00:17:44 0000 ------- 
fedora has a patch or two not included here ...

------- Comment #13 From Jakub Moc 2005-05-09 00:51:47 0000 ------- 
Comment #11: As you wish, assigned #62612 to you. If you

------- Comment #14 From Jakub Moc 2005-05-09 00:51:47 0000 ------- 
Comment #11: As you wish, assigned #62612 to you. If you´d like to maintain
this ebuild, then you could add yourself to metadata.xml.

------- Comment #15 From SpanKY 2005-05-20 20:30:55 0000 ------- 
some notes ...

- the close patch is pretty stupid/pointless
- the malloc check is incomplete ... it's not the only malloc in eject.c
- the regcomp check is incomplete ... it's not the only regcomp in eject.c
- what's the point of the pumount patch ?

added all but the pumount patch to eject-2.0.13-r2 after cleaning many of them up

------- Comment #16 From Nathaniel McCallum (RETIRED) 2005-05-20 20:38:22 0000 ------- 
pmount (and pumount) are policy wrappers around mount for removeable devices
that aren't in fstab.  Desktop programs use eject (ie. gnome-vfs).  Lets say in
this case you plug in a usb zip drive.  gnome-vfs uses pmount to mount it, then
the user wants to eject it.  The user chooses eject in nautilus, which (through
gnome-vfs) calls eject.  When eject tries to umount the device, it will fail, so
eject will be broken.  The pumount tries at runtime to run pumount before
umount.  Nothing breaks if pumount isn't installed or fails (we don't check the
exit status).

------- Comment #17 From SpanKY 2005-05-20 22:58:44 0000 ------- 
added to 2.0.13-r2
First Last Prev Next    No search results available      Search page      Enter new bug