Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91696 - kfiresaver is not built in kdeartwork-3.4.0
Summary: kfiresaver is not built in kdeartwork-3.4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-06 07:37 UTC by Thomas Loeber
Modified: 2005-05-31 16:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Loeber 2005-05-06 07:37:28 UTC
kfiresaver.kss is not build when emerging kdeartwork-3.4.0.

In my opinion this is caused by a wrong condition in kscreensaver/configure.in.in:

Instead of
AM_CONDITIONAL(COMPILE_ARTS_KSAVERS, test x$have_arts = xyes)
it should be
AM_CONDITIONAL(COMPILE_ARTS_KSAVERS, test x$build_arts = xyes)

As a workaround I added a sed command in function src_unpack of my kdeartwork-3.4.0.ebuild as follows:

src_unpack() {
        kde_src_unpack

        # Fix compilation with --without-gl. See bug #46775 and kde bug 89387.
        epatch ${FILESDIR}/kdeartwork-3.4.0-gl-kdesavers.patch

        # Use correct variable to check for arts: $have_arts -> $build_arts
        sed -i "s/\$have_arts/\$build_arts/g" ${S}/kscreensaver/configure.in.in || die

        make -f admin/Makefile.common
}

Now kfiresaver.kss is built when emerging kdeartwork.

Reproducible: Always
Steps to Reproduce:
1. emerge kdeartwork
2.
3.

Actual Results:  
The kdeartwork emerge finishes successfully but /usr/kde/3.4/bin/kfiresaver.kss
is missing.

Expected Results:  
/usr/kde/3.4/bin/kfiresaver.kss should be built and installed by kdeartwork.

Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130,
glibc-2.3.4.20041102-r1, 2.6.11-gentoo-r6 i686)
=================================================================
System uname: 2.6.11-gentoo-r6 i686 AMD Athlon(tm) XP 2600+
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Apr 29 2005, 19:34:39)]
dev-lang/python:     2.3.5
sys-apps/sandbox:    [Not Present]
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.8.5-r3, 1.7.9-r1, 1.9.5, 1.5, 1.4_p6, 1.6.3
sys-devel/binutils:  2.15.92.0.2-r7
sys-devel/libtool:   1.5.16
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env
/usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://pandemonium.tiscali.de/pub/gentoo/
ftp://gd.tuwien.ac.at/opsys/linux/gentoo/
ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/"
LANG="de_DE@euro"
LINGUAS="de nl"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/etc/portage/overlay"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 3dnow X acl acpi alsa apache2 apm arts audiofile avi bash-completion
berkdb bitmap-fonts bluetooth cdr crypt cups curl doc dvd dvdr emboss encode
ffmpeg foomaticdb gd gdbm gif gtk gtk2 imagemagick imlib java jikes jpeg junit
kde kdeenablefinal ldap libg++ libwww lm_sensors mad mmx mozilla mp3 mpeg
ncurses nls nptl ogg oggvorbis opengl pam pda pdflib perl pic png ppds python qt
quicktime readline sdl slang spell sse ssl symlink tcltk tetex theora threads
tidy tiff truetype truetype-fonts type1-fonts v4l vcd vorbis win32codecs xine
xml xml2 xmms xv xvid zlib video_cards_radeon linguas_de linguas_nl userland_GNU
kernel_linux elibc_glibc"
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS
Comment 1 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-08 03:17:52 UTC
You're right, kscreensaver/configure.in.in is incorrect. Could you send a patch to http://bugs.kde.org so that it can be included in kde 3.4.1, which will be out really soon?
Comment 2 Thomas Loeber 2005-05-09 12:33:17 UTC
Sorry for not answering here directly after I found and voted for KDE bug 102398 http://bugs.kde.org/show_bug.cgi?id=102398
So hopefully the fix will be committed soon to KDE.
Comment 3 Caleb Tennis (RETIRED) gentoo-dev 2005-05-24 05:59:00 UTC
FWIW, I was the one who added that check into upstream KDE - before it would 
attempt to build regardless of whether you had arts or not (and crash out if 
you didn't). 
Comment 4 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-31 16:15:06 UTC
The patch is not applied upstream yet, but it's included in the ebuilds for  
kdeartwork-3.4.1/kdeartwork-screensaver-3.4.1. Closing.