Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91644 - app-office/magicpoint links against libmng, without dep or USE flag.
Summary: app-office/magicpoint links against libmng, without dep or USE flag.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mamoru KOMACHI (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-05 20:11 UTC by James Rowe
Modified: 2005-05-06 19:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
magicpoint-1.11b-mng_optional.patch (magicpoint-1.11b-mng_optional.patch,1.63 KB, patch)
2005-05-05 20:12 UTC, James Rowe
Details | Diff
magicpoint-1.11b-mng_optional_ebuild.patch (magicpoint-1.11b-mng_optional_ebuild.patch,1.29 KB, patch)
2005-05-05 20:13 UTC, James Rowe
Details | Diff
magicpoint-1.11b-fix_head_call.patch (magicpoint-1.11b-fix_head_call.patch,813 bytes, patch)
2005-05-05 20:15 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-05-05 20:11:25 UTC
app-office/magicpoint links against libmng if it is installed, however it
isn't a listed dep and it doesn't honour the global USE flag either.  The
attached patch magicpoint-1.11b-mng_optional.patch changes the behaviour of
configure to only test, and therefore link, against libmng if --enable-mng
is provided on the command line.  The second attachment,
magicpoint-1.11b-mng_optional_ebuild.patch, updates the ebuild to make
MNG support optional dependent on the global mng USE flag.

  The second patch moves the bug #85720 fix in to src_unpack aswell, purely
because the optional MNG support requires the execution of autoconf to
update configure.in anyway so one might as well operate on only the
configure.in file for #85720 fix.

  In the course of looking at this bug I also had to endure the ugliness of
the head call warnings, so there is a third attachment to use the
fixheadtails eclass to fix this.  Once again it is only called prior to
autoconf's execution instead of changing generated files too.  Obviously
with current coreutils it is only cosmetic.

  One other minor issue appeared to me while looking at the magicpoint
ebuild, and that is the content of
${FILESDIR}/magicpoint-1.10a-r1-gentoo.diff.  Shouldn't the canonical
location of truetype fonts now be /usr/share/fonts and not a location in
/usr/X11R6?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-05-05 20:12:36 UTC
Created attachment 58172 [details, diff]
magicpoint-1.11b-mng_optional.patch
Comment 2 James Rowe 2005-05-05 20:13:57 UTC
Created attachment 58173 [details, diff]
magicpoint-1.11b-mng_optional_ebuild.patch

ebuild changes necessary to support the optional MNG linking
Comment 3 James Rowe 2005-05-05 20:15:10 UTC
Created attachment 58174 [details, diff]
magicpoint-1.11b-fix_head_call.patch
Comment 4 Mamoru KOMACHI (RETIRED) gentoo-dev 2005-05-05 21:35:18 UTC
Thanks for the patches. I committed them to CVS.
As for magicpoint-1.10a-r1-gentoo.diff, magicpoint w/ freetype
only searchs the directory (not looking into its subdirectories),
so there's no point changing it to /usr/share/fonts. Anyways,
magicpoint ebuilds do not enable freetype support atm
(they used to, though), so it doesn't do anything in reality.
Comment 5 James Rowe 2005-05-06 19:51:14 UTC
  Thanks for info, it has cleared up my confusion about the fonts directory.  I
wasn't really all that sure what it was supposed to be doing that is why I
raised the issue as a sidenote, it just looked wrong ;)