First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 91644
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Mamoru KOMACHI (RETIRED) <usata@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: James Rowe <jnrowe@ukfsn.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
magicpoint-1.11b-mng_optional.patch magicpoint-1.11b-mng_optional.patch patch James Rowe 2005-05-05 20:12 0000 1.63 KB Details | Diff
magicpoint-1.11b-mng_optional_ebuild.patch magicpoint-1.11b-mng_optional_ebuild.patch patch James Rowe 2005-05-05 20:13 0000 1.29 KB Details | Diff
magicpoint-1.11b-fix_head_call.patch magicpoint-1.11b-fix_head_call.patch patch James Rowe 2005-05-05 20:15 0000 813 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 91644 depends on: Show dependency tree
Show dependency graph
Bug 91644 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-05-05 20:11 0000
app-office/magicpoint links against libmng if it is installed, however it
isn't a listed dep and it doesn't honour the global USE flag either.  The
attached patch magicpoint-1.11b-mng_optional.patch changes the behaviour of
configure to only test, and therefore link, against libmng if --enable-mng
is provided on the command line.  The second attachment,
magicpoint-1.11b-mng_optional_ebuild.patch, updates the ebuild to make
MNG support optional dependent on the global mng USE flag.

  The second patch moves the bug #85720 fix in to src_unpack aswell, purely
because the optional MNG support requires the execution of autoconf to
update configure.in anyway so one might as well operate on only the
configure.in file for #85720 fix.

  In the course of looking at this bug I also had to endure the ugliness of
the head call warnings, so there is a third attachment to use the
fixheadtails eclass to fix this.  Once again it is only called prior to
autoconf's execution instead of changing generated files too.  Obviously
with current coreutils it is only cosmetic.

  One other minor issue appeared to me while looking at the magicpoint
ebuild, and that is the content of
${FILESDIR}/magicpoint-1.10a-r1-gentoo.diff.  Shouldn't the canonical
location of truetype fonts now be /usr/share/fonts and not a location in
/usr/X11R6?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

------- Comment #1 From James Rowe 2005-05-05 20:12:36 0000 -------
Created an attachment (id=58172) [edit]
magicpoint-1.11b-mng_optional.patch

------- Comment #2 From James Rowe 2005-05-05 20:13:57 0000 -------
Created an attachment (id=58173) [edit]
magicpoint-1.11b-mng_optional_ebuild.patch

ebuild changes necessary to support the optional MNG linking

------- Comment #3 From James Rowe 2005-05-05 20:15:10 0000 -------
Created an attachment (id=58174) [edit]
magicpoint-1.11b-fix_head_call.patch

------- Comment #4 From Mamoru KOMACHI (RETIRED) 2005-05-05 21:35:18 0000 -------
Thanks for the patches. I committed them to CVS.
As for magicpoint-1.10a-r1-gentoo.diff, magicpoint w/ freetype
only searchs the directory (not looking into its subdirectories),
so there's no point changing it to /usr/share/fonts. Anyways,
magicpoint ebuilds do not enable freetype support atm
(they used to, though), so it doesn't do anything in reality.

------- Comment #5 From James Rowe 2005-05-06 19:51:14 0000 -------
  Thanks for info, it has cleared up my confusion about the fonts directory.  I
wasn't really all that sure what it was supposed to be doing that is why I
raised the issue as a sidenote, it just looked wrong ;)

First Last Prev Next    No search results available      Search page      Enter new bug