First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 91423
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Nathan Toone <nathan@toonetown.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
kdenetwork-3.4.0-kopete-tabbed-windows.patch kdenetwork-3.4.0-kopete-tabbed-windows.patch patch Nathan Toone 2005-05-11 09:23 0000 1.00 KB Details | Diff
kopete-3.4.0-r1.ebuild kopete-3.4.0-r1.ebuild text/plain Nathan Toone 2005-05-11 09:23 0000 807 bytes Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 91423 depends on: Show dependency tree
Bug 91423 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-05-04 06:14 0000
Kopete crashes when trying to open a chat with a contact after you have already
closed the chat window.  It appears that it is removing something from memory
that shouldn't be removed.

Reproducible: Always
Steps to Reproduce:
1. Run kopete
2. Open a chat window with a contact
3. Close the tab for that contact (ctrl-w)
4. Open a chat window with any other contact

Actual Results:  
CRASH!  

If in step 3, you close the window (using Alt-F4 or the close button) instead
of closing 
the tab, the crash will not happen. 

Expected Results:  
no crash.  



I have logged this bug with KDE - at http://bugs.kde.org/showbug.cgi? ,
however, it     
appears to me to be an issue with the Gentoo build of kopete.  I was not able
to     
reproduce it using kde 3.4 on SuSE, or if i compiled it myself.  Also - I am
using the     
split ebuild for kopete - not kdenetwork.    

 kopete is compiled with USE= -arts -debug +kdeenablefinal +kdexdeltas +ssl 
+xinerama 

(so no, I don't have a valid stack trace...sorry. :( )

------- Comment #1 From Nathan Toone 2005-05-04 06:17:19 0000 -------
Sorry - I meant to look up the bug number for the KDE bug, but I sent before I
did it...

It's http://bugs.kde.org/show_bug.cgi?id=101008

------- Comment #2 From Gregorio Guidi (RETIRED) 2005-05-10 09:40:54 0000 -------
The main suspect here is kdenetwork-3.4.0-kopete-logout.patch, for
http://bugs.kde.org/show_bug.cgi?id=91288.

If you can confirm that it is the culprit, please inform kde developers,
because that patch will be in kde-3.4.1.

------- Comment #3 From Nathan Toone 2005-05-10 10:43:38 0000 -------
I can confirm this - removing the patch for kopete-logout fixed the issue 100%.

The change (removal of this patch) should probably be made in portage until a new patch which works can be put in.

------- Comment #4 From Gregorio Guidi (RETIRED) 2005-05-10 12:42:25 0000 -------
> The change (removal of this patch) should probably be made in portage until a new patch which works can be put in.

This would exchange a crash for another one... we can only wait for a proper
fix from the kde side, I guess.

------- Comment #5 From Nathan Toone 2005-05-10 12:46:30 0000 -------
My arguments for removing the patch:  (take them as you will...)

1 - the version of kde that we are running is 3.4.0 - so if we have a crash that is known in 3.4.0, it's not a big deal (that is, most other distros have the 3.4.0 crash)

2 - the crash that the patch fixes only happens on KDE shutdown - the crash that the patch creates happens multiple times *DURING* normal use of kopete.

Again - take them as you will...I can always just keep my own copy of the ebuild in my overlay directory...it just seems to make more sense (to me, anyway) to remove it from portage as well.

------- Comment #6 From Nathan Toone 2005-05-11 09:22:37 0000 -------
And then there's the even better option!

How about fix the bug???  :)

This bug (the tabbed window crash) is logged as kde bug 105442.  There is a patch for it at http://lists.kde.org/?l=kde-cvs&m=111115078602663&w=2

I have modified my ebuild to include this patch - I will post both the ebuild and the patch.  One thing to note - this patch needs to be applied *after* the first patch (the logout patch) since it's that patch that causes this bug.  Another option would be to modify the logout patch to include the fixes in the tabbed-windows patch.  (as you can see in the tabbed-windows patch, the problem is a block that is commented out that should not be.)

This fixes both problems - the logout crash and the tabbed windows crash.

Can we include THIS in portage?

------- Comment #7 From Nathan Toone 2005-05-11 09:23:22 0000 -------
Created an attachment (id=58671) [edit]
kdenetwork-3.4.0-kopete-tabbed-windows.patch

Patch to fix crash

------- Comment #8 From Nathan Toone 2005-05-11 09:23:49 0000 -------
Created an attachment (id=58672) [edit]
kopete-3.4.0-r1.ebuild

My ebuild with the patch integrated

------- Comment #9 From Gregorio Guidi (RETIRED) 2005-05-11 12:40:11 0000 -------
Surely this is the best solution :)

Committed as kdenetwork-3.4.0-r2/kopete-3.4.0-r2

------- Comment #10 From Nathan Toone 2005-05-11 12:44:34 0000 -------
I don't know (because I don't run it), but the kdenetwork package may suffer
from the same problem if it also uses the same logout patch (which it appears
it does...)

------- Comment #11 From Nathan Toone 2005-05-11 12:46:00 0000 -------
>Committed as kdenetwork-3.4.0-r2/kopete-3.4.0-r2

OK - so I need to read more carefully... :0

First Last Prev Next    No search results available      Search page      Enter new bug