Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91343 - /etc/init.d/shorewall should use "save" and "restore" functionality for faster startup
Summary: /etc/init.d/shorewall should use "save" and "restore" functionality for faste...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-03 12:40 UTC by Christopher DeMarco
Modified: 2006-02-18 18:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to implement proposed functionality (shorewall_restore.patch,608 bytes, patch)
2005-05-05 06:12 UTC, Christopher DeMarco
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher DeMarco 2005-05-03 12:40:23 UTC
The initscript should use "shorewall -f start", which if state has been saved ("shorewall save") is faster than without the -f switch, and if no state has been saved, is exactly the same as without.

The initscript should also look for a saved statefile and if found use "shorewall restore" instead of "restart".

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




I'm willing to submit a patch to the initscript, or even a patch to the ebuild
if the package maintainer can point me in the right direction for the procedure.
Comment 1 Daniel Black (RETIRED) gentoo-dev 2005-05-05 02:34:49 UTC
can you please make a patch for us?
Comment 2 Christopher DeMarco 2005-05-05 06:12:29 UTC
Created attachment 58138 [details, diff]
Patch to implement proposed functionality

A simple patch.  Note that the user has to save a shorewall config using
"shorewall save" in order to benefit from the patch.
Comment 3 Assaf Berg 2005-05-29 07:36:03 UTC
The patch is working great for me
Comment 4 Assaf Berg 2005-05-29 09:01:00 UTC
Looks like a bug in shorewall but I get errors when restoring my traffic control:

 * Restarting firewall...
Restoring Shorewall...
Loading kernel modules...
Clearing Traffic Control/QOS
Restoring Proxy ARP...
Restoring one-to-one NAT...
Restoring ARP filtering...
Restoring IP Forwarding...
Restoring Masquerading/SNAT...
Restoring Traffic Control...
/var/lib/shorewall/restore: line 116: run_tc: command not found
/var/lib/shorewall/restore: line 159: run_iptables: command not found
...
Comment 5 Marcelo Goes (RETIRED) gentoo-dev 2006-02-18 18:34:25 UTC
Works for me with 3.0.5. In cvs.
Thanks!