Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91335 - Add livecd USE flag to links
Summary: Add livecd USE flag to links
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Marcelo Goes (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 75685
  Show dependency tree
 
Reported: 2005-05-03 10:44 UTC by Chris Gianelloni (RETIRED)
Modified: 2005-05-04 12:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
links-2.1_pre17.diff (links-2.1_pre17.diff,2.06 KB, patch)
2005-05-03 10:46 UTC, Chris Gianelloni (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gianelloni (RETIRED) gentoo-dev 2005-05-03 10:44:44 UTC
Here's the request:

I would like for links to link/DEPEND against libjpeg if livecd is in USE.  This allows us to not have to add jpeg to the USE flags for building our releases, but allows for jpegs to display on www.g.o, since we already build with fbcon in USE.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2005-05-03 10:46:35 UTC
Created attachment 57946 [details, diff]
links-2.1_pre17.diff

This patch is against links-2.1_pre17.ebuild and makes USE="livecd" act like
USE="fbcon jpeg"
Comment 2 Marcelo Goes (RETIRED) gentoo-dev 2005-05-03 15:46:38 UTC
Sounds good, but it fails repoman scan.

  DEPEND.badindev                1
   www-client/links/links-2.1_pre17.ebuild: ~ppc-macos ['sys-libs/gpm']
  RDEPEND.badindev               1
   www-client/links/links-2.1_pre17.ebuild: ~ppc-macos ['sys-libs/gpm']

Removing sys-libs/gpm from the livecd? statement fixes it, but alas, aside from gpm not having ppc-macos in KEYWORDS I do not understand what is causing it...
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2005-05-04 04:25:29 UTC
Well, you can either make a -r1 ebuild, removing the ppc-macos KEYWORDS and filing a bug to them, or you can simply wrap the new stuff in !ppc-macos? ( ... ) and ! use ppc-macos, where needed.  Want a new patch?
Comment 4 Marcelo Goes (RETIRED) gentoo-dev 2005-05-04 11:26:18 UTC
I went with the first approach, it seems a cleaner way to do it for me.
sys-libs/gpm ppc-macos keyword request is in bug 91463.

Thanks Chris
Comment 5 Marcelo Goes (RETIRED) gentoo-dev 2005-05-04 11:26:47 UTC
In cvs.
Comment 6 Marcelo Goes (RETIRED) gentoo-dev 2005-05-04 12:37:37 UTC
Well, turns out it can't be keyworded. I'll change it to use !ppc-macos?.