First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 90847
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo/BSD Team <bsd@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Diego Pettenò <flameeyes@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
gawk-3.1.4.patch gawk-3.1.4.patch patch Diego Pettenò 2005-04-29 05:33 0000 2.55 KB Details | Diff
gawk-3.1.4-checkrm.patch gawk-3.1.4-checkrm.patch patch Diego Pettenò 2005-04-29 05:33 0000 1.32 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 90847 depends on: Show dependency tree
Show dependency graph
Bug 90847 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-04-29 05:33 0000
The attached patch applied over current gawk ebuild (if possible having a
revision bump can help g/fbsd but that's not required) makes it possible to use
the same ebuild with Linux and bsd-userland systems without having the original
awk overwritten by gawk.

It also avoid installing filefuncts on bsd-userlarnd systems (not sure about
this, it was avoided on g/fbsd at least).

It needs the -checkrm patch which adds a check in configure.ac for rm command
as makefiles refers to it as $(RM) which wasn't correctly resolved on g/fbsd
for some reason.

Thanks in advance,
Diego

------- Comment #1 From Diego Pettenò 2005-04-29 05:33:34 0000 -------
Created an attachment (id=57570) [edit]
gawk-3.1.4.patch

------- Comment #2 From Diego Pettenò 2005-04-29 05:33:57 0000 -------
Created an attachment (id=57571) [edit]
gawk-3.1.4-checkrm.patch

------- Comment #3 From SpanKY 2005-04-29 06:02:02 0000 -------
filefuncs.so is used by baselayout so you dont want to make that dependent upon
USERLAND

also, doesnt OS X use the current ebuild w/out changes ?

------- Comment #4 From Diego Pettenò 2005-04-29 06:10:42 0000 -------
Uhm filefuncts here isn't used, maybe it should be separed into an ebuild of
its own?

About osx, i see no ppc-macos keyword in the ebuild, so i don't really know.

------- Comment #5 From Stephen Bennett (RETIRED) 2005-04-29 06:33:01 0000 -------
OSX and gawk is completely horked up. Last I knew they couldn't use the ebuild
because of something weird with apple's gawk or something. 

As for filefuncs and baselayout, we have the filefuncs module in the baselayout
ebuild for some reason, so we don't want it in gawk. Plus it doesn't build.

------- Comment #6 From SpanKY 2005-05-02 20:49:09 0000 -------
so what's the goal here ?  to not install /bin/awk and /usr/bin/awk ?  you only
want to install /bin/gawk and /usr/bin/gawk on BSD ?

------- Comment #7 From Diego Pettenò 2005-05-03 03:28:51 0000 -------
Yes mainly that's the problem. awk on non-gnu systems is system's awk and
shouldn't be overwritten... just like gmake/make.

------- Comment #8 From SpanKY 2005-05-03 21:31:53 0000 -------
$(RM) is a GNU make builtin ... can you possibly get that added to bsd make ? 
i imagine it's a common thing to just use $(RM) without defining it in
configure ...

------- Comment #9 From Diego Pettenò 2005-05-04 04:13:27 0000 -------
But we use gnu make to compile gawk...

------- Comment #10 From SpanKY 2005-05-04 05:28:16 0000 -------
ok, so what does this show:
$ echo 'testit:'$'\n\t''@echo $(RM)' > maketest
$ make -f maketest testit

on my box it shows:
rm -f

------- Comment #11 From Diego Pettenò 2005-05-04 05:36:55 0000 -------
Hmm with gmake it works...
now the problem is: why on the earth also if make is aliased to gmake it doesn't work with emake? maybe we should make emake use gmake as now gmake is present anyway on gentoo/linux.

------- Comment #12 From SpanKY 2005-05-05 18:35:58 0000 -------
check out 3.1.4-r4, it should be all set now

------- Comment #13 From Diego Pettenò 2005-05-06 04:46:01 0000 -------
Still problems with makes...

first problem: the $(RM) thing. Seems like gawk calls $(MAKE) but unalias it first, so that the call is actually done for bsd make instead of gmake. putting MAKE="gmake" on emake commandline fixes it.

Also filefuncts's emake calls bsdish make (usually emake doesn't call make, but gmake so I really don't know what on earth is going on here), and the $^ var isn't expanded (gnu-ish?).
The solution for filefuncts is to replace $^ with $< as there's just one prerequisite.

------- Comment #14 From SpanKY 2005-05-06 05:25:04 0000 -------
gawk doesnt seem to set the MAKE variable (grep the source and you should only
see the makefiles using it, not setting it)

the fact that filefuncs fails too indicates something unrelated eh ?

research it and get back to us :P

------- Comment #15 From Diego Pettenò 2005-05-14 06:04:45 0000 -------
Marking as fixed, emake problem will be reported as another bug.

First Last Prev Next    No search results available      Search page      Enter new bug