First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 90845
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Robert Moss (RETIRED) <robmoss@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Sven Wegener <swegener@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
grub-xfs-writable-strings.patch grub-xfs-writable-strings.patch patch Sven Wegener 2005-04-29 04:51 0000 497 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 90845 depends on: Show dependency tree
Show dependency graph
Bug 90845 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-04-29 04:50 0000
This is the same issue I reported yesterday to GRUB bug mailing list. I'll just
copy'n'paste the email:

GRUB has a segfault issue that comes up, when using XFS as the
filesystem for the boot directory and GRUB has been compiled without
writable string support.  With current GCC versions writable string
support is disabled by default and -fwritable-string is deprecated.
Programs should not assume that constant strings, which are stored in
the text area of the program, are writable.

The following three lines from stage2/fsys_xfs.c contain the statements
that causes GRUB to segfault:

Line 337        static char *usual[2] = {".", ".."};
Line 339        char *name = usual[0];
Line 405        name[namelen] = 0;

First we declare usual to contain two constant strings. Then we assign
one of them to name and later we (might) try to write to one character
of the string. Please find attached a patch against current CVS that
transforms usual into an array of characters, so that writing to them is
safe.

------- Comment #1 From Sven Wegener 2005-04-29 04:51:41 0000 -------
Created an attachment (id=57568) [edit]
grub-xfs-writable-strings.patch

------- Comment #2 From Sven Wegener 2005-05-07 19:58:15 0000 -------
Patch has been accepted by upstream developers and I added it to our package.
I consider this fix important because it breaks fresh install on xfs filesystems.

------- Comment #3 From Sven Wegener 2005-07-01 03:49:04 0000 -------
*** Bug 96095 has been marked as a duplicate of this bug. ***

------- Comment #4 From Sven Wegener 2005-07-01 03:49:12 0000 -------
*** Bug 97571 has been marked as a duplicate of this bug. ***

First Last Prev Next    No search results available      Search page      Enter new bug