Bugzilla Bug 90177

rss-glx-0.8.0 build fails; skyrocket.cpp missing #include <cassert>.


Reproducible: Always
Steps to Reproduce:
1. 'emerge rss-glx'
2.
3.

Actual Results:  
hyperspace.cpp: In function `void hack_init(xstuff_t*)':
hyperspace.cpp:521: error: `assert' undeclared (first use this function)
hyperspace.cpp:521: error: (Each undeclared identifier is reported only once 
   for each function it appears in.)
make[3]: *** [hyperspace.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory
`/var/tmp/portage/rss-glx-0.8.0/work/rss-glx_0.8.0/reallyslick/cpp_src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/rss-glx-0.8.0/work/rss-glx_0.8.0/reallyslick'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/rss-glx-0.8.0/work/rss-glx_0.8.0'
make: *** [all] Error 2

!!! ERROR: x11-misc/rss-glx-0.8.0 failed.
!!! Function src_compile, Line 68, Exitcode 2
!!! (no error message)
!!! If you need support, post the topmost build error, NOT this status message.


Expected Results:  
Build properly...

The file skyrocket.cpp (rss-glx_0.8.0/reallyslick/cpp_src/skyrocket.cpp) is
missing a '#include <cassert>'.

----------------------------------------------------------------

'emerge info':
Gentoo Base System version 1.4.16
Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-3.3.5-20050130,
glibc-2.3.4.20041102-r1, 2.6.11-gen
too-r6_050423_SMP_PREEMPT i686)
=================================================================
System uname: 2.6.11-gentoo-r6_050423_SMP_PREEMPT i686 Intel(R) Pentium(R) 4 CPU
2.40GHz
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb  8 2005, 01:07:44)]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.5, 1.8.5-r3, 1.6.3, 1.7.9-r1, 1.4_p6, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r7
sys-devel/libtool:   1.5.14
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env
/usr/kde/3.3/share/config /usr/kde/3.3
/shutdown /usr/kde/3/share/config /usr/lib/MozillaFirefox/searchplugins
/usr/lib/X11/xkb /usr/lib/mo
zilla/defaults/pref /usr/lib/mozilla/searchplugins /usr/share/config
/usr/share/texmf/dvipdfm/config
/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/co
nfig/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://ds.thn.htu.se/linux/gentoo http://ftp.du.se/pub/os/gentoo
ftp://ftp.du.se/pub
/os/gentoo http://mirror.pudas.net/gentoo ftp://mirror.pudas.net/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac aalib acl acpi aim alsa ansi arts audiofile avi
bash-completion bcmath berkdb bit
map-fonts bzlib caps cdparanoia cdr crypt cscope ctype cups curl dga directfb
divx4linux doc dv dvd 
dvdr dvdread emacs emboss encode esd examples exif fbcon ffmpeg fftw flac
foomaticdb fortran freetyp
e ftp gd gdbm gif ginac glut gmp gnutls gphoto2 gpm gtk gtk2 guile hal iconv icq
imagemagick imap im
lib jabber java jpeg junit kerberos ladcca lcms ldap leim libg++ libwww
lm_sensors mad matroska meml
imit mhash mikmod mime mmap mmx mng motif mozilla mp3 mpeg mplayer mysql mythtv
ncurses nls nptl ogg
 oggvorbis openal opengl oss pam pcntl pcre pdflib perl pic pie plotutils png
portaudio posix postgr
esql ppds python qt quicktime readline recode ruby sandbox sasl scanner sdl
session shared sharedmem
 sndfile sockets sox speex spell sse ssl svg symlink sysvipc szip tcltk tcpd
tetex theora threads ti
ff truetype truetype-fonts type1-fonts unicode usb v4l vanilla vcd videos vorbis
wmf xine xml xml2 x
mms xpm xprint xv xvid zlib video_cards_radeon"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS

Created an attachment (id=57051) [edit]
This patch just adds an '#include <cassert>'.

I'm not that familiar with patch-making so I may have made something bad; I
used the '-Naur' flags for the diff-command.

Apparently the file hyperspace.cpp is also missing the '#include <cassert' and
the ebuild (rss-glx-0.8.0) has a typo; the line containing 'cp
${FILESDIR}/jwz-vroot.h ${S}/includes/vroot.h' should be 'cp
${FILESDIR}/jwz-vroot.h ${S}/include/vroot.h' (the 's' in '.../includes/...
should be removed).

Created an attachment (id=57060) [edit]
Another assert patch for the hyperspace.cpp file.

Created an attachment (id=57061) [edit]
A small diff for an ebuild that works and with a fixed typo.

thanks for the patches and the (embarassing) typo fix! 

odd that i got it to compile without those patches when i first committed it.