Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89939 - www-apache/mod_jk doesn't need to depend on Tomcat
Summary: www-apache/mod_jk doesn't need to depend on Tomcat
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jan Brinkmann (RETIRED)
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-04-21 09:04 UTC by Andy Wang
Modified: 2005-04-29 10:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wang 2005-04-21 09:04:23 UTC
mod_jk has no required dependency on tomcat.  To use it, you probably need a tomcat running somewhere, but that tomcat could be running anywhere (i.e. not on the current host).  Additionally, you could use mod_jk to talk to Jboss with a bundled tomcat vs. a standalone tomcat.

I think this dependency should be removed.
Comment 1 Jan Brinkmann (RETIRED) gentoo-dev 2005-04-21 09:17:40 UTC
ok, in that case i'll add a warning to pkg_postinst to tell users about it
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2005-04-21 10:34:11 UTC
Hmm, I
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2005-04-21 10:34:11 UTC
Hmm, I´d prefer something like USE="tomcat" ;-)
Comment 4 Jan Brinkmann (RETIRED) gentoo-dev 2005-04-21 11:09:24 UTC
a useflag with that name is misleading, imho
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2005-04-21 11:34:43 UTC
Why should it be misleading if it emerges tomcat as a dependency? :-) 

BTW, the default values workers.tomcat_home and worker.ajp13.host (in jk-workers.properties) and jkAutoAlias and jkMount (in 88_mod_jk.conf) no longer make sense if Tomcat is not installed on localhost. Sure, this is a purely cosmetic issue. 
Comment 6 Andy Wang 2005-04-21 16:14:39 UTC
I was originally going to suggest a USE flag, but the useflag is misleading.  In practice, gentoo developers abuse the USE flags tremendously however.

USE flags should only directly impact the package being built.  There is nothing about tomcat that is either necessary to build or use mod_jk.  All adding a tomcat USE flag would be doing is making mod_jk dependent on tomcat, so that it happens to get installed, which IMO is actually the misleading thing, because there's nothing about mod_jk that requires tomcat in and of itself.

I do agree that the default worker and mod_jk.conf files are irrelevant.  However, if you're using tomcat to communicate with a remote system, you should be capable of understanding the files and tweaking them, and if you aren't, you can simply emerge tomcat, and the default files will allow things to work.

workers.tomcat_home and workers.java_home are pretty much useless properties now so they don't even need to be set.  Those properties are used for an inprocess worker, which I believe is either deprecated, or not even implemented in mod_jk anymore.  Can't remember which.
Comment 7 Jan Brinkmann (RETIRED) gentoo-dev 2005-04-29 10:43:15 UTC
fixed in cvs, thanks for the suggestion and for using gentoo. :-)