Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89769 - Zero Penalty Hit patch for SQUID
Summary: Zero Penalty Hit patch for SQUID
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL: http://www.it-academy.bg/zph/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-20 00:48 UTC by Iosif Peterfi
Modified: 2005-04-25 00:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Iosif Peterfi 2005-04-20 00:48:12 UTC
Hello, i've been using the zph patch for a while and works fine. I was wondering if you would care to patch the portage version of squid. Is small, and verry efficient for a squid running on a transparent proxy with tc classes.
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2005-04-20 02:27:19 UTC
I will add in the next release of squid, controlled by a zph local flag.

However, there are 2 variants of this patch, the original one (simple patch indeed) and that made by Evgeni Gechev (a more elaborate patch).
Which one do you use?
Comment 2 Iosif Peterfi 2005-04-21 00:22:21 UTC
I'm using the one with TOS marking(Evgeni Gechev), the more complex one. The good thing about this patch is that TOS mark can be specified at runtime, and matched with iptables TOS match. The other patch is indeed more simple, but is harder to implement. One thing is that  IP_OPTIONS cannot be specified at commandline, only at compile time. The other thing is that netfilter support for ipv4options is experimental, and still cannot match packets with flag Stream ID, as in the patch. The iproute2 filter might work, but i never tried it. I do the shaping with tc clases + iptables/mangle/CLASSIFY traget.
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2005-04-24 02:43:16 UTC
I've included in 2.5.9-r4, along with current official patches. it is applied only if zero-penalty-hit flag is set.

it wasn't a smooth process (I had to rebuild the patch for 2.5.STABLE9 because upstream seems to be uninterested in current versions of squid). makes me wonder if it was wise to fix this bug.
If I didn't know how useful is this patch for Romanian users, I wouldn't do it.
Comment 4 Iosif Peterfi 2005-04-25 00:15:44 UTC
I am Romanian too, and you bet is very useful :D
Thanks a lot !