Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89255 - x11-terms/mrxvt econf usage cleanup to remove double setting of options
Summary: x11-terms/mrxvt econf usage cleanup to remove double setting of options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Mamoru KOMACHI (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-15 21:33 UTC by James Rowe
Modified: 2005-04-23 01:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mrxvt-enable_everyting_cleanup.patch (mrxvt-enable_everyting_cleanup.patch,789 bytes, patch)
2005-04-15 21:34 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-04-15 21:33:44 UTC
The --enable-everything option specifically enables most of the
options that are then re-enabled with --enable-foo in the econf call. 
Purely cosmetic, but in this instance it helps to understand what is
actually being enabled in my opinion.  Without having to check both 
--enable-everything's rule and also --enable-foo's rule and check they
don't clash.

  The only exception is the --enable-shared, which I think I must be
missing the point of.  According to the ebuild and package, as far as I
can tell, it is doing absolutely nothing at all.

  Any pointers about the reason for linguas_* usage would be greatly
appreciated too.  Where are they defined?  And for what its worth some
of the options their tests set are enabled by default too.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-04-15 21:34:24 UTC
Created attachment 56410 [details, diff]
mrxvt-enable_everyting_cleanup.patch
Comment 2 Mamoru KOMACHI (RETIRED) gentoo-dev 2005-04-23 00:44:50 UTC
k, I cleaned --enable-* flags from the ebuild (it was copied
from x11-terms/rxvt and I can't remember why they were there).
linguas_* USE flags are defined by USE_EXPAND. See /etc/make.globals
for default USE_EXPAND. linguas_* are our de facto USE flags 
for multilingual support. I don't think it's good but anyway
we are using them :( If you are interested in m17n support
in portage-wise, have a look at bug #9988.
Comment 3 James Rowe 2005-04-23 01:54:35 UTC
  Thanks for the resolution, and answering my clueless questions too.