Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89180 - /etc/init.d/mpd start-stop-daemon in stop() function should specify --oknodo
Summary: /etc/init.d/mpd start-stop-daemon in stop() function should specify --oknodo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-04-15 07:05 UTC by Philip Kovacs
Modified: 2005-05-05 07:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Kovacs 2005-04-15 07:05:38 UTC
The mpd daemon will have terminated by the time start-stop-daemon --stop gets to it, since mpd traps the TERM signal and shuts down well before its /etc/init.d/mpd stop command is run.   The start-stop-daemon --stop command in /etc/init.d/mpd will return 1 unless --oknodo is specified, as it should in this case.  The fix below will cause eend $? to report [ok] on mpd shutdown and not [!!].

In /etc/init.d/mpd:

stop() {
   ebegin "Stopping Musinc Player Daemon"
   start-stop-daemon --stop --quiet --exec /usr/bin/mpd 
   eend $?
}

should be:

stop() {
   ebegin "Stopping Musinc Player Daemon"
   start-stop-daemon --stop --quiet --exec /usr/bin/mpd --oknodo
   eend $?
}


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jan Brinkmann (RETIRED) gentoo-dev 2005-05-05 07:32:15 UTC
fixed in cvs, thanks