If for some reason groff uses a non-bash shell {sh,ksh} for compilation, the groff-1.18-no-netpbm-depend.patch breaks this. Reproducible: Always Steps to Reproduce: 1. Look at bug 87877 for the backgrounds of such a build-environment. 2. Try to install groff on a sparc-sun-solaris2.8 box with the groff-*.ebuild 3. You do not actually need to do this: there's a patch attached here. Actual Results: for f in ; do \ rm -f /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f; \ /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/bin/install -c -m 644 ./$f /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f; \ done /bin/ksh: syntax error at line 1 : `;' unexpected make[2]: *** [install_data] Error 2 make[2]: Leaving directory `/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1/doc' make[1]: *** [doc] Error 2 make[1]: Leaving directory `/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1' make: *** [install] Error 2
Created attachment 56349 [details, diff] let groff compile with non-bash shells too
the netpbm patch is just very ugly anyways ... should rewrite it to not suck ...
changed the patch so it sets the variables to '' rather than '# ...'
Well, the macros _are_ already empty, the '#' is seen by _make_ as a comment. The problem is the shell-code (part 2 in my patch), where _make_ calls the shell like this: system("/bin/sh -c 'for f in ; do ...'") The non-bash-Shell does not accept the "for f in ; do ...", but would accept "for f in ${list} ; do ..." where ${list} expands to empty.
*now* you tell me :P updated the netpbm patch
