Bugzilla Bug 88247

mc gives me a list of shared folders of some host, but when I try to open one
of them I get Segmentation fault

I found that the problem is in file vfs/smbfs.c in folder with mc distrib. In
function chkpath (line 606) we try to fill memory at address NULL twice
(cli->outbuf and cli->inbuf had not been allocated before using) If we add two
lines to 615 line bug dissapears:

        cli->outbuf=malloc(smb_size);
        cli->inbuf=malloc(1000);

I wrote 1000 because I don't know size needed for cli->inbuf.
I can send new file mc-4.6.0-sambalib-3.0.0.patch

PS Excuse me for bad English


Reproducible: Always
Steps to Reproduce:
1.emerge mc with smb support (USE='samba' emerge mc)
2.Execute it and press Right->SMB link...
3.Enter name of the host, then enter username guest
4.Try to enter some shared folder

Actual Results:  
Segmentation fault

Expected Results:  
Open shared folder

Portage 2.0.51.19 (default-linux/x86/2004.3, gcc-3.3.3,
glibc-2.3.3.20040420-r0,
2.6.6 i686)
=================================================================
System uname: 2.6.6 i686 AMD Athlon(tm) XP 2500+
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.4-r3,dev-lang/python-2.3.3-r1 [2.4 (#1,
Mar 22 2005, 21:16:19)]
dev-lang/python:     2.4-r3, 2.3.3-r1
sys-devel/autoconf:  2.59-r3
sys-devel/automake:  1.8.3
sys-devel/binutils:  2.14.90.0.8-r1
sys-devel/libtool:   1.4.3-r4
virtual/os-headers:  2.4.21-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms"
GENTOO_MIRRORS="ftp://194.85.81.130/Gentoo"
LANG="ru_RU.KOI8-R"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://194.85.81.130/gentoo-portage"
USE="x86 X alsa apm arts avi bash-completion berkdb bitmap-fonts cdr crypt cups
emboss encode esd fam font-server foomaticdb fortran gdbm gif gpm gtk2
imagemagick imlib ipv6 java jpeg kde libg++ libwww mad mikmod motif mp3 mpeg
ncurses nls oggvorbis opengl oss pam pdflib perl png python qt quicktime
readline samba sdl slang spell ssl svga tcltk tcpd tiff truetype truetype-fonts
type1-fonts xml xml2 xmms xv zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS, PORTDIR_OVERLAY

Created an attachment (id=56232) [details]
changed sambalib patch for mc that fixes this bug

May be, it would be better to write a patch for this patch...

it should be no problem for you to make a patch to the patch, it's easier to
include ;)

can you make a patch please?

fixed in -r14