First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 86850
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Development Tools Team <dev-tools@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Ivan Yosifov <iyosifov@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
eclipse-sdk-3.0.2.ebuild Working ebuild (modified version of 3.0.1-r2) text/plain Mikko Tiihonen 2005-03-29 21:54 0000 13.53 KB Details
05-mozilla-xpcom.patch Required patch patch Mikko Tiihonen 2005-03-29 21:57 0000 862 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 86850 depends on: Show dependency tree
Bug 86850 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-03-27 04:19 0000
http://eclipse.org/downloads/index.php

Portage is 3.0.1-r2

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Mikko Tiihonen 2005-03-29 21:54:19 0000 -------
Created an attachment (id=54821) [edit]
Working ebuild (modified version of 3.0.1-r2)

------- Comment #2 From Mikko Tiihonen 2005-03-29 21:57:04 0000 -------
Created an attachment (id=54822) [edit]
Required patch

With the attached ebuild ant patch I managed to build a working eclipse 3.0.2.
System was amd64, sun-jdk-1.5.0_02, mozilla 1.7.6.
I tried to make it work with 386 machines too.

------- Comment #3 From Billy Biggs 2005-03-30 06:35:52 0000 -------
That patch you posted removes the Equals method for strings, which seems to be
used all over the place in the eclipse mozilla code.  Are you just disabling
the browser support (if so, there are easier ways to do it).  I am confused by
your patch.

------- Comment #4 From Mikko Tiihonen 2005-03-30 10:54:39 0000 -------
I removed the Equals method because it doesn't compile. The nsEmbedString
doesn't have an Equals method (see
http://developer.mozilla.org/xpcom/api/nsEmbedString/ and the nsAString).

The eclipse 3.1 has an ifdef around that method and the 3.1pre5 ebuild marks it
as not available with the proper define. I also looked at the latest xpcom.cpp
in eclipse CVS and they have removed the Equals method for strings altogether
(http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.swt/Eclipse%20SWT%20Mozilla/common/library/xpcom.cpp?rev=1.21&content-type=text/vnd.viewcvs-markup)

I was planning of emulating the Equals method with get()'s and plain memcmp but
I first tried if the system would work without the method. Because it did work
for me I left it like this.

------- Comment #5 From Mikko Tiihonen 2005-03-30 10:59:41 0000 -------
Currently I have only tried browsing the help pages with mozilla which works
nicely.

If you can tell what else I should test to verify that the mozilla support
works properly then I can try it too.

------- Comment #6 From Billy Biggs 2005-03-30 11:10:51 0000 -------
The javadoc view uses the embedded browser widget.  When you're browsing the
help pages, I don't think you're using an embedded browser, I think we're just
opening your system web browser and using that.

------- Comment #7 From Mikko Tiihonen 2005-03-30 21:37:50 0000 -------
I just tried browsing the javadocs and it indeed opens them in my system
browser. Googling for embedded eclipse browser I know understand that I have
never seen it in action, even at work with x86 on redhatws/fedora1-3/mandrake10
with prebuilt packages.

Anyway the xpcom glue code looked totally broken as it passed _all_ pointers
using ints, which should crash the system when used on 64bit arch.

...time goes on...

There are no complaints or exceptions in the logs, and the help configuration
does not allow to show any option for embedded broser.

... more investiagtion...

If I run this before launching eclipse: (it seems that at least the /components
subdirectory is not in the normal library path and eclipse find first the
firefox)
export LD_LIBRARY_PATH=/usr/lib/mozilla/:/usr/lib/mozilla/components

Then I get a nice exception:
!ENTRY org.eclipse.core.runtime 4 2 maalis 31, 2005 08:31:09.273
!MESSAGE Problems occurred when invoking code from plug-in:
"org.eclipse.core.runtime".
!STACK 0
java.lang.NoClassDefFoundError: org/eclipse/swt/internal/mozilla/GRE
        at org.eclipse.swt.browser.Browser.<init>(Browser.java:121)
        at
org.eclipse.help.ui.internal.browser.embedded.EmbeddedBrowserFactory.test(EmbeddedBrowserFactory.java:65)
        at
org.eclipse.help.ui.internal.browser.embedded.EmbeddedBrowserFactory.isAvailable(EmbeddedBrowserFactory.java:46)
        at
org.eclipse.help.internal.browser.BrowserManager.createBrowserDescriptors(BrowserManager.java:176)
        at
org.eclipse.help.internal.browser.BrowserManager.init(BrowserManager.java:53)
        at
org.eclipse.help.internal.browser.BrowserManager.isEmbeddedBrowserPresent(BrowserManager.java:335)

That one still doesn't look like missing reference to Equals to me, but who
knows: java seems to have quite poor error reporting when linking with native
code.

I do not think I can try to test this further. The ebuild works for me as well
as it has ever worked. Someone who has seen the embedded browser work should
test if it really needs that Equals, and if it does then someone should
implement it.

------- Comment #8 From stefan@sf-net.com 2005-04-02 03:05:46 0000 -------
The ebuild + patch went fine on my machine (P4, i686)

...hth...

-Stefan

------- Comment #9 From Karl Trygve Kalleberg (RETIRED) 2005-04-08 11:30:49 0000 -------
I added LD_LIBRARY_PATH to the eclipse-3 wrapper script that includes firefox
the mozilla's components/ directory. That makes the embedded browser work.
Tried against mozilla 1.7.5 and firefox 1.0.2.

------- Comment #10 From Karl Trygve Kalleberg (RETIRED) 2005-04-08 11:34:34 0000 -------
Available for testing on x86, ppc and amd64. 

First Last Prev Next    No search results available      Search page      Enter new bug