Bug 85663 – gtk+-2.6-smoothscroll-r2.patch causes incorrect page_forward behavior

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description mbxhere 2005-03-17 10:59:54 UTC]

In the patched page_forward function, new_val is decremented instead of incremented. (It is incremented in page_forward() in stock gtk+, and decremented in page_back()). The smoothscroll patch causes page_forward and page_back to perform the same when smooth scrolling can't be done.

Reproducible: Always
Steps to Reproduce:
1. Instantiate a GtkHscale with a page size
2. Set some number of digits to round
3. Click on either side of the tray or press Page Up or Page Down

Actual Results:  
The slider always decreases

Expected Results:  
The slider should sometimes increase, sometimes decrease, depending on the input

[Comment 1 mbxhere 2005-03-17 11:01:38 UTC]

Created attachment 53717 [details, diff]
Proposed patch to fix the scrolling patch problem

[Comment 2 Matthew Gates 2005-04-09 04:36:17 UTC]

Found the same bug.  Attached is a test program that demonstrates the problem which might be used to test fix.

[Comment 3 foser (RETIRED) 2005-04-16 04:45:45 UTC]

i see no test program attached, but i do see the problem & fixed it in the -r5 patch (gtk+-2.6.7) .

Thanks for the fix.