Bug 84997 – bzip2 path hardcoded in gnome theme manager 2.10

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Matt Kynx 2005-03-12 10:04:47 UTC]

bzip2 is installed to /bin/bzip2, not /usr/bin/bzip2 as hardcoded into:
gnome-control-center/capplets/theme-switcher/gnome-theme-installer.c



Reproducible: Always
Steps to Reproduce:
1. Select Desktop > Preferences > Themes
2. Click on Install Theme
3. Browse for bz2 theme
4. Click Open and Install

Actual Results:  
Error message: "Cannot install theme. The bzip2 utility is not installed"

Expected Results:  
Theme is installed

Guess you could work around it with:
ln -s /bin/bzip2 /usr/bin/bzip2

[Comment 1 Matt Kynx 2005-03-12 10:07:33 UTC]

Created attachment 53272 [details, diff]
fix for hardcoded /usr/bin/bzip2 path

I've entered this as a bug on gnome at:
http://bugzilla.gnome.org/show_bug.cgi?id=170058

[Comment 2 SpanKY 2005-05-25 15:12:51 UTC]

well, that 'fix' isnt any better

it should either check both places or check PATH

[Comment 3 Daniel Gryniewicz (RETIRED) 2005-05-25 21:26:37 UTC]

I have a patch that replaces the hardcoding with g_find_program_in_path() that
I'm testing now.  I'll run it past foser and company and commit once it's
approved, and then submit upstream.

[Comment 4 Daniel Gryniewicz (RETIRED) 2005-05-26 08:47:17 UTC]

Created attachment 59883 [details, diff]
Proposed fix

Proposed fix.  It replaces hard coded binaries (tar, gzip, and bzip2) with
calls to g_find_program_in_path()

[Comment 5 Daniel Gryniewicz (RETIRED) 2005-05-26 09:13:19 UTC]

Created attachment 59885 [details, diff]
Updated fix

Here's an updated fix that removes all the conditionals around g_free(), as it
can correctly handle a NULL argument.

[Comment 6 Daniel Gryniewicz (RETIRED) 2005-05-26 10:26:14 UTC]

Fixed in CVS, patch pushed upstream.