Bugzilla Bug 83419

When emerging Muine 0.6.3-r2, I get this:

player-gst.c: In function `player_construct':
player-gst.c:157: warning: implicit declaration of function `_'
player-gst.c:157: warning: nested extern declaration of `_'
player-gst.c:157: warning: passing arg 1 of `g_strdup' makes pointer from integer without a cast
player-gst.c:164: warning: nested extern declaration of `_'
player-gst.c:164: warning: passing arg 1 of `g_strdup' makes pointer from integer without a cast
player-gst.c:173: warning: nested extern declaration of `_'
player-gst.c:173: warning: passing arg 1 of `g_strdup' makes pointer from integer without a cast
player-gst.c:182: warning: nested extern declaration of `_'
player-gst.c:182: warning: passing arg 1 of `g_strdup' makes pointer from integer without a cast
make[3]: *** [player-gst.lo] Error 1


The usage of the underscore in: (_("Failed to create GstPlay object")) seems a little odd to me, but some googling shows it seems to be standard glib usage. Could this be related to running Gnome 2.9 from breakmygentoo?

Reproducible: Always
Steps to Reproduce:
1. Emerge latest muine




Portage 2.0.51-r15 (default-linux/x86/2004.3, gcc-3.4.3,
glibc-2.3.4.20040808-r1, 2.6.10-gentoo-r6 i686)
=================================================================
System uname: 2.6.10-gentoo-r6 i686 Intel(R) Pentium(R) 4 CPU 2.53GHz
Gentoo Base System version 1.6.9
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb  8 2005, 13:22:57)]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=pentium4 -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=pentium4 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms"
GENTOO_MIRRORS="ftp://gentoo.risq.qc.ca/ ftp://adelie.polymtl.ca
ftp://cs.ubishops.ca/pub/gentoo http://distfiles.gentoo.org
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="en_CA"
LC_ALL="en_CA"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/bmg-main /usr/local/overlays/deltup"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X aac aalib acpi alsa audiofile avi bash-completion berkdb bitmap-fonts bmp
bonobo bzlib cdr cpdflib crypt cups curl curlwrappers dbus divx4linux dvd
dvdread emboss encode f77 faad fam fftw flac font-server foomaticdb fortran ftp
gdbm gif gimpprint gnome gnomedb gnutls gphoto2 gpm gstreamer gtk gtk2 gtkhtml
guile hal howl icq imagemagick imap imlib jabber java jikes jpeg junit kerberos
libg++ libgda libwww mad mikmod mmx mng mono motif mozilla moznocompose moznoirc
moznomail mozsvg mp3 mpeg msn ncurses nls nptl offensive ofx oggvorbis openal
opengl oscar pam pdflib perl png ppds python quicktime readline real samba sasl
sdl sox speex spell sqlite sse sse2 ssl svg svga tcltk tcpd theora threads tiff
truetype truetype-fonts type1-fonts unicode usb x86 xml xml2 xosd xv xvid xvmc zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LDFLAGS

Yes, it probably is. I've seen one other user with the same warning as a result
of using 2.9.x gnome stuff from BMG. Marking INVALID.

If you have the same problem when *not* running *any* BMG stuff, feel free to
re-open. Thanks.

Created an attachment (id=53102) [details]
Fixes compile with gnome 2.10

The attached patch will fix compile against the new gnome-2.10 release, but I
don't have an older machine to test against so it might be worth a bump/mask
for general testing...

Ok, re-openning now that gnome-2.10 is in portage and I can reproduce.

I can confirm that this patch works for me. Although Muine fails to start with
the new gstreamer, a la bug 85017.

Created an attachment (id=53478) [details]
Updated patch - also fixes player-xine.c

The previous patch only fixed player-gst.c - the same problem exists in
player-xine.c

Ok, commited this fix to 0.6.3-r2 in portage. Marking FIXED. That just leaves
the gstreamer bug.