First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 82980
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo KDE team <kde@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Diego E. 'Flameeyes' Pettenò <flameeyes@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
k3b.patch Patch over current ebuild. patch Diego E. 'Flameeyes' Pettenò 2005-02-22 11:05 0000 1.82 KB Details | Diff
k3b.patch Patch over current ebuild (with configure switches) patch Diego E. 'Flameeyes' Pettenò 2005-02-23 09:57 0000 2.38 KB Details | Diff
k3b-0.11.20-without-switches.patch k3b-0.11.20-without-switches.patch patch Diego E. 'Flameeyes' Pettenò 2005-02-23 09:58 0000 4.84 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 82980 depends on: Show dependency tree
Bug 82980 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2005-02-22 11:04 0000 
The attached patch applied over current ebuild fixes some problems which comes
with the current ebuild.

flac, mad and oggvorbis useflags aren't honored, they are auto-checked by k3b's
configure.
This makes impossible to build k3b with flac 1.1.2 (which could not be disabled
by the -flac flag).

The patch fixes this, using autoconf tricks to disable the three libraries.
It also adds id3lib and samplerate useflags which allows to disable other
dependencies.

The patch also has the change for bug #81862 (which is minor to have a fix of
its own, but with also these changes it can help).

HTH, Diego

------- Comment #1 From Diego E. 'Flameeyes' Pettenò 2005-02-22 11:05:02 0000 ------- 
Created an attachment (id=51891) [details]
Patch over current ebuild.

------- Comment #2 From Carsten Lohrke 2005-02-22 11:11:21 0000 ------- 
Diego: Get into your shoes and join Gentoo as a dev. :p

------- Comment #3 From Gregorio Guidi (RETIRED) 2005-02-22 12:37:04 0000 ------- 
I committed the line to disable flac because it's quite urgent for bug 82558.

For the other changes, maybe we can get them properly fixed in k3b CVS since
Diego has access to it ;)

------- Comment #4 From Diego E. 'Flameeyes' Pettenò 2005-02-23 09:57:37 0000 ------- 
Created an attachment (id=51960) [details]
Patch over current ebuild (with configure switches)

Ok maybe you better like this version :)

It adds the hicolor icons, it fixes optional dependencies, it also add resmgr
support if requested, and instead of using dirt configure tricks it uses the
configure itself after patching it with the same patch I committed to K3B cvs
:) (see next attachment)

It's compatible with next version of k3b so the only thing needed for the next
version is remove the patch (and the icons, which are also added upstream).

I also have fixed the 'samplerate' useflag which was wrong, libsamplerate is
the one used on kde-base/akode and media-sound/gnusound.

------- Comment #5 From Diego E. 'Flameeyes' Pettenò 2005-02-23 09:58:16 0000 ------- 
Created an attachment (id=51961) [details]
k3b-0.11.20-without-switches.patch

------- Comment #6 From Gregorio Guidi (RETIRED) 2005-03-16 09:57:18 0000 ------- 
I added the configure switches for ogg, mad and flac in 0.11.22.
I didn't add new flags, though (id3lib, resmgr), I don't don't if it is worth adding them to make id3lib and resmgr configurable... opinions?

samplerate should not be configurable, because the choice is between linking to the external one or to the internal copy, so letting people do USE="-samplerate" would be misleading.

------- Comment #7 From Carsten Lohrke 2005-03-16 10:41:31 0000 ------- 
>opinions?

++ for preventing use flag inflation ;)

------- Comment #8 From Gregorio Guidi (RETIRED) 2005-03-17 08:30:09 0000 ------- 
Closing this bug, then...
First Last Prev Next    No search results available      Search page      Enter new bug