Bugzilla Bug 82347

Hi,

I have created a new ebuild to update from childsplay-0.68 to childsplay-0.80.1.1. There are 2 patches that need to be applied: one for the install paths and the other to fix a minor bug in one of the games. Please find attached all three files (ebuild and 2 patches).

Regards,

Mark

Created an attachment (id=51431) [edit]
childsplay-0.80.1.1.ebuild (new version)

Created an attachment (id=51432) [edit]
Patch to make install paths comply with gentoo filesystem

Created an attachment (id=51433) [edit]
Minor bug fix to the findsound2 module for childsplay

it definetely needs more patching - I tried install with provided patches &
ebuild and paths are all screwed up - no fonts, childsplay complainig about
absent childsplayrc...

Created an attachment (id=51486) [edit]
childsplay-0.80.1.1.ebuild (updated version)

I have fixed the missing rc files. Please indicate what other problems are
present. I do not see any font issue as was previously reported.

I have the following fonts installed on my system:

media-fonts/corefonts 
media-fonts/freefonts 
media-fonts/gnu-gs-fonts-std 
media-fonts/ttf-bitstream-vera 

Created an attachment (id=51526) [edit]
childsplay/childsplay-0.80.1.1.ebuild (path update)

The "screwed up paths" have now been cleaned up.
I see no warnings or errors while running other than the initial default
assignment to english locale.
The updated version of the patch for CPConstants.py is needed to go along with
this file.

Created an attachment (id=51528) [edit]
CPConstants.py.patch (updated)

This is the fix for the "screwed up paths". Please let me know of any other
warnings or errors you detect. Sorry about the initial bugs.

Regards,

Mark

regadring fonts problem - try to run it in terminal with FB. I'm running it
that way on my son's computer as it refuses to go into 800x600 in xorg and
frankly it's  quite slow to add xorg into the mix.

Works fine on my side, but I've got 2 remarks.

1):patch on findsound2 is no more required. Authors have adapted the code.

2):In the ebuild, I propose to use ${PV} instead of "hardcoded" the plugin version number.
line 10: plugins-${PV}.tgz
line 27: _plugins-${PV}

Thanks.

*** Bug 56631 has been marked as a duplicate of this bug. ***

Created an attachment (id=64227) [edit]
childsplay-0.80.2.ebuild

CPConstants.py in childsplay-0.80.2 requires BASEPATH.py.
Rather than set up our own BASEPATH.py (or a different CPConstants.py) and have
our own install script,
it seemed (to me) easier to modify childsplay's install scripts to install into
${D} and use the paths in games.eclass.

This version seems to work fine under X, but with a framebuffer it still has
font problems.
However childsplay-0.68 doesn't work well with a framebuffer either:  the score
is readable at least but the background is not present so its buttons are not
visible and clicking where they would be causes the program to exit status 1.
The framebuffer problems seem little reason not to provide a more up to date
version.
(gcompris also doesn't work with a framebuffer but it is up to date in
portage).

I haven't observed any problem with X refusing to go into 800x600.
If the X setup doesn't have a 800x600 mode, it seems to work fine with black
borders.
If you are observing something different, does childsplay --window work better?

A few comments:

I don't like the symlink from GAMES_DATADIR to GAMES_STATEDIR.  The source needs
to be patched to not write to GAMES_DATADIR.

The install ends up putting files in /usr/share/assetml.  What are they and can
they go in GAMES_DATADIR?

Any way to turn off the nls support?  USE=nls support would be nice.

Are any of these valid reasons not to include these newer ebuilds in portage? 
Portage currently only contains: childsplay-0.68 (02 Sep 2003)

Hi.  I'm not very familiar with the development side of ebuilds, but I'd be
willing to test or help if anyone needs help.  My son likes the game and I'd
love to see it kept up to date.  I can follow complicated instructions and I'm
decent at debugging.  I just don't to read all the gentoo/portage/ebuild
documentation right now and I'm not up on all the gentoo conventions.

Could the ebuild be added and masked for testing?

not until someone fixes the things mentioned in comment #12

Created an attachment (id=77378) [edit]
Update to 0.81.2

Created an attachment (id=77379) [edit]
default-locale.patch

This is used by childsplay-0.81.2.ebuild.

The ebuild I just uploaded doesn't use the hairy install scripts provided with
Childsplay, it fixes issues with the default locale, and does not try to write
to GAMES_DATADIR.

/usr/share/assetml is also used by gcompris.  It could go anywhere, but its
current location is probably best.

(From update of attachment 77379 [edit])
--- utils.py.orig       2006-01-17 15:15:01.000000000 -0700
+++ utils.py    2006-01-17 15:33:05.000000000 -0700
@@ -45,6 +45,8 @@
                     lang = os.environ['LANGUAGE'].split(':')[0]
                 else:
                     lang = locale.getdefaultlocale()[0]
+                    if not lang:
+                        lang = 'en'
             except ValueError, info:
                 print >> sys.stderr, info
                 lang = 'en'
@@ -93,6 +95,8 @@
         # This is a fix for systems that set LANGUAGE to ''.
         if lang == '':
             lang = locale.getdefaultlocale()[0]
+            if lang is None:
+                lang = 'en'
     except Exception,info:
         print >> sys.stderr,info
         print "Switching to English"

WFM with 0.81.5, and plugins 0.80.6, thanks, Shane.

It didn't WFM. The reason being that letters-trans.py couldn't find the
required assetml-file. It probably worked for you guys because it was already
on your HD (it didn't look in the image, but in the root fs). Attached a patch
to fix this and a new ebuild (for 0.81.5 and plugins 0.80.6)

Created an attachment (id=79585) [edit]
Childsplay 0.81.5 ebuild

This obsoletes Shane's 0.81.2 ebuild (but I can't obsolete it)

Created an attachment (id=79587) [edit]
letters-trans-path.patch.bz2

The patch

(From update of attachment 77378 [edit])
This ebuild has been superceded.

Incidentally, why haven't the new ebuilds been posted to the portage tree yet? 
Are there any Gentoo developers around?

probably waiting for a working ebuild.

other issue:  patches should be attached as text/plain - having them be binary
files is just one more step for people who want to look at the patch.

Created an attachment (id=84487) [edit]
childsplay-0.81.8.ebuild

This one should work.  Tested on amd64.  Note that there are now two plugin
packages included in the ebuild.

If this ebuild looks too complicated, we could try the alternate strategy of
editing the install scripts using sed.  Please advise.

Created an attachment (id=84488) [edit]
letters-trans-path.patch

Needed by the 0.81.8 ebuild.  It's just letters-trans-path.patch.bz2 unpacked.

Created an attachment (id=84489) [edit]
files/childsplay

This version of the childsplay launch script sets a default locale if there
isn't one.  This replaces the default-locale patch.  The author of Childsplay
is changing the locale detection code frequently, and the code is still broken;
this is a simple workaround.

Added to CVS... I apologize to everyone that this took so long to get done.

Thank you.