Bugzilla Bug 81345

The DSPAM 3.4 beta1 and beta2 ebuild has a typo in pkg_setup. The category is
wrong. It should be mail-filter/dspam instead of net-mail/dspam.

While looking at the ebuild I would suggest to change the way the ebuild checks
for multiple database backends. What do you think about something like this:
        local multiple_dbs="0"
        local supported_dbs="mysql postgres oci8 sqlite sqlite3"
        for foo in ${supported_dbs}
        do
                if use ${foo}
                then
                        let multiple_dbs="((multiple_dbs + 1 ))"
                        einfo "Found ${foo} database support in your USE
flags."
                fi
        done
        if [ "${multiple_dbs}" -ge "2" ]
        then
                echo
                ewarn "You have multiple database backends active in your USE
flags."
                ewarn "Will default to MySQL as your dspam database backend."
                ewarn "If you want to build with another database backend; hit
Control-C now."
                ewarn "Change your USE flag -mysql and emerge again."
                echo
                has_version ">=sys-apps/portage-2.0.50" && (
                einfo "It would be best practice to add the set of USE flags
that you use for this"
                einfo "package to the file: /etc/portage/package.use. Example:"
                einfo "\`echo \"mail-filter/dspam -mysql postgres -oci8
-sqlite\" >> /etc/portage/package.use\`"
                einfo "to build dspam with Postgres database as your dspam
backend."
                )
                echo
                ewarn "Waiting 30 seconds before starting..."
                ewarn "(Control-C to abort)..."
                epause 30
        elif [ "${multiple_dbs}" -eq "0" ]
        then
                echo
                ewarn "You need to select at least one database backend in your
USE flags."
                ewarn "Please enable one of the following USE flags:"
                ewarn "  ${supported_dbs}"
                echo
                die "Database support missing"
        fi


Something I never realize to understand is: Why is Robinson's geometric mean
test active in the current DSPAM ebuilds? The README clearly flags this option
as OBSOLETE and not recommended for production builds.


Another thing I would like to be changed is the installation of dspam_stats:
dspam_stats get's installed with "make DESTDIR=${D} install || die". Later the
/usr/bin/dspam executable get's changed to 4755 but /usb/bin/dspam_stats does
not get changed to 4755. Without changing dspam_stats as well to 4755, you will
have hard time to allow the DSPAM CGI to display the statistics for DSPAM.


I would as well like to see the notification messages installed as well. Could
you please add something like this to the ebuild?
        # installs the notification messages
        diropts -m0775 -o dspam -g dspam
        dodir ${HOMEDIR}/txt
        keepdir ${HOMEDIR}/txt
        insinto ${HOMEDIR}/txt
        insopts -m644 -o dspam -g dspam
        for foo in ${S}/txt/*.txt; do
                if [ ! -f "$(basename ${foo})" ]; then
                        doins ${foo}
                fi
        done



Sorry for so much comments on the DSPAM ebuild.


cheers

SteveB


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Hi,
  Thanx for the suggestions.  I've integrated bug#84639 which hopefully fixes your bugs.  Thanx for the suggestions though.