Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 81060 - net-im/skype icons installation cleanup
Summary: net-im/skype icons installation cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Net-im project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-06 18:41 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-02-07 08:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch over current ebuild (skype.patch,992 bytes, patch)
2005-02-06 18:41 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Right patch over current ebuild (skype.patch,1022 bytes, patch)
2005-02-06 18:44 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-06 18:41:01 UTC
Currently skype ebuild installs all the icons at the right place.. but use them in the wrong way: make_desktop_entry is called with a relative path, of the 48x48 icon, with extension.
It also install them in an ugly way creating directories and moving files around.

The attached patch applied over current ebuild installs the icons with insinto/newins calls, and then uses the generic skype iconname to be sure that icon themes could replace it with something custom.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-06 18:41:17 UTC
Created attachment 50592 [details, diff]
Patch over current ebuild
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-06 18:44:19 UTC
Created attachment 50593 [details, diff]
Right patch over current ebuild

Ok so I should remember that if I change something, I should redirect the patch
to file, not on stdout :)
This time it works :)
Comment 3 Gustavo Felisberto (RETIRED) gentoo-dev 2005-02-07 08:57:44 UTC
Ok, sending -r1 to cvs, mixed patch :) I actually like the for lop :)

Thanks for the desktop tip.