Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80401 - links 2.1pre17 released + typo
Summary: links 2.1pre17 released + typo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Seemant Kulleen (RETIRED)
URL: http://atrey.karlin.mff.cuni.cz/~cloc...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-01 16:09 UTC by Alessandro Lepore
Modified: 2005-03-27 10:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild + fixed typo (links-2.1_pre17.ebuild,3.64 KB, text/plain)
2005-03-04 04:21 UTC, Ingo -LaSombra- Hoffmann
Details
Just to make it easy to upload to portage (links-2.1pre17-utf8.diff.bz2,4.56 KB, application/octet-stream)
2005-03-07 04:29 UTC, Ingo -LaSombra- Hoffmann
Details
links-2.1pre17-utf8.diff (links-2.1pre17-utf8.diff,21.55 KB, patch)
2005-03-19 17:50 UTC, Marcelo Goes (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Lepore 2005-02-01 16:09:27 UTC
links 2.1pre16 released
and there is a typo in description: "links is a fast lightweight text tand graphic web-browser"

Reproducible: Always
Steps to Reproduce:
Comment 1 Ingo -LaSombra- Hoffmann 2005-03-04 04:21:52 UTC
Created attachment 52641 [details]
ebuild + fixed typo
Comment 2 Ingo -LaSombra- Hoffmann 2005-03-04 04:22:25 UTC
Alessandro,

There's the new links version, take a look a report?
:)
Comment 3 Alessandro Lepore 2005-03-04 08:36:47 UTC
seems ok, but USE=unicode doesn't work:
the patch doesn't applies (and also needs to be renamed to pre17)
Comment 4 Ingo -LaSombra- Hoffmann 2005-03-07 04:29:14 UTC
Created attachment 52843 [details]
Just to make it easy to upload to portage
Comment 5 Ingo -LaSombra- Hoffmann 2005-03-07 04:29:43 UTC
Hope this hit portage soon
:)
Comment 6 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-14 08:44:13 UTC
Ingo, I really prefer text files a attachments, to be honest.

Thanks :)
Comment 7 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-15 12:44:43 UTC
Actually, the patch fails, so I need to fix0r it up to work with pre17
Comment 8 Marcelo Goes (RETIRED) gentoo-dev 2005-03-19 17:50:03 UTC
Created attachment 53901 [details, diff]
links-2.1pre17-utf8.diff

I ported the current pre15 patch to pre17. It compiled and worked fine here
just renaming the current ebuild.

I would just like to call attention to terminal_options() in menu.c;
mem_alloc() was replaced with mem_calloc() and I'm not sure if just replacing
12 with 14 cuts it.
Comment 9 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-22 08:09:17 UTC
marcelo I have no idea -- but what exactly do you mean by "replacing 12 with 14 cuts it"?  Where is the replacement, and what is it cutting?
Comment 10 Marcelo Goes (RETIRED) gentoo-dev 2005-03-22 12:48:03 UTC
Seemant, using this:

-	d = mem_calloc(sizeof(struct dialog) + 12 * sizeof(struct dialog_item));
+	d = mem_calloc(sizeof(struct dialog) + 14 * sizeof(struct dialog_item));

instead of:

-	if (!(d = mem_alloc(sizeof(struct dialog) + 12 * sizeof(struct dialog_item)))) return;
-	memset(d, 0, sizeof(struct dialog) + 12 * sizeof(struct dialog_item));
+ 	if (!(d = mem_alloc(sizeof(struct dialog) + 14 * sizeof(struct dialog_item)))) return;
+ 	memset(d, 0, sizeof(struct dialog) + 14 * sizeof(struct dialog_item));

It's not actually "cutting" anything, that was just some poor slang for "works".
Comment 11 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-23 13:51:46 UTC
Marcelo, let's talk on irc, if you would.  I'm online usually from 7am to 5pm in the EST time zone.  In the meantime, I've bzipped the patch and sent it to our mirrors.  Once it reaches those, I'll check in the version bump. Thanks for your patience everyone
Comment 12 Seemant Kulleen (RETIRED) gentoo-dev 2005-03-25 05:55:51 UTC
pre17 in portage with vanquirius as its new maintainer.  Ingo, please file future links bugs to him now. Thanks for all your help over the time I've been looking after this package.
Comment 13 Ingo -LaSombra- Hoffmann 2005-03-27 10:24:58 UTC
Hey Seemant,

We're here to help you, developers, to make Gentoo as great as it should be.
:)
Comment 14 Ingo -LaSombra- Hoffmann 2005-03-27 10:25:26 UTC
Hey Seemant,

We're here to help you, developers, to make Gentoo as great as it should be.
:)