Bugzilla Bug 79692

This version includes my patch for ALSA support. :)
It also adds support to switch on/off display mirroring using hotkeys, but I haven't tried this feature, not sure how/if it will work on my iBook G4.

Anybody with a working laptop is willing to test?

Tests okay here.  I had to change my config to reflect the ALSA changes (I was
getting segfaults with my old config), but that was probably user error.

Joe,

If you are getting segfaults, can you writeup a report for me or Matthias? A problem with the config file should not be causing a segfault.

To clarify my last comment: It is probably true that the config file is causing
the segfault, but we consider that to be a bug in the program, and would like
to fix it.

Created an attachment (id=49783) [edit]
Config that causes segfaults

Okay, here is the config that causes segfaults here.  I was using this config
sucessfully on previous versions of pbbuttonsd.  Switching the config to the
ALSA settings that are commented out stops the segfaults.  I do use ALSA and
not OSS, but I would think that OSS should still work since I have OSS
emulation enabled.  If I get a chance, I'll try and look at it.

I haven't had a chance to test this patch against Joe's config, but it may be
the same issue reported by debian:

http://sourceforge.net/mailarchive/forum.php?thread_id=6430700&forum_id=40677

The patch looks like:
--- pbbuttonsd-0.6.7/src/module_alsamixer.c     2005-01-24 19:50:37.000000000
+0100
+++ pbbuttonsd-0.6.7-new/src/module_alsamixer.c 2005-01-27 16:24:18.000000000
+0100
@@ -434,9 +434,15 @@
 alsamixer_exit ()
 {
        struct moddata_alsamixer *base = &modbase_alsamixer;
-       free (base->elements);
-       base->elements = NULL;
-       snd_mixer_free (base->mixer);
+
+       if (base->elements) {
+               free (base->elements);
+               base->elements = NULL;
+       }
+
+       if (base->mixer)
+               snd_mixer_free (base->mixer);
+       
        base->init_complete = 0;
        return 0;
 }

Okay, the patch supplied fixed the problem, I've added the new version of
pbbuttonsd to CVS as ~ppc, along with the patch.