Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77482 - smbldap-populate script distribuited with samba typo
Summary: smbldap-populate script distribuited with samba typo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on: 85048
Blocks:
  Show dependency tree
 
Reported: 2005-01-11 00:53 UTC by samuele assirelli
Modified: 2005-07-08 14:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description samuele assirelli 2005-01-11 00:53:20 UTC
ther is a typo in smbldap-populate script ditribuited with samba. there is a duplicated -g switch and no -b switch

Reproducible: Always
Steps to Reproduce:
1. run the smbldap-populate with -u and -g switches
./smbldap-populate -u 2000 -g 2000 -b Guest


Actual Results:  
an account with uid=2000 is created

Expected Results:  
an account with uid=Guest is created

this simple patch will solve the problem:

--- smbldap-populate    2004-11-13 18:46:41.704237272 +0100
+++ smbldap-populate    2004-11-13 18:48:04.940583424 +0100
@@ -55,7 +55,7 @@
   print "  -u uidNumber first uidNumber to allocate (default: 1000)\n";
   print "  -g gidNumber first uidNumber to allocate (default: 1000)\n";
   print "  -a user     administrator login name (default: Administrator)\n";
-  print "  -g user     guest login name (default: nobody)\n";
+  print "  -b user     guest login name (default: nobody)\n";
   print "  -e file     export ldif file\n";
   print "  -i file     import ldif file\n";
   print "  -?          show this help message\n";
@@ -84,7 +84,7 @@
   $adminName = "Administrator";
 }

-my $guestName = $Options{'g'};
+my $guestName = $Options{'b'};
 if (!defined($guestName)) {
   $guestName = "nobody";
 }


Portage 2.0.51-r3 (default-linux/x86/2004.3, gcc-3.3.4, glibc-2.3.4.20040808-r1,
2.6.9 i686)
=================================================================
System uname: 2.6.9 i686 Celeron (Mendocino)
Gentoo Base System version 1.4.16
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.90.0.1.1-r3
Headers:  sys-kernel/linux-headers-2.4.21-r1
Libtools: sys-devel/libtool-1.5.2-r7
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/share/config /var/qmail/alias /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=i686 -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig buildpkg ccache distlocks fixpackages sandbox
sfperms"
GENTOO_MIRRORS="http://gentoo.osuosl.org
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 apache2 innodb kerberos qmail winbind"
Comment 1 Chris Smith 2005-02-16 14:24:09 UTC
I believe this is fixed in smbldap-tools-0.8.7 available from idealx.org.

There probably should be a way to update smbldap-tools independently from samba releases.

idealx also mentions in the changelog dated 2005-06-01:
new location /opt/IDEALX and /etc/opt/IDEALX/ (instead of /usr/local and /etc) to conform to FHS/LS

Also the scripts definitely look for smbldap.conf in /etc/opt/IDEALX/smbldap-tools/ yet the ebuild places it in /etc/smbldap-tools/.
Comment 2 Christian Andreetta (RETIRED) gentoo-dev 2005-03-25 04:40:40 UTC
fixed with new versions of samba, which leave smbldap-tools as a separate package