First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 76736
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Shell Tools Herd Bugs <shell-tools@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Stefan Kamphausen <mail@skamphausen.de>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
cdargs-1.31.ebuild cdargs-1.31.ebuild text/plain Stefan Kamphausen 2005-01-05 00:24 0000 1.50 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 76736 depends on: Show dependency tree
Show dependency graph
Bug 76736 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)







View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2005-01-05 00:22 0000
Dear Gentoo Developers and Users,

please find attached my first try at an ebuild, an ebuild for (my own) cdargs program.

CDargs provides bookmarks and a browser for the shells built-in cd-command.  Bash users will also find the possibility to copy and move files to locations stored in their bookmarks.

Since this is my first ebuild it surely needs the keen eye of an experienced gentoo developer :-)

I suggest app-shells/cdargs as the portage directory.

Find cdargs at http://www.skamphausen.de/software/cdargs

Kind Regards
Stefan

------- Comment #1 From Stefan Kamphausen 2005-01-05 00:24:57 0000 -------
Created an attachment (id=47685) [edit]
cdargs-1.31.ebuild

------- Comment #2 From Ciaran McCreesh 2005-01-06 16:56:43 0000 -------
Hm, when did this one come in? I've got an ebuild in my overlay for this. It's
basically the same but doesn't violate all the whitespace rules :) No need for
einstall either, make DESTDIR=${D} seems to be fine.

------- Comment #3 From Stefan Kamphausen 2005-01-06 23:14:52 0000 -------
Hi, 

I submitted this ebuild on 2005-01-05 because I wanted cdargs to appear in gentoo but didn't find any ebuild for it.  Thus I wrote it myself, not knowing about whitespace rules (is it indention?) and that einstall should be avoided.  

Regards
Stefan

------- Comment #4 From Aaron Walker (RETIRED) 2005-01-07 02:29:20 0000 -------
Stefan, don't worry about it.  It was actually a damn good attempt at a first
ebuild.

Just to further explain on what ciaranm said, there were a few whitespace
errors (I think there was one line with a trailing char) and yes, the
indentation (ebuilds should be indented 4 chars).  As far as einstall goes, it
is ok to use it but only in cases where the Makefile does not support the
DESTDIR variable.  I'm pretty sure that any Makefile produced by GNU autotools
supports it, however (unless upstream adds local hooks that don't respect
DESTDIR).

I've just committed it as app-misc/cdargs, as I feel that is more appropriate
than app-shells.  In addition to the small fixes already mentioned, I also
slightly changed the wording of the pkg_postinst message.

Thanks.

------- Comment #5 From Stefan Kamphausen 2005-01-07 02:33:50 0000 -------
Cool :-)

Thanks and Regards
Stefan

First Last Prev Next    No search results available      Search page      Enter new bug