Bugzilla Bug 76072

I've tried to get the path to work on the existing
games-emulation/generator-0.35, but failed. So I made an ebuild for the cbiere
version which is faster and compiles on my system (generator-0.35 doesn't)

Created an attachment (id=47153) [details]
ebuild for cbiere patched generator-0.35

This ebuild doesn't work for me.  It contains a syntax error somewhere.  I am
not familiar with ebuild syntax.

Error output:

gundam generator # emerge games-emulation/generator
Calculating dependencies  /usr/lib/portage/bin/ebuild.sh:
/usr/portage/games-emulation/generator/generator-0.35.ebuild: line 62: syntax
error near unexpected token `fi'
/usr/lib/portage/bin/ebuild.sh:
/usr/portage/games-emulation/generator/generator-0.35.ebuild: line 62: `       
        fi'

!!! ERROR: games-emulation/generator-0.35 failed.
!!! Function , Line 1686, Exitcode 1
!!! error sourcing ebuild
!!! If you need support, post the topmost build error, NOT this status message.


aux_get(): (0) Error in games-emulation/generator-0.35 ebuild. (1)
               Check for syntax error or corruption in the ebuild. (--debug)


!!! All ebuilds that could satisfy "games-emulation/generator" have been
masked.
!!! One of the following masked packages is required to complete your request:
/usr/lib/portage/bin/ebuild.sh:
/usr/portage/games-emulation/generator/generator-0.35.ebuild: line 62: syntax
error near unexpected token `fi'
/usr/lib/portage/bin/ebuild.sh:
/usr/portage/games-emulation/generator/generator-0.35.ebuild: line 62: `       
        fi'

!!! ERROR: games-emulation/generator-0.35 failed.
!!! Function , Line 1686, Exitcode 1
!!! error sourcing ebuild
!!! If you need support, post the topmost build error, NOT this status message.


aux_get(): (0) Error in games-emulation/generator-0.35 ebuild. (1)
               Check for syntax error or corruption in the ebuild. (--debug)



!!! Problem in games-emulation/generator dependencies.
!!!  exceptions
gundam generator #


Here's the fragment of code where it's having a problem:

    59          for mygui in ${myguis}; do
    60                  if [ -f Makefile ] ; then--without-gcc
    61                          make clean
    62                  fi
    63                  egamesconf \
    64                          ${myconf} \
    65                          --with-${mygui} || die
    66                  emake -j1 || die "building ${mygui}"
    67                  mv main/generator-${mygui} my-bins/
    68          done

The fix :

    59          for mygui in ${myguis}; do
    60                  if [ -f Makefile ] ; then
    61                          make clean
    62                  fi
    63                  egamesconf \
    64                          ${myconf} \
    65                          --with-${mygui} || die
    66                  emake -j1 || die "building ${mygui}"
    67                  mv main/generator-${mygui} my-bins/
    68          done

On line 0, remove the --without-gcc

Please confirm this bug report, the old version doesn't compile on recent gcc,
and the official maintainer suggests this new version for linux/gtk (check
http://www.squish.net/generator/).

It's working quite well on my amd64 laptop, with sdl audio and all the goodies
from this patch

Created an attachment (id=54720) [details]
My ebuild for 0.35-r1

Not many differences with the first one, but working on my system

Fixed in CVS.  There's no point in putting a bug into an UNCONFIRMED state. 
Simply filing it is good enough.

This ebuild works for me, however it points to an older version of the patch.
http://www.ghostwhitecrab.com/generator/generator-0.35-cbiere-r2.tar.bz2 is the
current release. It fixes compiling w/GCC4, among other useful things. It would
be preferable for the ebuild to use it instead of the older version.

This bug was for having the version added.  Please file a new bug if you think
it should be adjusted.

Thanks

Bug 129616 is the new one.