First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 73527
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Games <games@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Kristiaan Lenaerts <kristiaan.lenaerts@gmail.com>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
scorched3d-38.ebuild modified ebuild text/plain Kristiaan Lenaerts 2004-12-06 00:02 0000 1.16 KB Details
scorched3d-38.patch patch patch basic 2004-12-08 00:29 0000 264 bytes Details | Diff
scorched3d-38.alt.patch patch alt patch basic 2004-12-08 00:32 0000 565 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 73527 depends on: Show dependency tree
Bug 73527 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2004-12-06 00:01 0000
The ebuild for scorched3d uses a crude way to check if the right version of
wxGTK is available, and if the right version is installed. If the unicode
version is installed, the installation will not complete. However, the new
wxwidgets eclass makes it possible to use all three versions side by side. The
bug report in the link describes the solution, and how to adapt ebuilds to
using it.

I adapted the 38 ebuild to use this.

Reproducible: Always
Steps to Reproduce:

------- Comment #1 From Kristiaan Lenaerts 2004-12-06 00:02:26 0000 -------
Created an attachment (id=45365) [details]
modified ebuild

------- Comment #2 From Mr. Bones. 2004-12-06 00:42:23 0000 -------
modified the ebuild in CVS.  Thanks for pointing that out.  The checking still
needs to be in pkg_setup though.  Check the current ebuild in CVS and make sure
I didn't mess something up.  Thanks.

------- Comment #3 From Kristiaan Lenaerts 2004-12-06 02:03:06 0000 -------
When testing the new ebuild, I noticed that the test does nothing. I have all 3
versions of wxGTK installed (gtk, gkt2 and gtk2u). Although I get the comment
"* Using /usr/bin/wxgtk2-2.4-config", it is the gtk2u version that is included
while compiling (the default version?).

Apparantly the options that "need-wxwidgets gtk2" sets are not used when set in
pkg_setup. Maybe it is a bug in in wxwidgets.eclass, but it only works when
that section is right before the configure. It looks like the eclass only sets
an environment variable (WX_CONFIG), and it stays local to pkg_setup, but
egamesconf is done in src_compile...

I'm not sure what the right way is for solving this.

------- Comment #4 From basic 2004-12-08 00:29:00 0000 -------
Created an attachment (id=45497) [details]
patch

here's a patch, just call pkg_setup or ... (another patch coming up)

------- Comment #5 From basic 2004-12-08 00:32:36 0000 -------
Created an attachment (id=45498) [details]
patch alt

move the check to global ... or if you don't like this or the earlier patch,
make a copy of the check in src_compile

------- Comment #6 From Mr. Bones. 2004-12-08 00:38:09 0000 -------
both of those look nasty to me.

------- Comment #7 From Mr. Bones. 2004-12-08 00:49:12 0000 -------
Just so we're clear.  The claim is, if I put the check in the src_compile
function, it works.  If it's in the pkg_setup, then things don't work.  Is that
correct?

I think I see the problem but I want to make sure I'm understanding the failure
condition.

------- Comment #8 From basic 2004-12-08 01:19:18 0000 -------
> both of those look nasty to me.
another alternative is to have the code checking for wxWidget in a seperate function and have both pkg_setup and src_compile call it

> Just so we're clear.  The claim is, if I put the check in the src_compile function, it works.  If it's in the pkg_setup, then things don't work.  Is that correct?
> I think I see the problem but I want to make sure I'm understanding the failure condition.
yes, the problem seems to be that enviroment variables declared in pkg_setup is not preserved.


------- Comment #9 From Mr. Bones. 2004-12-08 22:16:50 0000 -------
ok, it's ugly but it's in there.  Give the latest ebuild a shot and reopen if
it's still a problem.

This is a bug with portage where portage doesn't export the variables that need
to be exported when carrying variables over from one function to another.

------- Comment #10 From Kristiaan Lenaerts 2004-12-09 01:32:16 0000 -------
Just emerged it, it works fine for me, thanks :-)

First Last Prev Next    No search results available      Search page      Enter new bug