Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 69407 - bash-3.0-r7 has problem with wide char
Summary: bash-3.0-r7 has problem with wide char
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 96012 108936 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-29 07:29 UTC by S.Caglar Onur
Modified: 2005-10-15 19:43 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bash-3.0-utf-8.patch (bash-3.0-utf-8.patch,1.48 KB, patch)
2004-10-30 06:39 UTC, S.Caglar Onur
Details | Diff
bashrc.patch (bash.patch,672 bytes, patch)
2004-11-06 13:23 UTC, S.Caglar Onur
Details | Diff
bash-3.0-prompt.patch (bash-3.0-prompt.patch,667 bytes, patch)
2004-11-08 02:32 UTC, S.Caglar Onur
Details | Diff
bash-3.0-invisible.patch (bash-3.0-invisible.patch,621 bytes, patch)
2005-01-12 10:03 UTC, S.Caglar Onur
Details | Diff
bash-3.0-update-multibyte-ifs.patch (bash-3.0-update-multibyte-ifs.patch,5.47 KB, patch)
2005-01-12 10:03 UTC, S.Caglar Onur
Details | Diff
bash-3.0-random.patch (bash-3.0-random.patch,2.20 KB, patch)
2005-01-12 10:04 UTC, S.Caglar Onur
Details | Diff
bash-3.0-privmode.patch (bash-3.0-privmode.patch,446 bytes, patch)
2005-01-12 10:04 UTC, S.Caglar Onur
Details | Diff
bash-3.0-command-not-found.patch (bash-3.0-command-not-found.patch,2.12 KB, patch)
2005-01-12 10:04 UTC, S.Caglar Onur
Details | Diff
bash-3.0-histtimeformat.patch (bash-3.0-histtimeformat.patch,2.51 KB, patch)
2005-01-12 10:04 UTC, S.Caglar Onur
Details | Diff
bash-3.0-rl-del-backspace-policy.patch (bash-3.0-rl-del-backspace-policy.patch,929 bytes, patch)
2005-01-12 10:05 UTC, S.Caglar Onur
Details | Diff
bash-3.0-rl-header.patch (bash-3.0-rl-header.patch,327 bytes, patch)
2005-01-12 10:05 UTC, S.Caglar Onur
Details | Diff
bash-3.0-rl-setenv.patch (bash-3.0-rl-setenv.patch,317 bytes, patch)
2005-01-12 10:05 UTC, S.Caglar Onur
Details | Diff
bash-3.0-r7.ebuild.diff (bash-3.0-r7.diff,1.02 KB, patch)
2005-01-12 10:06 UTC, S.Caglar Onur
Details | Diff
bash-3.0-r11.ebuild.patch (diff,1.55 KB, patch)
2005-05-17 05:44 UTC, S.Caglar Onur
Details | Diff
bash.tar.gz (bash.tar.gz,37.62 KB, application/octet-stream)
2005-07-14 10:42 UTC, S.Caglar Onur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description S.Caglar Onur 2004-10-29 07:29:04 UTC
Bash has some problems with wide chars. Readline functions of bash maybe cause this problem. If user wants to edit a lien with non-wide chars with wide-char's then, line turn into garbage and wide-chars written over them. In tr_TR.UTF-8 locale problem can demonstrate like this;

$ echo "abc"
abc
< up arrow >
$ echo "abc"|
<left arrow twice>
$ echo "ab|c"
< enter UTF-8 char like [ 
Comment 1 S.Caglar Onur 2004-10-29 07:29:04 UTC
Bash has some problems with wide chars. Readline functions of bash maybe cause this problem. If user wants to edit a lien with non-wide chars with wide-char's then, line turn into garbage and wide-chars written over them. In tr_TR.UTF-8 locale problem can demonstrate like this;

$ echo "abc"
abc
< up arrow >
$ echo "abc"|
<left arrow twice>
$ echo "ab|c"
< enter UTF-8 char like [ ç,ö,?,?,ü in Turkish locale ] >
Comment 2 S.Caglar Onur 2004-10-30 06:39:33 UTC
Created attachment 42907 [details, diff]
bash-3.0-utf-8.patch

I found another in bash history file.  The bug in
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=83331 also exists in bash
3.x series. So i convert this patch for bash 3.x series
Comment 3 S.Caglar Onur 2004-11-05 16:45:05 UTC
This problem description is same as in bash's offical patch "Bash30-011". The patch cannot solve problem for at least tr_TR.UTF-8 locale. 
Comment 4 S.Caglar Onur 2004-11-06 13:23:22 UTC
Created attachment 43427 [details, diff]
bashrc.patch

This patch solves the problem ( with utf-8 patch ). Problem is colors of prompt
:). I'dont know why but if i apply this patch, wide-chars can be used without
anyproblem. Otherwise there all overwritten each other.
Comment 5 S.Caglar Onur 2004-11-08 02:32:35 UTC
Created attachment 43522 [details, diff]
bash-3.0-prompt.patch

This patch also solves the prompt problem
Comment 6 S.Caglar Onur 2004-11-18 12:08:37 UTC
it's a utf-8 problem so i assigned it to utf-8 rather than coreutils team [ hope im not doing anything wrong ]. https://svn.uludag.org.tr/paketler/trunk/app-shells/bash/ has the working ebuild and patches [ some from debian ]
Comment 7 Aron Griffis (RETIRED) gentoo-dev 2005-01-12 08:51:45 UTC
Fetching the patches from your subversion repo is not easy... wget just returns an empty file.

Could you please attach the patches and updated ebuild here?
Comment 8 S.Caglar Onur 2005-01-12 10:03:32 UTC
Created attachment 48318 [details, diff]
bash-3.0-invisible.patch
Comment 9 S.Caglar Onur 2005-01-12 10:03:52 UTC
Created attachment 48319 [details, diff]
bash-3.0-update-multibyte-ifs.patch
Comment 10 S.Caglar Onur 2005-01-12 10:04:13 UTC
Created attachment 48320 [details, diff]
bash-3.0-random.patch
Comment 11 S.Caglar Onur 2005-01-12 10:04:29 UTC
Created attachment 48321 [details, diff]
bash-3.0-privmode.patch
Comment 12 S.Caglar Onur 2005-01-12 10:04:44 UTC
Created attachment 48322 [details, diff]
bash-3.0-command-not-found.patch
Comment 13 S.Caglar Onur 2005-01-12 10:04:59 UTC
Created attachment 48323 [details, diff]
bash-3.0-histtimeformat.patch
Comment 14 S.Caglar Onur 2005-01-12 10:05:12 UTC
Created attachment 48324 [details, diff]
bash-3.0-rl-del-backspace-policy.patch
Comment 15 S.Caglar Onur 2005-01-12 10:05:25 UTC
Created attachment 48325 [details, diff]
bash-3.0-rl-header.patch
Comment 16 S.Caglar Onur 2005-01-12 10:05:40 UTC
Created attachment 48326 [details, diff]
bash-3.0-rl-setenv.patch
Comment 17 S.Caglar Onur 2005-01-12 10:06:29 UTC
Created attachment 48328 [details, diff]
bash-3.0-r7.ebuild.diff

Modifed ebuild with attached patches...
Comment 18 SpanKY gentoo-dev 2005-02-09 18:50:42 UTC
have you sent these patches upstream to the bash maintainer ?
Comment 19 S.Caglar Onur 2005-02-11 10:10:04 UTC
No :), because some of them are from debian, some of them from Suse. So i think they send these to bash. The only part i wrote can be seen in bash-3.0-r7.ebuild.diff. Also, they are not tested well in ISO modes [ we only use UTF-8 ], so im not sure they are ok or not.
Comment 20 Markus Rothe (RETIRED) gentoo-dev 2005-03-13 07:04:10 UTC
any progress on this? bash-3.0-r8 has still some wired behaviour with utf-8...
Comment 21 S.Caglar Onur 2005-03-14 05:58:29 UTC
Nope, New offical patches broke our utf-8 support so we throw away the new offical patches until we solve the issue. Pardus Linux still use attached ebuild and patches for utf-8 compatibility. Without them console is useless.

Also &#305;'ve got no response from Bash Developers. So still i dont know what are they think and what cause these problems? :(
Comment 22 Heinrich Wendel (RETIRED) gentoo-dev 2005-05-16 07:51:13 UTC
so let's ask again ;) any progress? what can we currently do?
Comment 23 S.Caglar Onur 2005-05-16 09:28:42 UTC
I'm very busy with other things sorry :), let me do this;

in one week, i'll grap newest bash with offical patches and merge with these. And if i can solve the issue will report here.

After that of course if u accept, you report to bash-developers so they may answer :))
Comment 24 S.Caglar Onur 2005-05-17 05:43:26 UTC
Heh, i'll write a book titled as "Why i hate bash?" :)

I found some time for bash today, and also want to update this for our distro.
As a result i merged debian's, gentoo's and suse's patches with mine and seems
there is no utf-8 problem at all. Also some other potential problem solved ( i
hope ). You can grap it from ( i don't want to attach all patches to bugzilla,
after your test if u agree i'll attach );

$ svn co https://svn.uludag.org.tr/paketler/trunk/app-shells/bash/
Comment 25 S.Caglar Onur 2005-05-17 05:44:16 UTC
Created attachment 59114 [details, diff]
bash-3.0-r11.ebuild.patch

The latest ebuild without patches just show the differences between this and
offical gentoo one...
Comment 26 SpanKY gentoo-dev 2005-06-24 14:42:11 UTC
*** Bug 96012 has been marked as a duplicate of this bug. ***
Comment 27 SpanKY gentoo-dev 2005-07-13 20:26:10 UTC
talked to upstream and they pretty much have all the relevant fixes here so the
next version of bash should be OK ...

the question is what to do with our current 3.0
Comment 28 S.Caglar Onur 2005-07-14 10:41:18 UTC
(In reply to comment #26)
> talked to upstream and they pretty much have all the relevant fixes here so the
> next version of bash should be OK ...

Good news :)

> the question is what to do with our current 3.0

I sync latest bash in portage [r12] with these patches. 

The only differences is SUSE's utf-8 patch removed {because there is a problem
with this patch} and mine added [
http://bugs.gentoo.org/attachment.cgi?id=42907&action=view ], attached tarball
has all patches and synced ebuild.

After you test this tarball, if u accept, i suggest use this in current situation.
Comment 29 S.Caglar Onur 2005-07-14 10:42:14 UTC
Created attachment 63407 [details]
bash.tar.gz

tarball has all patches and modified ebuild...
Comment 30 SpanKY gentoo-dev 2005-10-11 17:00:30 UTC
*** Bug 108936 has been marked as a duplicate of this bug. ***
Comment 31 SpanKY gentoo-dev 2005-10-15 19:43:16 UTC
ok, i added the two patches mentioned in Bug 108936 only when USE=unicode since
they are clearly not the correct fix, but they do fix the bug for unicode systems

this is all in bash-3.0-r13