Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 691904 - media-tv/mythtv-29.1-r1 : imagemetadata.cpp:303:19: error: Error in namespace Exiv2 does not name a type
Summary: media-tv/mythtv-29.1-r1 : imagemetadata.cpp:303:19: error: Error in namespace...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 688566
  Show dependency tree
 
Reported: 2019-08-10 14:11 UTC by Toralf Förster
Modified: 2019-08-14 11:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.85 KB, text/plain)
2019-08-10 14:11 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,100.80 KB, text/plain)
2019-08-10 14:11 UTC, Toralf Förster
Details
environment (environment,169.59 KB, text/plain)
2019-08-10 14:11 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.02 KB, application/x-bzip)
2019-08-10 14:11 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,645 bytes, application/x-bzip)
2019-08-10 14:11 UTC, Toralf Förster
Details
media-tv:mythtv-29.1-r1:20190810-115020.log.bz2 (media-tv:mythtv-29.1-r1:20190810-115020.log.bz2,45.02 KB, application/x-bzip)
2019-08-10 14:11 UTC, Toralf Förster
Details
mythtv-exiv2-fix (file_691904.txt,513 bytes, patch)
2019-08-14 10:56 UTC, Amel Hodzic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-08-10 14:11:27 UTC
imagemetadata.cpp: In constructor ‘PictureMetaData::PictureMetaData(const QString&)’:
imagemetadata.cpp:303:19: error: ‘Error’ in namespace ‘Exiv2’ does not name a type
  303 |     catch (Exiv2::Error &e)
      |                   ^~~~~
In file included from imagemetadata.cpp:3:

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-abi32+64-20190807-151919

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.1.0 *

Available Python interpreters, in order of preference:
  [1]   python3.6
  [2]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.36.0 *
java-config:
The following VMs are available for generation-2:
1)	IcedTea JDK 3.13.0 [icedtea-8]
*)	IcedTea JDK 3.12.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-8 
  [2]   icedtea-bin-8  system-vm

emerge -qpvO media-tv/mythtv
[ebuild  N    ] media-tv/mythtv-29.1-r1  USE="alsa dvd hls python systemd theora vorbis wrapper xml xvid (-altivec) -autostart -bluray -cec -crystalhd -debug -dvb -egl -fftw -ieee1394 -jack -lcd -libass -lirc -mythlogserver -perl -pulseaudio -vaapi -vdpau -xmltv -zeroconf" INPUT_DEVICES="-joystick" PYTHON_TARGETS="python2_7"
Comment 1 Toralf Förster gentoo-dev 2019-08-10 14:11:30 UTC
Created attachment 586492 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-08-10 14:11:33 UTC
Created attachment 586494 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2019-08-10 14:11:36 UTC
Created attachment 586496 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2019-08-10 14:11:38 UTC
Created attachment 586498 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2019-08-10 14:11:41 UTC
Created attachment 586500 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2019-08-10 14:11:44 UTC
Created attachment 586502 [details]
media-tv:mythtv-29.1-r1:20190810-115020.log.bz2
Comment 7 Andreas Sturmlechner gentoo-dev 2019-08-10 14:37:45 UTC
Not a gcc issue. mythtv/libs/libmythmetadata/imagemetadata.cpp has this:

// libexiv2 for Exif metadata
//#include <exiv2/exiv2.hpp>
// Note: Older versions of Exiv2 don't have the exiv2.hpp include
// file.  Using image.hpp instead seems to work.
#ifdef _MSC_VER
#include <exiv2/src/image.hpp>
#else
#include <exiv2/image.hpp>
#endif


Contrary to that comment, image.hpp does not work, and exiv2/exiv2.hpp should be used instead.
Comment 8 Amel Hodzic 2019-08-14 06:22:47 UTC
Yeah, I'm not sure how far back one has to go for that comment to be true.  It seems that exiv2/exiv2.hpp was included 9 years ago first.  
https://github.com/Exiv2/exiv2/blame/19e0693920b687ee789c37c4068e829e083d3838/include/exiv2/exiv2.hpp
Comment 9 Andreas Sturmlechner gentoo-dev 2019-08-14 07:49:47 UTC
And can you confirm that uncommenting this header makes mythtv then build?
Comment 10 Amel Hodzic 2019-08-14 10:56:59 UTC
Created attachment 586784 [details, diff]
mythtv-exiv2-fix

I can confirm that the proposal resolves build errors.  I'm including the patch here; it can be added into a revbump commit for media-tv/mythtv.  


$ grep -n PATCH media-tv/mythtv/mythtv-29.1-r2.ebuild 

140:PATCHES="${FILESDIR}/${PN}-exiv2-fix"


I would need to clone the gentoo git tree in order to open a pull request.  If that's necessary, I'll do so.  However, if someone else is able to apply the patch into the tree, it's preferable.
Comment 11 Larry the Git Cow gentoo-dev 2019-08-14 11:15:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6efb1db19f9073bfd64c4a00e99fde85b05e9e0

commit c6efb1db19f9073bfd64c4a00e99fde85b05e9e0
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2019-08-14 11:12:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-08-14 11:14:42 +0000

    media-tv/mythtv: Fix build with >=media-libs/exiv2-0.27.1
    
    Thanks-to: Amel Hodzic <ilmostro7@gmail.com>
    Closes: https://bugs.gentoo.org/691904
    Package-Manager: Portage-2.3.71, Repoman-2.3.17
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../mythtv/files/mythtv-29.1-exiv2-0.27.1.patch     | 21 +++++++++++++++++++++
 media-tv/mythtv/mythtv-29.1-r1.ebuild               |  2 ++
 2 files changed, 23 insertions(+)