Bugzilla Bug 67794

ace fails to compile due to bad function definition in games/solitaire.c.

games/solitaire.c patch and ebuild patch attached.

Reproducible: Always
Steps to Reproduce:
1. emerge games-board/ace
2.
3.

Actual Results:  
gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE
STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"ace\" -DVERSION=\"1.2\" -DSTDC
HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STR
NG_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H
1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TIME_H=1 -DTIM
_WITH_SYS_TIME=1 -DHAVE_UTIME_NULL=1 -DHAVE_GETTIMEOFDAY=1 -DHAVE_MKDIR=1 -DHAV
_STRDUP=1 -DHAVE_STRSTR=1  -I. -I.  -I./../lib -I/usr/X11R6/include     -O3 -ma
ch=i586 -mmmx -pipe -fomit-frame-pointer -ffast-math -c solitaire-help.c
solitaire.c:342: error: conflicting types for 'check_for_end_of_game'
solitaire.c:171: error: previous implicit declaration of 'check_for_end_of_game
 was here
solitaire.c: In function `double_click':
solitaire.c:424: warning: comparison between pointer and integer
make[1]: *** [solitaire.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/ace-1.2-r1/work/ace-1.2/games'
make: *** [all-recursive] Error 1

!!! ERROR: games-board/ace-1.2-r1 failed.
!!! Function src_compile, Line 31, Exitcode 2
!!! emake died (first pass)
!!! If you need support, post the topmost build error, NOT this status message


Expected Results:  
>>> games-board/ace-1.2-r1 merged.

Created an attachment (id=41971) [edit]
games/solitaire.c patch

Created an attachment (id=41972) [edit]
ebuild patch

Can I see your emerge --info please.

Happened on two computers, both gcc 3.4 (and what looks from the c file, it was
just an ISO violation).


1) emerge info:
Portage 2.0.51_rc7 (default-x86-2004.2, gcc-3.4.2, glibc-2.3.4.20040808-r1,
2.6.8-gentoo-r6 i686)
=================================================================
System uname: 2.6.8-gentoo-r6 i686 Intel(R) Pentium(R) 4 CPU 2.80GHz
Gentoo Base System version 1.5.3
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2
Headers:  sys-kernel/linux-headers-2.4.22
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=i586 -mmmx -pipe -fomit-frame-pointer -ffast-math"
CHOST="i586-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=i586 -mmmx -pipe -fomit-frame-pointer -ffast-math"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs buildpkg distlocks fixpackages sandbox"
GENTOO_MIRRORS="http://gentoo.osuosl.org/ http://adelie.polymtl.ca/
ftp://cs.ubishops.ca/pub/gentoo ftp://sunsite.ualberta.ca/pub/unix/Linux/
gentoo/ ftp://gentoo.risq.qc.ca/ http://mirrors.tds.net/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/local/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X alsa apm avi berkdb bitmap-fonts crypt cups dillo encode f77 foomaticdb
gdbm gif gtk gtk2 imlib jpeg libg++ libwww mad mikmod mmx 
motif mpeg ncurses nls oggvorbis oss pam pdflib perl png pwdb python qt
quicktime readline sdl sftplogging spell ssl svga tcpd tiff truetype 
trusted unicode x86 xml2 xmms xprint xv zlib"

2) emerge info:
Portage 2.0.51_rc9 (default-x86-2004.0, gcc-3.4.2, glibc-2.3.4.20041006-r0, 2.
9-rc4 i686)
=================================================================
System uname: 2.6.9-rc4 i686 AMD Athlon(TM) XP 2400+
Gentoo Base System version 1.5.3
distcc 2.18 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disable
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2-r1
Headers:  sys-kernel/linux-headers-2.4.22
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -m3dnow -mmmx -msse -O3 -pipe -fomit-frame-pointer -m
math=sse,387 -ffast-math"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3
/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown
usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/s
re/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/g
eric/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/q
il/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -m3dnow -mmmx -msse -O3 -pipe -fomit-frame-pointer 
fpmath=sse,387 -ffast-math"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distlocks sandbox"
GENTOO_MIRRORS="http://mirrors.tds.net/gentoo http://linux.rz.ruhr-uni-bochum.
/download/gentoo-mirror/ http://ftp.easynet.nl/mirror/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portagedev"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex X aalib alsa apm avi berkdb bitmap-fonts cdr crypt dga dill
dv dvd encode f77 faad fbcon foomaticdb gdbm gif gpm gtk gtk2 guile imlib java
avascript jit jpeg libcaca libg++ libwww live mad matroska mikmod mmx mmx2 mot
 mozilla moznocompose moznoirc moznomail mpeg ncurses net network nls oggvorbi
opengl operanom2 oss pam pdflib perl png python quicktime readline rtc sdl sla
 spell sse ssl tcpd tetex theora tiff truetype unicode v4l v4l2 vim-with-x wxw
dows x86 xface xml2 xmms xosd xprint xv xvid zlib"


Yuri.

Fixed in CVS