Bugzilla Bug 67528

It seems that links-2.1_pre15 will not compile with the unicode flag set.

My system
Portage 2.0.51_rc9 (default-x86-2004.2, gcc-3.4.2, glibc-2.3.4.20041006-r0, 2.6.8-gentoo-r8 i686)
=================================================================
System uname: 2.6.8-gentoo-r8 i686 Intel(R) Pentium(R) III Mobile CPU      1000MHz
Gentoo Base System version 1.5.3
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2-r1
Headers:  sys-kernel/linux26-headers-2.6.8.1-r1
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=pentium3 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium3 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs candy ccache distlocks sandbox"
GENTOO_MIRRORS="http://gentoo.osuosl.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-s"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/trunk"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"


Reproducible: Always
Steps to Reproduce:
1.emerge -vp links-2.1_pre15  +X -directfb +fbcon +gpm* +javascript* +jpeg +png +ssl -svga* -tiff +unicode 
2.
3.

Actual Results:  
I get this error:

n file included from /usr/include/png.h:349,
                 from links.h:127,
                 from af_unix.c:6:
/usr/include/pngconf.h:263:2: warning: #warning __png.h__ already includes setjmp.h;
/usr/include/pngconf.h:264:2: warning: #warning __dont__ include it again.;
In file included from links.h:1869,
                 from af_unix.c:6:
language.h:194: error: parse error before numeric constant
language.h:194: error: stray '\248' in program
language.h:194: error: missing terminating " character
language.h:195: error: stray '\248' in program
language.h:195: error: missing terminating " character
make: *** [af_unix.o] Error 1

!!! ERROR: net-www/links-2.1_pre15 failed.
!!! Function src_compile, Line 114, Exitcode 2
!!! make failed
!!! If you need support, post the topmost build error, NOT this status message.

Expected Results:  
No errros at all...

Please don't assign bugs unless you know where they should be going.

Rune,

I didn't get any errors.
It seems the only difference is the kernel version, the CFLAGS, the FEATURES and the MAKEOPTS.
Try changing one of these to see the results.

Regards,
Ingo -LaSombra- Hoffmann
--
Portage 2.0.51_rc9 (default-x86-1.4, gcc-3.4.2, glibc-2.3.4.20041006-r0, 2.6.8-gentoo-r4 i686)
=================================================================
System uname: 2.6.8-gentoo-r4 i686 AMD Athlon(TM) XP 1800+
Gentoo Base System version 1.5.3
distcc 2.17 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2-r1
Headers:  sys-kernel/linux26-headers-2.6.8.1-r1
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O2 -pipe -mmmx -msse -m3dnow -mfpmath=sse,387 -fomit-frame-pointer -fforce-addr -frerun-loop-opt -frerun-cse-after-loop -falign-functions=4"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O2 -pipe -mmmx -msse -m3dnow -mfpmath=sse,387 -fomit-frame-pointer -fforce-addr -frerun-loop-opt -frerun-cse-after-loop -falign-functions=4"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distlocks fixpackages sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu                           http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X aalib alsa apm arts avi berkdb bitmap-fonts crypt cups dga dvd encode f77 fbcon foomaticdb gdbm gif gphoto2 gpm gtk gtk2 imlib java jpeg kde libg++ libwww mad mmx motif moznocompose moznoirc moznomail mpeg ncurses nls nptl oggvorbis opengl pam pda pdflib perl pic png ppds python qt quicktime readline samba sdl slang spell sse ssl tcltk tcpd threads tiff truetype usb x86 xml2 xmms xprint xv zlib"

I can confirm this problem:

  # USE="-unicode" emerge links

emerges successfuly,

  # USE="unicode" emerge links

fails to emerge, error is as reported by Rune.

please try again

Rui,

Send your emerge --info pls.

vincent ~ # emerge --info
Portage 2.0.51-r2 (default-x86-1.4, gcc-3.4.1, glibc-2.3.4.20041006-r0, 2.6.9-gentoo-r1 i686)
=================================================================
System uname: 2.6.9-gentoo-r1 i686 Intel(R) Pentium(R) 4 CPU 2.53GHz
Gentoo Base System version 1.6.4
distcc 2.18 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [disabled]
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.92.0.2-r1
Headers:  sys-kernel/linux-headers-2.4.22
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -msse -msse2 -mmmx -funroll-loops -fprefetch-loop-arrays -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -fomit-frame-pointer -msse -msse2 -mmmx -funroll-loops -fprefetch-loop-arrays -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs distlocks sandbox"
GENTOO_MIRRORS="ftp://vlaai.snt.ipv6.utwente.nl/pub/os/linux/gentoo/ ftp://ftp6.uni-erlangen.de/pub/mirrors/gentoo ftp:///ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/ http://vlaai.snt.ipv6.utwente.nl/pub/os/linux/gentoo/ ftp://ftp6.uni-muenster.de/pub/linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/media/cdrom/"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X aalib acpi alsa apache2 apm arts avi berkdb bitmap-fonts cdparanoia cdr crypt cups dba divx4linux dv dvd encode flac flash foomaticdb gd gdbm gif gphoto2 gpm gtk2 i8x0 imap imlib ipv6 java jpeg kde ldap libg++ libwww mad mikmod mmx mmx2 motif mpeg mysql ncurses network nls oggvorbis opengl pam pcmcia pdflib perl php png postgres pt pt_PT python qt quicktime radeon readline samba sdl slang smime spell sse ssl svg svga tcpd theora tiff truetype unicode x86 xine xinerama xml2 xprint xv xvid zlib video_cards_ati linguas_pt"

i commited a (maybe) fix, please test again

I did an emerge sync, tried emerge links with unicode flag and ot still fails
to compile, but now there seems to be a few mores errors:

[...]
In file included from links.h:1869,
                 from bfu.c:6:
language.h:194: error: syntax error before numeric constant
language.h:194: error: stray '\248' in program
language.h:194: error: missing terminating " character
language.h:195: error: stray '\248' in program
language.h:195: error: missing terminating " character
In file included from /usr/include/png.h:349,
                 from links.h:127,
                 from bookmarks.c:9:
/usr/include/pngconf.h:263:2: warning: #warning __png.h__ already includes
setjmp.h;
/usr/include/pngconf.h:264:2: warning: #warning __dont__ include it again.;
In file included from links.h:1869,
                 from bookmarks.c:9:
language.h:194: error: syntax error before numeric constant
language.h:194: error: stray '\248' in program
language.h:194: error: missing terminating " character
language.h:195: error: stray '\248' in program
language.h:195: error: missing terminating " character
bfu.c: In function `check_float':
bfu.c:1417: error: `dummyarray' undeclared (first use in this function)
bfu.c:1417: error: (Each undeclared identifier is reported only once
bfu.c:1417: error: for each function it appears in.)
bfu.c: In function `check_number':
bfu.c:1432: error: `dummyarray' undeclared (first use in this function)
bfu.c: In function `check_hex_number':
bfu.c:1447: error: `dummyarray' undeclared (first use in this function)
bfu.c: In function `check_nonempty':
bfu.c:1461: error: `dummyarray' undeclared (first use in this function)
bookmarks.c:185: error: `dummyarray' undeclared here (not in a function)
bookmarks.c:185: error: initializer element is not constant
bookmarks.c:185: error: (near initialization for `bm_add_msg[0]')
bookmarks.c:186: error: initializer element is not constant
bookmarks.c:186: error: (near initialization for `bm_add_msg[1]')
make: *** [bookmarks.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [bfu.o] Error 1

Confirm this problem. Links still not compile with unicode... Fix it please....

I can still confirm that LInks will not compile.
I cannot see why CFLASG should be altered becuase, mine is much simpler than your, Ingo. I get the same error as #8 Rui :(

I can confirm, that the BUG still exists.

I got the #1 error message only after rebuilding ncurses with unicode USE flag.
I've been playing with unicode support all day today. I rebuilt links with
unicode flag a few times without any error. To fix behaviour of links with
unicode support I rebuilt ncurses with unicode and then tried to rebuild links
once again - only in that moment I got the #1 error message.
Maybe this info will help someone to trace the error source.

I've solved it :-)
The problem is in Links source in file "intl/english.lng". There are 2 words in Czech language ("Přejmenovat" and "Přepsat" meaning "Rename" and "Overwrite") amongst English texts. They're in iso-8859-2 encoding, so they contain charracters illegal in UTF8. When gen-intl is lauched, it corrupts language.h - you can see text "řejmenovat" there, which really isn't a valid C statement.
It's important to mention that you can encounter this bug only when you use an UTF8 locale (because 8-bit encodings don't have any illegal characters).
I attached a "patched patch" - links-2.1pre15-utf8.diff.bz2 with "translation" of those offending Czech words :-)

Created an attachment (id=45996) [details]
Replacement of links-2.1pre15-utf8.diff.bz2 which fixes this bug

Lukas Turek has the correct solution.

File links-2.1_pre15.ebuild has two lines "export LANG=C" that try to work around this problem. However those should have been "export LC_CTYPE=C" for the workaround to act correctly.

You can check it with: LC_ALL=en_US.UTF-8 USE=unicode emerge links

The bug was fixed upstream (in CVS version).

*** Bug 74925 has been marked as a duplicate of this bug. ***

thx, i updated the patch