Bug 67345 – libgnome-2.8.0 ebuild fails on alpha

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrej Filipcic 2004-10-13 00:56:17 UTC]

compile with gcc-3.3.4-r2 fails due to incompatible type for va_list argument in
libgnome/gnome-program.c.

Here is a patch:

diff -ur libgnome-2.8.0/libgnome/gnome-program.c libgnome-2.8.0.af/libgnome/gnome-program.c
--- libgnome-2.8.0/libgnome/gnome-program.c     2004-10-13 09:43:56.000000000 +0200
+++ libgnome-2.8.0.af/libgnome/gnome-program.c  2004-10-13 09:42:33.000000000 +0200
@@ -1928,6 +1928,7 @@
                            int argc, char **argv,
                            guint nparams, GParameter *params)
 {
+    va_list va;
     return gnome_program_init_common (type, app_id, app_version, module_info,
-                                     argc, argv, NULL, 0, nparams, params);
+                                     argc, argv, NULL, va, nparams, params);
 }

[Comment 1 foser (RETIRED) 2004-10-20 04:40:57 UTC]

wouldn't NULL instead of 0 work ?

[Comment 2 Andrej Filipcic 2004-10-20 04:50:10 UTC]

No, the 8th argument is not a pointer.
...
gnome-program.c:1932: error: incompatible type for argument 8 of `gnome_program_init_common'
...

[Comment 3 Aron Griffis (RETIRED) 2004-10-21 09:19:45 UTC]

va_list is implemented as a pointer on x86, not so on alpha.  The suggested patch is correct because it doesn't make architecture-specific assumptions.  The nparams argument protects against trying to use this uninitialized va_list (it's at least as safe as using a NULL va_list)

I applied this patch, thanks Andrej