First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 67345
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Alpha Porters <alpha@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Andrej Filipcic <andrej.filipcic@ijs.si>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 67345 depends on: Show dependency tree
Bug 67345 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2004-10-13 00:56 0000
compile with gcc-3.3.4-r2 fails due to incompatible type for va_list argument
in
libgnome/gnome-program.c.

Here is a patch:

diff -ur libgnome-2.8.0/libgnome/gnome-program.c
libgnome-2.8.0.af/libgnome/gnome-program.c
--- libgnome-2.8.0/libgnome/gnome-program.c     2004-10-13 09:43:56.000000000
+0200
+++ libgnome-2.8.0.af/libgnome/gnome-program.c  2004-10-13 09:42:33.000000000
+0200
@@ -1928,6 +1928,7 @@
                            int argc, char **argv,
                            guint nparams, GParameter *params)
 {
+    va_list va;
     return gnome_program_init_common (type, app_id, app_version, module_info,
-                                     argc, argv, NULL, 0, nparams, params);
+                                     argc, argv, NULL, va, nparams, params);
 }

------- Comment #1 From foser (RETIRED) 2004-10-20 04:40:57 0000 -------
wouldn't NULL instead of 0 work ?

------- Comment #2 From Andrej Filipcic 2004-10-20 04:50:10 0000 -------
No, the 8th argument is not a pointer.
...
gnome-program.c:1932: error: incompatible type for argument 8 of `gnome_program_init_common'
...

------- Comment #3 From Aron Griffis (RETIRED) 2004-10-21 09:19:45 0000 -------
va_list is implemented as a pointer on x86, not so on alpha.  The suggested
patch is correct because it doesn't make architecture-specific assumptions. 
The nparams argument protects against trying to use this uninitialized va_list
(it's at least as safe as using a NULL va_list)

I applied this patch, thanks Andrej

First Last Prev Next    No search results available      Search page      Enter new bug