Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 67109 - freeciv-2.0.1.ebuild (version bump)
Summary: freeciv-2.0.1.ebuild (version bump)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Games
URL: http://www.freeciv.org
Whiteboard:
Keywords:
: 89469 90580 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-11 07:46 UTC by Stefan Schweizer (RETIRED)
Modified: 2005-06-03 03:08 UTC (History)
23 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for beta4 with DEPEND fixes (freeciv-2.0.0_beta4.ebuild,2.27 KB, text/plain)
2004-11-23 13:16 UTC, AD Rutledge
Details
freeciv-2.0.0_beta6.ebuild (freeciv-2.0.0_beta6.ebuild,2.13 KB, text/plain)
2005-01-03 18:56 UTC, Colin Macdonald
Details
beta7 ebuild with ~amd64 (freeciv-2.0.0_beta7.ebuild,2.14 KB, text/plain)
2005-02-10 21:09 UTC, Steffen Jobbagy-Felso
Details
Ebuild for 2.0.0 stable (freeciv-2.0.0.ebuild,2.08 KB, text/plain)
2005-04-18 23:31 UTC, James Coplin
Details
freeciv-2.0.0.ebuild (freeciv-2.0.0.ebuild,1.99 KB, text/plain)
2005-04-22 00:56 UTC, Markus Rothe (RETIRED)
Details
freeciv-2.0.1.ebuild (freeciv-2.0.1.ebuild,2.32 KB, text/plain)
2005-04-30 05:51 UTC, TGL
Details
freeciv-2.0.1.ebuild (freeciv-2.0.1.ebuild,4.56 KB, text/plain)
2005-04-30 09:54 UTC, TGL
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schweizer (RETIRED) gentoo-dev 2004-10-11 07:46:36 UTC
Hi,

a new beta of freeciv is out, it has a lot of improvements compared to the stable versin so I think its worth having it in portage.

Stefan Schweizer(genstef)
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2004-10-14 11:59:18 UTC
freeciv 2 is pretty fresh yet.  Reopen when it's come along a bit more.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2004-10-21 22:27:45 UTC
*** Bug 68496 has been marked as a duplicate of this bug. ***
Comment 3 Charles Goodwin 2004-10-31 09:19:09 UTC
Amended the title to say beta2.  Not that it makes a difference.  It's just more... correct.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2004-11-03 22:20:19 UTC
*** Bug 70007 has been marked as a duplicate of this bug. ***
Comment 5 AD Rutledge 2004-11-23 13:16:54 UTC
Created attachment 44591 [details]
Ebuild for beta4 with DEPEND fixes

beta4 makes libiconv non-optional, but from what I can tell, libiconv is a part
of glibc, now?

-AD Rutledge
Comment 6 MasterX 2004-12-17 15:43:47 UTC
I was not able to compile freeciv-2.0.0beta4, with this ebuild. I was however, able to compile by extracting in the home directory and running configure and make. The problem was sdl, when I removed the lines that had sdl, freeciv-2.0.0beta4 compiled without a single problem.

Besides that it works fine, for a beta version. I was also able to use the 3D effect (civ3)
Comment 7 Colin Macdonald 2005-01-03 11:53:24 UTC
Its beta5 now.  I can confirm the problem in Comment #6.  Here's the error:

make[4]: Entering directory `/var/tmp/portage/freeciv-2.0.0_beta5/work/freeciv-2.0.0-beta5/client/gui-sdl'i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../..  -I. -I./.. -I./../include -I../../utility -I../../common -I../../common/aicore -I../../intl -I./../agents -I/usr/include/SDL -D_REENTRANT -I/usr/include/freetype2   -march=athlon-xp -O3 -pipe -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -I/usr/include/SDL -D_REENTRANT -c chatline.c
i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../..  -I. -I./.. -I./../include -I../../utility -I../../common -I../../common/aicore -I../../intl -I./../agents -I/usr/include/SDL -D_REENTRANT -I/usr/include/freetype2   -march=athlon-xp -O3 -pipe -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations -I/usr/include/SDL -D_REENTRANT -c citydlg.c
chatline.c: In function `inputline_return_callback':
chatline.c:92: error: too few arguments to function `real_append_output_window'
chatline.c: In function `real_append_output_window':
chatline.c:151: warning: passing arg 2 of `add_notify_window' makes pointer from integer without a cast
chatline.c:151: error: too many arguments to function `add_notify_window'
citydlg.c: In function `activate_and_exit_units_orders_city_dlg_callback':
citydlg.c:289: error: structure has no member named `x'
citydlg.c:289: error: structure has no member named `y'
citydlg.c:289: error: too many arguments to function `center_tile_mapcanvas'
citydlg.c: In function `units_orders_city_dlg_callback':
citydlg.c:423: error: structure has no member named `x'
citydlg.c:423: error: structure has no member named `y'
citydlg.c:423: error: too many arguments to function `center_tile_mapcanvas'
citydlg.c: In function `misc_panel_city_dlg_callback':
citydlg.c:913: error: `CITIZEN_TAXMAN' undeclared (first use in this function)
citydlg.c:913: error: (Each undeclared identifier is reported only once
citydlg.c:913: error: for each function it appears in.)
citydlg.c:920: error: `CITIZEN_ELVIS' undeclared (first use in this function)
citydlg.c:927: error: `CITIZEN_SCIENTIST' undeclared (first use in this function)
citydlg.c: In function `create_city_options_widget_list':
citydlg.c:1030: error: `CITIZEN_SCIENTIST' undeclared (first use in this function)
citydlg.c:1035: error: `CITIZEN_TAXMAN' undeclared (first use in this function)
citydlg.c:1040: error: `CITIZEN_ELVIS' undeclared (first use in this function)

If build with -sdl then it builds correctly (because it doesn't build the sdl client).  Game seems to work correctly (I wanted to see the hex tile graphics).  For some reason,  the X civ client seems to start fullscreen and I don't see how to make it return to being a normal X window but maybe its just me.

I will submit this bug upstream because the sdl thing is probably not Gentoo's fault.
Comment 8 Colin Macdonald 2005-01-03 14:07:30 UTC
beta6 is out, same error.
Comment 9 Colin Macdonald 2005-01-03 18:56:33 UTC
Created attachment 47546 [details]
freeciv-2.0.0_beta6.ebuild

From upstream:

"The SDL client is no longer being maintained, alas."

http://bugs.freeciv.org/Ticket/Display.html?id=11782

The attached ebuild for beta6 has all the sdl stuff removed.
Comment 10 Stefan Schweizer (RETIRED) gentoo-dev 2005-01-09 05:25:10 UTC
I think beta6 has come alot very much now .. it should be ready to go into the tree.

The latest ebuild postet on this bug works for me.

games herd: Can you please take care of this?
Comment 11 Marco Nierlich 2005-01-09 05:57:14 UTC
beta6 works here out of the box. thanks!
Comment 12 Mirko D. Walter 2005-01-11 10:03:06 UTC
works here (beta6)
Comment 13 Colin Macdonald 2005-01-21 17:12:52 UTC
beta7 seems to work using same ebuild as beta6.
Comment 14 Mr. Bones. (RETIRED) gentoo-dev 2005-01-24 17:10:12 UTC
*** Bug 79402 has been marked as a duplicate of this bug. ***
Comment 15 Sebastian Roeder 2005-02-01 02:35:50 UTC
I want to emerge freeciv and have the following USE-flags set:
[code]whiterabbit ~ # emerge -pv freeciv

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] games-strategy/freeciv-1.14.2  +X -Xaw3d -gtk +gtk2 +nls +readline 0 kB [/code]

I expect to get the gtk-2 client of freeciv, but no way, I always get the fuc**** xaw client. When I pass the -X flag, I get only the server, not the client (of cause).

The ebuild looks like it would prefer the gtk-2 useflag over the xaw useflag as far as I know:
[code]IUSE="X Xaw3d gtk gtk2 nls readline"

RDEPEND="X? ( virtual/x11 )
        Xaw3d? ( x11-libs/Xaw3d )
        readline? ( sys-libs/readline )
        sys-libs/zlib
        >=media-libs/libsdl-1.1.4
        media-libs/sdl-mixer
        media-libs/sdl-image
        gtk? (
                        gtk2? (
                                >=x11-libs/gtk+-2.0.0
                                >=dev-libs/glib-2.0.0
                                >=dev-libs/atk-1.0.3
                                >=x11-libs/pango-1.0.5
                        )
                        !gtk2? (
                                =x11-libs/gtk+-1*
                                >=dev-libs/glib-1.2.5
                                >=media-libs/imlib-1.9.2
                        )
                )"
DEPEND="${RDEPEND}
        nls? ( sys-devel/gettext )
        >=sys-apps/sed-4"

src_compile() {
        local myclient="no"
        use X && myclient="xaw"
        use Xaw3d && myclient="xaw3d"
        if use gtk ; then
                use gtk2 \
                        && myclient="gtk-2.0" \
                        || myclient="gtk"
        fi
        egamesconf \
[/code]

But the portage logfile shows, that the xaw client is installed, not the gtk-2:

[code]./configure --prefix=/usr/games --host=i686-pc-linux-gnu --mandir=/usr/share/man 
--infodir=/usr/share/info --datadir=/usr/share/games --sysconfdir=/etc/games --lo
calstatedir=/var/games --disable-dependency-tracking --with-zlib --with-readline 
--enable-nls --enable-client=xaw
[quote]

Am I doing something wrong? I tryied differnt USE-flags, but didn`t suceed.
Comment 16 Sebastian Roeder 2005-02-01 02:46:12 UTC
EDIT: Works when I set both the gtk and gtk2 USE flag. Shouldn`t it work with the gtk2 USE flag only?
Comment 17 Chris Gianelloni (RETIRED) gentoo-dev 2005-02-01 05:16:46 UTC
No.

The gtk USE flag enables gtk support.  This means all gtk support, either gtk1 *or* gtk2.  The gtk2 USE flag simply means "if there is both gtk1 *and* gtk2 support, I prefer gtk2".  If you do not have gtk in USE, you will not get *any* optional gtk interface.  If you do not have gtk2 in USE, you will get the gtk1 interface.  So to get the gtk2 interface, you need both gtk and gtk2 in USE.
Comment 18 Steffen Jobbagy-Felso 2005-02-10 21:09:14 UTC
Created attachment 50982 [details]
beta7 ebuild with ~amd64

Change to beta7 is only the file name, added ~amd64 to the keywords - could
someone add this ebuild to portage, it seems to be working good (and I used
beta4-6 x86 with only one problem, that's fine for ~ isn't it?)
Comment 19 Steffen Jobbagy-Felso 2005-02-10 21:17:38 UTC
Also a USE flag sdl or something for a dependency to sdl-mixer would be useful, I will try adding that tomorrow.. if I don't post it assume I failed ;)
Comment 20 Steffen Jobbagy-Felso 2005-02-10 21:19:48 UTC
I should sleep more.. no point having a sdl flag if that's not maintained anymore, shame on me
Comment 21 Mr. Bones. (RETIRED) gentoo-dev 2005-02-10 22:28:55 UTC
reopen when it's not beta.  Thanks.
Comment 22 Mr. Bones. (RETIRED) gentoo-dev 2005-02-22 08:08:20 UTC
*** Bug 82922 has been marked as a duplicate of this bug. ***
Comment 23 Mr. Bones. (RETIRED) gentoo-dev 2005-03-10 09:52:26 UTC
*** Bug 84764 has been marked as a duplicate of this bug. ***
Comment 24 wim van boven 2005-04-04 11:34:00 UTC
renaming to freeciv-2.0.0_rc1.ebuild works fine 
Comment 25 Mr. Bones. (RETIRED) gentoo-dev 2005-04-10 16:39:32 UTC
*** Bug 88623 has been marked as a duplicate of this bug. ***
Comment 26 Mr. Bones. (RETIRED) gentoo-dev 2005-04-17 17:21:11 UTC
*** Bug 89469 has been marked as a duplicate of this bug. ***
Comment 27 Mr. Bones. (RETIRED) gentoo-dev 2005-04-17 17:22:45 UTC
2.0.0 has been released.
Comment 28 Mr. Bones. (RETIRED) gentoo-dev 2005-04-17 22:59:19 UTC
Bonus points if someone fixes up the nls handling for 2.0.0, improves the deps and includes support for the dedicated use flag for bug #71283
Comment 29 James Coplin 2005-04-18 23:31:22 UTC
Created attachment 56624 [details]
Ebuild for 2.0.0 stable

This should work as an ebuild for the 2.0.0 stable release.
Comment 30 Mr. Bones. (RETIRED) gentoo-dev 2005-04-19 08:01:43 UTC
Comment on attachment 56624 [details]
Ebuild for 2.0.0 stable

No, it doesn't handle do any of the things I mentioned.
Comment 31 Mr. Bones. (RETIRED) gentoo-dev 2005-04-19 08:01:55 UTC
Comment on attachment 56624 [details]
Ebuild for 2.0.0 stable

No, it doesn't do any of the things I mentioned.
Comment 32 Yuri Karaban 2005-04-20 02:15:20 UTC
Better to have freeciv-2.0.0 (even without nls support, it can excluded from IUSE until it correctly handled).

So maybe to disable nls in IUSE and create ebuild for freeciv-2.0.0 with minus or tilde keyword?
Comment 33 Markus Rothe (RETIRED) gentoo-dev 2005-04-22 00:56:03 UTC
Created attachment 56904 [details]
freeciv-2.0.0.ebuild

If I understand this correctly, there is no need for sdl use flag any more as
it is broken and unmaintained.

also we should install to /usr/lib/X11/app-defaults instead of
/usr/X11R6/lib/X11/app-defaults, don't we?

nls works out of the box, with the provided ebuild.

So here are the changes I made to the ebuild:

##############################################################################
--- freeciv-2.0.0.ebuild.old	2005-04-22 07:50:55.685353784 +0000
+++ freeciv-2.0.0.ebuild	2005-04-22 07:51:48.265360408 +0000
@@ -13,18 +13,14 @@
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="~x86"
-IUSE="X Xaw3d gtk gtk2 sdl nls readline"
+KEYWORDS="~ppc ~x86"
+IUSE="X Xaw3d gtk gtk2 nls readline"
 
 
 RDEPEND="X? ( virtual/x11 )
	Xaw3d? ( x11-libs/Xaw3d )
	readline? ( sys-libs/readline )
	sys-libs/zlib
-	sdl? (
-		>=media-libs/libsdl-1.1.4
-		media-libs/sdl-mixer
-		media-libs/sdl-image )
	gtk? (
			gtk2? (
				>=x11-libs/gtk+-2.0.0
@@ -73,7 +69,7 @@
 src_install() {
	make DESTDIR="${D}" install || die "make install failed"
 
-	insinto /usr/X11R6/lib/X11/app-defaults
+	insinto /usr/lib/X11/app-defaults
	doins data/Freeciv || die "doins failed"
 
	dodoc ChangeLog INSTALL NEWS \
@@ -82,4 +78,4 @@
	# install sounds
	cp -R ../stdsounds* "${D}${GAMES_DATADIR}/${PN}"
	prepgamesdirs
-}
\ No newline at end of file
+}
##############################################################################
Comment 34 Mike Baikov 2005-04-22 02:23:36 UTC
When i save the game, the game lost information about hidden's properties of map. Is normal?
Comment 35 Arun Raghavan (RETIRED) gentoo-dev 2005-04-24 03:09:35 UTC
The ebuild works for me too
Comment 36 Björn Michaelsen 2005-04-25 05:36:04 UTC
<AOL-mode>
/me too.
Works here.
</AOL-mode>
Comment 37 Federico Zenith 2005-04-25 15:20:40 UTC
freeciv-2.0.0.ebuild (5th) works on amd64.
Comment 38 Mr. Bones. (RETIRED) gentoo-dev 2005-04-25 16:52:31 UTC
The most recent submitted ebuild installs files in the wrong locations as well.
/usr/games/share/ isn't the right place for desktop files.  /usr/share/games/locale isn't the right place for the locale files.
Comment 39 Jakub Moc (RETIRED) gentoo-dev 2005-04-27 03:07:12 UTC
*** Bug 90580 has been marked as a duplicate of this bug. ***
Comment 40 TGL 2005-04-30 05:50:28 UTC
I will attach an updated ebuild which:
 - fixes locale installation path
 - fixes .desktop installation path
 - adds the "dedicated" use flag (removes some useless stuffs if built as a dedicated server, and also removes the "X" flag because xaw becomes the default client if not built as a dedicated server)
 - remove the libogg deps, because they were not used

The only remaining issue i see is deps on sound-related libraries, which are completly broken. I will come back on this later, but in the mean time you can have a look here to see what is missing:
http://tdegreni.free.fr/gentoo/freeciv-gtk2.ps
(The lib deps shown are all direct dynamic linking deps. The graph is built by dotfinder.py, which you can find in the same directory.)
Comment 41 TGL 2005-04-30 05:51:48 UTC
Created attachment 57671 [details]
freeciv-2.0.1.ebuild
Comment 42 TGL 2005-04-30 06:03:59 UTC
Other TODO items:

* The civclient (the gtk2 one at least) generates an empty "music.raw" file in the current directory. That's bad.

* I wonder what to do with the civmanual binary. It is meant to generate some localized html manual pages for the server. It should probably be ran by the ebuild but not installed (only the html pages would be). But in that case, this pages may not be localized... Any idea?
Comment 43 TGL 2005-04-30 09:54:39 UTC
Created attachment 57681 [details]
freeciv-2.0.1.ebuild

Here is a version that:
 - fixes the sound libs dependencies
 - create html manual and install it instead of installing 'civmanual' (it
won't be localized, but that's not that important since the informations are
also available in the client and server online help anyway)
 - cleanup a few more things

About sound plugins:
 - i couldn't reproduce my zero-length "music.raw" file bug with any of the
plugin, so i have no idea what happened the first time.
 - here, the alsa plugin behaves badly if I let the introduction music looping
more than a few seconds. Would be nice if other people could test it, cause if
it doesn't work for anybody, then there is no point in keeping that option.
Comment 44 Mr. Bones. (RETIRED) gentoo-dev 2005-04-30 21:49:43 UTC
freeciv-2.0.1.ebuild added to portage.
Comment 45 Bernard Cafarelli gentoo-dev 2005-05-01 06:16:23 UTC
Also, freeciv-2.0.1 runs fine on amd64, the ebuild should at least have the ~amd64 keyword (freeciv 1.14 had amd64)