Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 65666 - wcstools-3.5.7.ebuild (New package)
Summary: wcstools-3.5.7.ebuild (New package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2004-09-28 04:56 UTC by Sébastien Fabbro (RETIRED)
Modified: 2005-10-02 08:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wcstools-3.5.7.ebuild (new package) (wcstools-3.5.7.ebuild,748 bytes, text/plain)
2004-09-28 04:57 UTC, Sébastien Fabbro (RETIRED)
Details
wcstools-3.5.7.ebuild (corrected man path) (wcstools-3.5.7.ebuild,753 bytes, text/plain)
2004-09-28 05:09 UTC, Sébastien Fabbro (RETIRED)
Details
wcstools-3.6.2.ebuild (wcstools-3.6.2.ebuild,754 bytes, text/plain)
2005-09-08 04:06 UTC, Sébastien Fabbro (RETIRED)
Details
wcstools-3.6.2.ebuild (wcstools-3.6.2.ebuild,735 bytes, text/plain)
2005-09-10 18:04 UTC, Sébastien Fabbro (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sébastien Fabbro (RETIRED) gentoo-dev 2004-09-28 04:56:58 UTC
Hi 

Please find wcstools, an astronomical library and execs to handle the World Coordinate System.

Sebastien.
Comment 1 Sébastien Fabbro (RETIRED) gentoo-dev 2004-09-28 04:57:37 UTC
Created attachment 40602 [details]
wcstools-3.5.7.ebuild (new package)
Comment 2 Sébastien Fabbro (RETIRED) gentoo-dev 2004-09-28 05:09:30 UTC
Created attachment 40603 [details]
wcstools-3.5.7.ebuild (corrected man path)
Comment 3 Sébastien Fabbro (RETIRED) gentoo-dev 2005-09-08 04:06:39 UTC
Created attachment 67915 [details]
wcstools-3.6.2.ebuild

Version bump and ebuild update
Comment 4 Olivier Fisette (RETIRED) gentoo-dev 2005-09-10 13:14:58 UTC
Hi Sebastien, 
   
I would like you to try improving this ebuild. Here are a few  
suggestions/questions:   
   
- In SRC_URI, you should replace the package name by the corresponding  
  variable. 
- Why have you turned on the nomirror restriction? I could not find anything  
  about not being allowed to redistribute the software. Did I miss it?  
- When you edit, move or otherwise change files in the build directory, you   
  should handle the return code of the command to raise an error if it is not   
  successful. For instance, you would use:  
      mv libwcs/libwcs.a libwcs/libwcstools.a || die  
  rather than:  
      mv libwcs/libwcs.a libwcs/libwcstools.a  
- You must also use the "die" function to handle the return code of commands  
  used to install files. These include functions such as dobin, doman and  
  dodoc. In general, everytime a command must succeed for the package to be 
  installed correctly and you cannot guarantee the error will be caught later 
  in the ebuild, you must use the "|| die" construct. 
- You are currently not honoring the user's C compiler choice. I think you 
  could easily fix that by using the toolchain-funcs eclass and passing the 
  compiler's name to the build process (in rather the same way you already  
  handle CFLAGS). 
 
Thanks, and keep up the good work, ;-) 
Comment 5 Sébastien Fabbro (RETIRED) gentoo-dev 2005-09-10 18:04:29 UTC
Created attachment 68150 [details]
wcstools-3.6.2.ebuild

Corrected ebuild according to previous comments and a bit of cleaning.
Comment 6 Olivier Fisette (RETIRED) gentoo-dev 2005-10-02 08:23:28 UTC
In CVS. Thanks for your work, Sebastien.