Bugzilla Bug 65666

Hi 

Please find wcstools, an astronomical library and execs to handle the World Coordinate System.

Sebastien.

Created an attachment (id=40602) [edit]
wcstools-3.5.7.ebuild (new package)

Created an attachment (id=40603) [edit]
wcstools-3.5.7.ebuild (corrected man path)

Created an attachment (id=67915) [edit]
wcstools-3.6.2.ebuild

Version bump and ebuild update

Hi Sebastien, 
   
I would like you to try improving this ebuild. Here are a few  
suggestions/questions:   
   
- In SRC_URI, you should replace the package name by the corresponding  
  variable. 
- Why have you turned on the nomirror restriction? I could not find anything  
  about not being allowed to redistribute the software. Did I miss it?  
- When you edit, move or otherwise change files in the build directory, you   
  should handle the return code of the command to raise an error if it is not   
  successful. For instance, you would use:  
      mv libwcs/libwcs.a libwcs/libwcstools.a || die  
  rather than:  
      mv libwcs/libwcs.a libwcs/libwcstools.a  
- You must also use the "die" function to handle the return code of commands  
  used to install files. These include functions such as dobin, doman and  
  dodoc. In general, everytime a command must succeed for the package to be 
  installed correctly and you cannot guarantee the error will be caught later 
  in the ebuild, you must use the "|| die" construct. 
- You are currently not honoring the user's C compiler choice. I think you 
  could easily fix that by using the toolchain-funcs eclass and passing the 
  compiler's name to the build process (in rather the same way you already  
  handle CFLAGS). 
 
Thanks, and keep up the good work, ;-) 

Created an attachment (id=68150) [edit]
wcstools-3.6.2.ebuild

Corrected ebuild according to previous comments and a bit of cleaning.

In CVS. Thanks for your work, Sebastien.