Bugzilla Bug 64863

OpenTTD has support for playing its midi files through another midi player than
timidity by using the MIDI option to the makefile.  For example, I build with
MIDI=/usr/bin/pmidi to have OpenTTD play hardware midi through pmidi, in stead
of using timidity emulation.  It would be nice if the ebuild had support for
this, so that I can use the ebuild and get music without having to install
timidity.  (use flag or environment variable ?)

Reproducible: Always
Steps to Reproduce:

I talked to upstream and they might address this with a command-line option in
a future version.  Development doesn't seem to be going that quickly though and
since there hasn't been a release in a while, i'm going to mark this as
UPSTREAM since it won't be addressed until they release again.

Huh ?  That doesn't make sense.  OpenTTD already doesn't require timidity, only
the gentoo ebuild does.  As I said, all that needs to be done is to add
MIDI=/usr/bin/pmidi to the make line to use hardware midi through pmidi in
stead of software midi through timidity.  

All you have to do to support this is to check for the timidity USE flag in the
openttd ebuild (which you already do).  If it's disabled, you can depend on
pmidi in stead of timidity, and add MIDI=/usr/bin/pmidi to $(myopts).  There's
no need for any upstream changes.  Actually, if depending on pmidi is a
problem, you don't have to, since if /usr/bin/pmidi doesn't exist, it simply
won't be used.

Here, I'll make it easy for you.  Add this line to the openttd ebuild before
the emake line:

use timidity || myopts="${myopts} MIDI=/usr/bin/pmidi"

And change:
einfo "timidity not in USE so music will not be played during the game."
to:
einfo "timidity not in USE, using pmidi in stead.  emerge pmidi if you want
in-game music."

That's all that's required to make it work.

Fixed in 0.3.5