642204 – media-gfx/darktable-2.4.0 - Upstream ebuild review

Bug 642204 - media-gfx/darktable-2.4.0 - Upstream ebuild review

Summary: media-gfx/darktable-2.4.0 - Upstream ebuild review

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Graphics Project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-12-25 12:57 UTC by Lebedev Roman
Modified:	2017-12-29 12:07 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lebedev Roman 2017-12-25 12:57:47 UTC

darktable developer here.
a few notes on the ebuild https://github.com/gentoo/gentoo/blob/5cbe6607217626e40457960d14f7a4d1f14ebd0c/media-gfx/darktable/darktable-2.4.0.ebuild

1. zlib dependency is missing
2. KEYWORDS="~amd64 ~x86"  is wrong.
   x86 is rather deprecated and unsupported.
   and aarch64 should be added
3. # sse3 support is required to build darktable
   REQUIRED_USE="cpu_flags_x86_sse3"
   Not really true anymore. It is sse2, and only required for amd64.
4. virtual/opengl dependency is unneeded. dt does not need opengl directly
5. jpeg2k? ( media-libs/openjpeg:0 )  <- that should be openjp2/openjpeg-2.*
6. clang/gcc version check is missing, should be gcc-5+/clang-3.4+
6. cmake version check is missing, should be cmake-3.1


Reproducible: Always

Comment 1 Markus Meier gentoo-dev

2017-12-29 12:07:07 UTC

Ebuild updated, thanks for your feedback Roman!

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fa7f4aeddd82a70ba9446add9f88c7ed8327a16